Integrated: Merge jdk17

2021-07-13 Thread Jesper Wilhelmsson
On Wed, 14 Jul 2021 00:13:41 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 4a7ccf36 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/4a7ccf36e9a3978c437db3efe892dd23e8a0b772 Stats: 388 l

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

2021-07-13 Thread David Holmes
On Fri, 25 Jun 2021 21:04:27 GMT, Jorn Vernee wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Assert frame is correct type in frame_data_for_frame > > src/hotspot/share/runtime/safepoint.cpp line 931: > >> 929:

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

2021-07-13 Thread David Holmes
On Tue, 13 Jul 2021 15:16:26 GMT, Jorn Vernee wrote: >> This patch rewrites the prologue and epilogue of panama upcalls, in order to >> fix the test failure from the title. >> >> Previously, we did a call to potentially attach the current thread to the >> VM, and then afterwards did the same s

Re: SplittableGenerator of JEP 356

2021-07-13 Thread Michael Bien
Thank you for the explanation, This makes sense - I only wanted to bring it up in the (unlikely) case it was an oversight. My thinking was that there might be a potential use case of something like:     private static final SecureRandom shared_source = new SecureRandom(); // thread safe sour

[jdk17] Integrated: 8270056: Generated lambda class can not access protected static method of target class

2021-07-13 Thread Yi Yang
On Tue, 13 Jul 2021 03:06:12 GMT, Yi Yang wrote: > Hi all, > > this pull request contains a backport of commit 07e90524 from the openjdk/jdk > repository. > > The commit being backported was authored by Yi Yang on 13 Jul 2021 and was > reviewed by Mandy Chung. > > Thanks! This pull request

RFR: Merge jdk17

2021-07-13 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE - 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas - 8269281: java/foreign/Test{Down,Up}call.java time out - 8269635: Stress test

Re: RFR: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values

2021-07-13 Thread Joe Darcy
On Mon, 12 Jul 2021 19:39:13 GMT, Brian Burkhalter wrote: > Please consider this proposal to add some test coverage comparing `Math` and > `StrictMath` results of `pow()`. test/jdk/java/lang/Math/PowTests.java line 69: > 67: failures += Tests.testUlpDiff( > 68: "Str

Re: RFR: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values

2021-07-13 Thread Joe Darcy
On Mon, 12 Jul 2021 19:39:13 GMT, Brian Burkhalter wrote: > Please consider this proposal to add some test coverage comparing `Math` and > `StrictMath` results of `pow()`. test/jdk/java/lang/Math/PowTests.java line 65: > 63: int failures = 0; > 64: if (Double.isNaN(smResult)) {

Re: RFR: 8075806: divideExact is missing in java.lang.Math

2021-07-13 Thread Brian Burkhalter
On Tue, 13 Jul 2021 17:21:52 GMT, Brian Burkhalter wrote: > Please consider this proposal to add `divideExact()` methods for integral > data types to `java.lang.Math` thereby rounding out "exact" support to all > four basic arithmetic operations. Note: The `StrictMath` equivalents were intenti

[jdk17] Integrated: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE

2021-07-13 Thread Vicente Romero
On Sat, 10 Jul 2021 19:03:36 GMT, Vicente Romero wrote: > Please review this PR that is fixing a mismatch between the implementation > for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its > implementation. I made a mistake while working on a recent CSR > [JDK-8224985](https://

Re: [jdk17] RFR: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE [v3]

2021-07-13 Thread Vicente Romero
On Mon, 12 Jul 2021 18:06:30 GMT, Vicente Romero wrote: >> Please review this PR that is fixing a mismatch between the implementation >> for method `java.lang.constant.DynamicCallSiteDesc::withArgs` and its >> implementation. I made a mistake while working on a recent CSR >> [JDK-8224985](http

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v3]

2021-07-13 Thread Alexey Semenyuk
On Tue, 13 Jul 2021 16:39:01 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-82693

RFR: 8075806: divideExact is missing in java.lang.Math

2021-07-13 Thread Brian Burkhalter
Please consider this proposal to add `divideExact()` methods for integral data types to `java.lang.Math` thereby rounding out "exact" support to all four basic arithmetic operations. - Commit messages: - 8075806: divideExact is missing in java.lang.Math Changes: https://git.openjd

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

2021-07-13 Thread Vladimir Ivanov
On Tue, 13 Jul 2021 17:05:25 GMT, Vladimir Ivanov wrote: >> Thanks for the suggestion. I'd like to keep it the way it is though, so that >> the assert message contains the `has_last_frame` & `java_call_counter` >> values. (this was one of the reason I did this refactor as well, since the >> as

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

2021-07-13 Thread Vladimir Ivanov
On Tue, 13 Jul 2021 14:59:07 GMT, Jorn Vernee wrote: >> src/hotspot/share/runtime/thread.hpp line 1128: >> >>> 1126: >>> 1127: private: >>> 1128: DEBUG_ONLY(void verify_frame_info();) >> >> If you declare `verify_frame_info` as returning a `bool` (and just put a >> `return true;` at the en

Re: SplittableGenerator of JEP 356

2021-07-13 Thread Jim Laskey
From Guy: You are right that the comment in the JEP was a little loose, and that the implementation(s) of the split/splits methods could in principle draw random values from a RandomGenerator that is not itself splittable. There might even be applications for such functionality. However, we ch

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v3]

2021-07-13 Thread Andy Herrick
> JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8269387: jpackage --add-launcher should have option to not create short

Re: [jdk17] RFR: 8270056: Generated lambda class can not access protected static method of target class

2021-07-13 Thread Mandy Chung
On Tue, 13 Jul 2021 03:06:12 GMT, Yi Yang wrote: > Hi all, > > this pull request contains a backport of commit 07e90524 from the openjdk/jdk > repository. > > The commit being backported was authored by Yi Yang on 13 Jul 2021 and was > reviewed by Mandy Chung. > > Thanks! Marked as reviewed

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

2021-07-13 Thread Jorn Vernee
> This patch rewrites the prologue and epilogue of panama upcalls, in order to > fix the test failure from the title. > > Previously, we did a call to potentially attach the current thread to the VM, > and then afterwards did the same suspend and stack reguard checks that we do > on the back-ed

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC

2021-07-13 Thread Jorn Vernee
On Tue, 13 Jul 2021 13:52:18 GMT, Vladimir Ivanov wrote: >> This patch rewrites the prologue and epilogue of panama upcalls, in order to >> fix the test failure from the title. >> >> Previously, we did a call to potentially attach the current thread to the >> VM, and then afterwards did the sa

Re: SplittableGenerator of JEP 356

2021-07-13 Thread Michael Bien
just wanted to add that the JEP says: "SplittableRandomGenerator extends RandomGenerator and also provides methods named split and splits. Splittability allows the user to spawn a new RandomGenerator from an existing RandomGenerator that will generally produce statistically independent results."

Re: [jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC

2021-07-13 Thread Vladimir Ivanov
On Fri, 25 Jun 2021 17:38:32 GMT, Jorn Vernee wrote: > This patch rewrites the prologue and epilogue of panama upcalls, in order to > fix the test failure from the title. > > Previously, we did a call to potentially attach the current thread to the VM, > and then afterwards did the same suspen

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v9]

2021-07-13 Thread Attila Szegedi
On Wed, 2 Jun 2021 14:11:07 GMT, Сергей Цыпанов wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> comm

Re: [jdk17] RFR: JDK-8270075 SplittableRandom extends AbstractSplittableGenerator [v2]

2021-07-13 Thread Jim Laskey
> Random.AbstractSplittableGenerator is an internal class that should not be > exposed in a public API. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull reque

SplittableGenerator of JEP 356

2021-07-13 Thread Michael Bien
Hello, i was wondering if SplittableGenerator.split(SplittableGenerator source) is missing out on a potential usecase when the source itself is not splittable. The implementation looks like it only requires basic calls which could be also provided by the RandomGenerator interface as source.

[jdk17] Integrated: 8269281: java/foreign/Test{Down, Up}call.java time out

2021-07-13 Thread Maurizio Cimadamore
On Fri, 9 Jul 2021 15:01:15 GMT, Maurizio Cimadamore wrote: > After some more investigation, I have been able to at least partially > reproduce on my Linux box. While I can't get to same slowdown as we're seeing > in test machines, I did notice that in fastdebug mode, TestUpcall is a lot > sl

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v3]

2021-07-13 Thread Wang Huang
> Dear all, > Can you do me a favor to review this patch. This patch use `ldp` to > implement String.compareTo. > > * We add a JMH test case > * Here is the result of this test case > > Benchmark|(size)| Mode| Cnt|Score | Error |Units > ---