Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-28 Thread David Holmes
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote: > Short: this patch makes NMT available in custom-launcher scenarios and during > gtests. It simplifies NMT initialization. It adds a lot of NMT-specific > testing, cleans them up and makes them sideeffect-free. > > - > > NMT cont

Re: RFR: JDK-8256844: Make NMT late-initializable

2021-07-28 Thread David Holmes
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote: > Short: this patch makes NMT available in custom-launcher scenarios and during > gtests. It simplifies NMT initialization. It adds a lot of NMT-specific > testing, cleans them up and makes them sideeffect-free. > > - > > NMT cont

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package

2021-07-28 Thread David Holmes
On Thu, 29 Jul 2021 01:30:37 GMT, Vladimir Kozlov wrote: >> Hi all, >> >> could you please review this big tedious and trivial(-ish) patch which moves >> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? >> >> the majority of the patch is the following substitutions: >

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package

2021-07-28 Thread Vladimir Kozlov
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this big tedious and trivial(-ish) patch which moves > `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? > > the majority of the patch is the following substitutions: > - `s~s

[jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package

2021-07-28 Thread Igor Ignatyev
Hi all, could you please review this big tedious and trivial(-ish) patch which moves `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? the majority of the patch is the following substitutions: - `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g` - `s/sun.hotspot.par

Re: RFR: 8266936: Add a finalization JFR event [v4]

2021-07-28 Thread Brent Christian
On Tue, 27 Jul 2021 15:14:29 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info

[jdk17] Integrated: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
On Wed, 28 Jul 2021 17:51:31 GMT, Daniel D. Daugherty wrote: > 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java This pull request has now been integrated. Changeset: 7bf72ce3 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk17/commit/7bf72ce301de80f412660

Re: [jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
On Wed, 28 Jul 2021 18:42:11 GMT, Naoto Sato wrote: >> 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/pull/291

Re: [jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Naoto Sato
On Wed, 28 Jul 2021 17:51:31 GMT, Daniel D. Daugherty wrote: > 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/291

[jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
8271412: ProblemList javax/sound/midi/Sequencer/Looping.java - Commit messages: - 8271413: ProblemList 2 locale tests on macOS-x64 - 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java Changes: https://git.openjdk.java.net/jdk17/pull/291/files Webrev: https://webrevs.open

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Chris Plummer
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed jdi, jvmti, and dcmd relate

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Kevin Rushforth
On Wed, 28 Jul 2021 17:08:01 GMT, Emmanuel Bourg wrote: >> I'm happy to sponsor this change, but could you please update the copyright >> year where necessary, e.g. in >> src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java: >> `Copyright (c) 2003, 2018, Oracle...` -> `Copyright (c) 200

Re: RFR: 8271396: Spelling errors [v2]

2021-07-28 Thread Iris Clark
On Wed, 28 Jul 2021 17:12:04 GMT, Emmanuel Bourg wrote: >> This PR fixes the following spelling errors: >> >> choosen -> chosen >> commad -> command >> hiearchy -> hierarchy >> leagacy -> legacy >> minium -> minimum >> subsytem -> subsystem >> unamed -> unnamed > > Emmanuel Bourg

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Prasanta Sadhukhan
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Thanks for awt/swing correc

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Emmanuel Bourg
On Wed, 28 Jul 2021 17:20:37 GMT, Kevin Rushforth wrote: >> @FrauBoes thank you, the PR has been updated to modify the copyright year > > @ebourg for future PRs please do not force push after the PR is out for > review. Just push incremental commits normally. The Skara tooling will squash > the

Re: RFR: 8271396: Spelling errors [v2]

2021-07-28 Thread Emmanuel Bourg
> This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Emmanuel Bourg has updated the pull request with a new target base due to a merge or

Re: jpackage MacOS Notarization

2021-07-28 Thread Andy Herrick
Not really enough info given here to act on.  Exactly what java version/build are you using?   As Kevin suggested it best to try JDK17 EA first, but I can notarize simple test app with JDK16 , staple the notarization, and then download it and run it on other machines without the quarantine hack

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Emmanuel Bourg
On Wed, 28 Jul 2021 16:26:49 GMT, Julia Boes wrote: >> This PR fixes the following spelling errors: >> >> choosen -> chosen >> commad -> command >> hiearchy -> hierarchy >> leagacy -> legacy >> minium -> minimum >> subsytem -> subsystem >> unamed -> unnamed > > I'm happy to sponso

Re: RFR: 8266054: VectorAPI rotate operation optimization [v13]

2021-07-28 Thread Sandhya Viswanathan
On Wed, 28 Jul 2021 04:48:35 GMT, Vladimir Kozlov wrote: >> Looks good to me. > > @sviswa7 and @jatin-bhateja jatin-bhateja > The push caused https://bugs.openjdk.java.net/browse/JDK-8271366 > I am strongly suggest in a future to ask an Oracle's engineer to test Intel's > changes before pushing.

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Julia Boes
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed I'm happy to sponsor this c

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Iris Clark
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Marked as reviewed by iris

Re: jpackage MacOS Notarization

2021-07-28 Thread Kevin Rushforth
Full support for notarization in jpackage was added in JDK 17. Can you try an early access build of JDK 17 [1] and see if that works for you? -- Kevin [1] https://jdk.java.net/17 On 7/28/2021 8:27 AM, Daniel Peintner wrote: All, I am trying to notarize an app (built with jpackage) for MacOS.

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Emmanuel Bourg
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed . . Thank you! The PR ha

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Yi Yang
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Hi, I've filed https://bugs

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Chris Hegarty
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Trivially, looks ok to me.

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Thomas Schatzl
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Lgtm. - Marke

RFR: 8271396: Spelling errors

2021-07-28 Thread Emmanuel Bourg
This PR fixes the following spelling errors: choosen -> chosen commad -> command hiearchy -> hierarchy leagacy -> legacy minium -> minimum subsytem -> subsystem unamed -> unnamed - Commit messages: - 8271396: Fix spelling errors Changes: https://git.openjdk.java.net/

jpackage MacOS Notarization

2021-07-28 Thread Daniel Peintner
All, I am trying to notarize an app (built with jpackage) for MacOS. jpackage at first *seems* to properly sign all resources with the available --mac-sign options et cetera. Having said that, there are still remaining issues 1. The app cannot be properly installed (without hacks like xattr -

Re: RFR: 8266054: VectorAPI rotate operation optimization [v13]

2021-07-28 Thread Paul Sandoz
On Tue, 27 Jul 2021 18:31:20 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 19 commits: >> >> - 8266054: Re-designing benchmark to remove noise. >> - Merge branch 'master' of ht

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-07-28 Thread Nick Gasson
On Wed, 28 Jul 2021 09:29:25 GMT, Wu Yan wrote: > > We are testing on HiSilicon TSV110, maybe we can enable this optimization by > default on the verified platforms. We don't really want to have different implementations for each microarchitecture, that would be a testing nightmare. The exi

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-07-28 Thread Wu Yan
On Wed, 28 Jul 2021 08:51:38 GMT, Andrew Haley wrote: > The trouble is, what does "worse" mean? I'm looking at SDEN-1982442, Neoverse > N2 errata, 2001293, and I see that LDP has to be slowed down on streaming > workloads, which will affect this. (That's just an example: I'm making the > point

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-07-28 Thread Andrew Haley
On Wed, 28 Jul 2021 08:25:08 GMT, Nick Gasson wrote: > I don't think we want to keep two copies of the compareTo intrinsic. If there > are no cases where the LDP version is worse than the original version then we > should just delete the old one and replace it with this. I agree. The trouble i

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-07-28 Thread Nick Gasson
On Thu, 15 Jul 2021 03:30:46 GMT, Wang Huang wrote: >> Dear all, >> Can you do me a favor to review this patch. This patch use `ldp` to >> implement String.compareTo. >> >> * We add a JMH test case >> * Here is the result of this test case >> >> Benchmark |(

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v2]

2021-07-28 Thread Wu Yan
On Mon, 12 Jul 2021 15:36:29 GMT, Andrew Haley wrote: >> Wang Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> draft of refactor > > And with longer strings, M1 and ThunderX2: > > > Benchmark

Integrated: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-28 Thread Vladimir Kozlov
On Wed, 28 Jul 2021 05:35:59 GMT, Vladimir Kozlov wrote: > Backout the following changes due to vector tests failures in tier 2 and > later: > [JDK-8266054](https://bugs.openjdk.java.net/browse/JDK-8266054) VectorAPI > rotate operation optimization > > Changes also caused copyright header va

Re: RFR: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-28 Thread Vladimir Kozlov
On Wed, 28 Jul 2021 06:24:20 GMT, Jatin Bhateja wrote: > * Thanks for reporting it, should it be ok to move those tests to > ProblemList.txt and let me fix this as a follow up issue instead of a revert ? @jatin-bhateja We did not test original changes in our testing infra. There could be other