On Thu, 5 Aug 2021 14:28:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial fix which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271208?
>
> Ran `make docs-image` locally and generated the new javadocs and the change
> looks fine.
This pull reques
On Thu, 5 Aug 2021 14:28:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial fix which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271208?
>
> Ran `make docs-image` locally and generated the new javadocs and the change
> looks fine.
Thank you for th
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 440 commits:
- Merge
- 8271293: Monitor class should use ThreadBlockInVMPreprocess
Reviewed-by: dholmes, dcubed
- 8270116: Exp
On Thu, 5 Aug 2021 23:49:48 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: 14692d5e
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/14692d5ed0652b867fcf28baafa498a9441683ac
Stats: 307 li
This reimplements core reflection with method handles.
For `Constructor::newInstance` and `Method::invoke`, the new implementation
uses `MethodHandle`. For `Field` accessor, the new implementation uses
`VarHandle`.For the first few invocations of one of these reflective
methods on a specif
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8270872: Final nroff manpage update for JDK 17
- 8271588: JFR Recorder Thread crashed with SIGSEGV in write_klass
- 8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with
ZGC
The webrevs contain the ad
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
This pull request has now been integrated.
Changeset: dfacda48
Author:Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk17/commit/d
On Thu, 5 Aug 2021 21:40:40 GMT, Naoto Sato wrote:
>> According to the comments in the makefile
>> (`closed/make/UpdateOpenManPages.gmk`) the copyright line is taken from the
>> original Markdown file, so if the year is wrong there, it will be wrong in
>> the generated nroff file.
>>
>> I thi
On Thu, 5 Aug 2021 21:36:58 GMT, Jonathan Gibbons wrote:
>> src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
>>
>>> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> This seems not correct?
>
> According to the comments in the makefile
> (`closed/mak
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:57:59 GMT, Naoto Sato wrote:
>> Please review a semi-automatic update of the nroff man pages from the
>> upstream files.
>
> src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
>
>> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
>> reserved.
>
> Th
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by mr (Lead).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
> reserved.
This seem
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
Please review a semi-automatic update of the nroff man pages from the upstream
files.
-
Commit messages:
- JDK-8270872: Final nroff manpage update for JDK 17
Changes: https://git.openjdk.java.net/jdk17/pull/303/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=303&rang
On Thu, 5 Aug 2021 18:57:42 GMT, Brian Burkhalter wrote:
>> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to
>> `java.lang.Math` and `java.lang.StrictMath`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to
> `java.lang.Math` and `java.lang.StrictMath`.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains five commits:
- 8271225: Verbiage update after
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
https://openjdk.java.net/jeps/416
Summary: Reimplement java.lang.reflect.Method, Constructor, and Field
on top of java.lang.invoke method handles. Making method handles the
underlying mechanism for reflection will reduce the maintenance and
development cost of both the java.lang.reflect a
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
> 8271868: Warn user when using mac-sign option with unsigned app-image.
Andy Herrick has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
-
Changes:
- all: http
On Thu, 5 Aug 2021 14:28:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial fix which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271208?
>
> Ran `make docs-image` locally and generated the new javadocs and the change
> looks fine.
Marked as review
On Thu, 5 Aug 2021 11:19:17 GMT, Matthias Baesken wrote:
>>> What do you think about accepting, when setting -1/unlimited, a high limit
>>> number like 20.000+ as well (and and a comment that on some setups
>>> unlimited means just "high number" but not unlimited?
>>
>> This seems most reasona
On Wed, 4 Aug 2021 07:46:48 GMT, Claes Redestad wrote:
> This adds Integer.toString microbenchmarks, roughly similar to the
> Long.toString microbenchmarks (toStringSmall should use an equivalent data
> set). This is useful for comparison purposes and completeness.
>
> Also tuned existing benc
On Wed, 4 Aug 2021 08:04:48 GMT, Aleksey Shipilev wrote:
> Looks fine.
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/4988
On Thu, 5 Aug 2021 14:28:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial fix which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271208?
>
> Ran `make docs-image` locally and generated the new javadocs and the change
> looks fine.
Marked as review
Can I please get a review of this trivial fix which fixes the typo noted in
https://bugs.openjdk.java.net/browse/JDK-8271208?
Ran `make docs-image` locally and generated the new javadocs and the change
looks fine.
-
Commit messages:
- 8271208: Typo in ModuleDescriptor.read javadoc
On Thu, 5 Aug 2021 13:13:27 GMT, Alan Bateman wrote:
>> Probably others too, if we care about inheriting read handles to child.
>>
>> The background is that I am playing with a new test which checks that the VM
>> has no open inheritable file descriptors. It is supposed to replace some
>> spec
On Wed, 4 Aug 2021 17:04:38 GMT, Thomas Stuefe wrote:
>> src/java.base/unix/native/libjimage/osSupport_unix.cpp line 41:
>>
>>> 39: */
>>> 40: jint osSupport::openReadOnly(const char *path) {
>>> 41: return ::open(path, O_CLOEXEC);
>>
>> This is okay but I think it would be useful to know
On Wed, 4 Aug 2021 13:35:59 GMT, Alan Bateman wrote:
>> We should not leak the handle to the jimage file (lib/modules) to childs.
>>
>> JDK-8194734 did solve this for windows. We should use FD_CLOEXEC on Posix as
>> well.
>>
>> Note that this only poses a problem when a child process is spawne
We should not leak the handle to the jimage file (lib/modules) to childs.
JDK-8194734 did solve this for windows. We should use FD_CLOEXEC on Posix as
well.
Note that this only poses a problem when a child process is spawned off not via
`Runtime.exec` but via another route since the spawnhelper
On Wed, 4 Aug 2021 12:22:24 GMT, Thomas Stuefe wrote:
> We should not leak the handle to the jimage file (lib/modules) to childs.
>
> JDK-8194734 did solve this for windows. We should use FD_CLOEXEC on Posix as
> well.
>
> Note that this only poses a problem when a child process is spawned off
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Mon, 2 Aug 2021 11:42:33 GMT, Severin Gehwolf wrote:
> > What do you think about accepting, when setting -1/unlimited, a high limit
> > number like 20.000+ as well (and and a comment that on some setups
> > unlimited means just "high number" but not unlimited?
>
> This seems most reasonable
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
39 matches
Mail list logo
