Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-06 Thread Markus KARG
On Sun, 1 Aug 2021 22:01:33 GMT, Markus KARG wrote: >> This PR-*draft* is **work in progress** and an invitation to discuss a >> possible solution for issue >> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not >> yet* intended for a final review. >> >> As proposed i

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v2]

2021-08-06 Thread Mandy Chung
> This reimplements core reflection with method handles. > > For `Constructor::newInstance` and `Method::invoke`, the new implementation > uses `MethodHandle`. For `Field` accessor, the new implementation uses > `VarHandle`.For the first few invocations of one of these reflective > methods

Re: RFR: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

2021-08-06 Thread Iris Clark
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. The root cause of this problem is > that the currency for the country code `XK` is undefined because the country > code is user-defined in the ISO 3166 standard. However, it is commonly used > to r

Re: RFR: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

2021-08-06 Thread Joe Wang
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. The root cause of this problem is > that the currency for the country code `XK` is undefined because the country > code is user-defined in the ISO 3166 standard. However, it is commonly used > to r

RFR: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

2021-08-06 Thread Naoto Sato
Please review the fix to the subject issue. The root cause of this problem is that the currency for the country code `XK` is undefined because the country code is user-defined in the ISO 3166 standard. However, it is commonly used to represent the region `Kosovo`, which CLDR supports and subsequ

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 - Commit messages: - 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 Changes: https://git.openjdk.java.net/jdk/pull/5032/files Webrev: https://w

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
On Fri, 6 Aug 2021 13:32:00 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 This pull request has now been integrated. Changeset: f4cf2f7c Author:Daniel D. Daugherty URL: https://git.openjdk.java.ne

Re: Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Alan Bateman
On Fri, 6 Aug 2021 13:32:00 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5032

Re: Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
On Fri, 6 Aug 2021 13:34:37 GMT, Alan Bateman wrote: >> A trivial fix to ProblemList >> java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 > > Marked as reviewed by alanb (Reviewer). @AlanBateman - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/

Re: RFR: JDK-8271858: Handle to jimage file inherited into child processes (posix)

2021-08-06 Thread Alan Bateman
On Thu, 5 Aug 2021 14:06:17 GMT, Thomas Stuefe wrote: >> On Unix systems, the JDK has always relied on the Runtime.exec >> implementation to close the file descriptors. On Windows the inheritance has >> to be disabled in the parent. So if the gtest launcher is forking directly >> then we may h

Integrated: 8271868: Warn user when using mac-sign option with unsigned app-image.

2021-08-06 Thread Andy Herrick
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote: > 8271868: Warn user when using mac-sign option with unsigned app-image. This pull request has now been integrated. Changeset: 0aca4f72 Author:Andy Herrick URL: https://git.openjdk.java.net/jdk/commit/0aca4f72ce48bc75f2c466d1cba4a

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v8]

2021-08-06 Thread Matthias Baesken
On Fri, 6 Aug 2021 08:29:50 GMT, Severin Gehwolf wrote: > This looks good to me now and passes tests on my cgroup v1 and cgroup v2 > setups. Thanks for the review and approval . Best regards, Matthias - PR: https://git.openjdk.java.net/jdk/pull/4518

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v6]

2021-08-06 Thread Wang Huang
> Dear all, > Can you do me a favor to review this patch. This patch use `ldp` to > implement String.compareTo. > > * We add a JMH test case > * Here is the result of this test case > > Benchmark|(size)| Mode| Cnt|Score | Error |Units > ---

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v8]

2021-08-06 Thread Severin Gehwolf
On Thu, 5 Aug 2021 11:21:59 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux dis