Re: RFR: 8272297: FileInputStream should override transferTo() for better performance [v2]

2021-08-12 Thread Brian Burkhalter
On Thu, 12 Aug 2021 21:07:53 GMT, Brian Burkhalter wrote: >> Please consider this request to add an override >> `java.io.FileInputStream.transferTo(OutputStream)` with improved performance >> if the parameter is a `FileOutputStream`. > > Brian Burkhalter has updated the pull request incremental

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

2021-08-12 Thread Joe Wang
On Thu, 12 Aug 2021 19:27:42 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review the fix for JDK-8263940 to address an issues when the default >> file system provider is packaged as JAR file on class path. >> >> The patch also addresses the `@bug` line for JDK-8271194 >> >> Mach5 Tier1

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

2021-08-12 Thread Iris Clark
On Thu, 12 Aug 2021 19:27:42 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review the fix for JDK-8263940 to address an issues when the default >> file system provider is packaged as JAR file on class path. >> >> The patch also addresses the `@bug` line for JDK-8271194 >> >> Mach5 Tier1

Re: RFR: 8272297: FileInputStream should override transferTo() for better performance [v2]

2021-08-12 Thread Brian Burkhalter
> Please consider this request to add an override > `java.io.FileInputStream.transferTo(OutputStream)` with improved performance > if the parameter is a `FileOutputStream`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8272297

Re: RFR: 8260265: UTF-8 by Default [v7]

2021-08-12 Thread Naoto Sato
> This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of > the changes is `Charset.defaultCharset()` returning `UTF-8` and > `file.encoding` system property being added in the spec, but another notable > modification is in `java.io.PrintStream` where it continues to use the

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

2021-08-12 Thread Lance Andersen
On Thu, 12 Aug 2021 18:55:08 GMT, Naoto Sato wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use toList() > > test/jdk/java/nio/file/spi/SetDefaultProvider.java line 107: > >> 105: .map(path

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

2021-08-12 Thread Brian Burkhalter
On Thu, 12 Aug 2021 19:24:39 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review the fix for JDK-8263940 to address an issues when the default >> file system provider is packaged as JAR file on class path. >> >> The patch also addresses the `@bug` line for JDK-8271194 >> >> Mach5 Tier1

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

2021-08-12 Thread Lance Andersen
> Hi all, > > Please review the fix for JDK-8263940 to address an issues when the default > file system provider is packaged as JAR file on class path. > > The patch also addresses the `@bug` line for JDK-8271194 > > Mach5 Tier1 - Tier3 have run without issues > > Best, > Lance Lance Andersen

Re: RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

2021-08-12 Thread Naoto Sato
On Thu, 12 Aug 2021 17:43:48 GMT, Lance Andersen wrote: > Hi all, > > Please review the fix for JDK-8263940 to address an issues when the default > file system provider is packaged as JAR file on class path. > > The patch also addresses the `@bug` line for JDK-8271194 > > Mach5 Tier1 - Tier3

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-12 Thread Markus KARG
On Thu, 12 Aug 2021 08:40:34 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Draft: Eliminated duplicate code using lambda expressions >> - Draft: Use blocking mode also for target channel > >>

RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

2021-08-12 Thread Lance Andersen
Hi all, Please review the fix for JDK-8263940 to address an issues when the default file system provider is packaged as JAR file on class path. The patch also addresses the `@bug` line for JDK-8271194 Mach5 Tier1 - Tier3 have run without issues Best, Lance - Commit messages: - F

Re: RFR: 8272297: FileInputStream should override transferTo() for better performance

2021-08-12 Thread Brian Burkhalter
On Thu, 12 Aug 2021 11:30:16 GMT, Alan Bateman wrote: >> Please consider this request to add an override >> `java.io.FileInputStream.transferTo(OutputStream)` with improved performance >> if the parameter is a `FileOutputStream`. > > src/java.base/share/classes/java/io/FileInputStream.java line

Re: RFR: 8272297: FileInputStream should override transferTo() for better performance

2021-08-12 Thread Alan Bateman
On Thu, 12 Aug 2021 01:16:04 GMT, Brian Burkhalter wrote: > Please consider this request to add an override > `java.io.FileInputStream.transferTo(OutputStream)` with improved performance > if the parameter is a `FileOutputStream`. Changes requested by alanb (Reviewer). src/java.base/share/cla

Integrated: 8267844: Replace Integer/Long.valueOf() with Integer/Long.parse*() where applicable

2021-08-12 Thread Сергей Цыпанов
On Tue, 10 Aug 2021 13:16:42 GMT, Сергей Цыпанов wrote: > The code in `Integer.decode()` and `Long.decode()` might allocate two > instances of Integer/Long for the negative values less than -127: > > Integer result; > > result = Integer.valueOf(nm.substring(index), radix); > result = negative

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-12 Thread Alan Bateman
On Sun, 1 Aug 2021 22:01:33 GMT, Markus KARG wrote: >> This PR-*draft* is **work in progress** and an invitation to discuss a >> possible solution for issue >> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not >> yet* intended for a final review. >> >> As proposed i

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-12 Thread Brian Burkhalter
On Wed, 11 Aug 2021 11:27:53 GMT, Alan Bateman wrote: >>> I think I fixed all requested changes. Anymore comments on this PR? >> >> I hope to get to this soon. > >> I think I fixed all requested changes. Anymore comments on this PR? > > I've looked through the latest revision. Is there any way

Integrated: 8271732: Regression in StringBuilder.charAt bounds checking

2021-08-12 Thread Claes Redestad
On Wed, 11 Aug 2021 14:26:32 GMT, Claes Redestad wrote: > In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to > avoid potentially getting two bounds checks in the UTF-16 case. Problem is > this optimization cause a regression since `StringUTF16.charAt(..)` checks > `inde