Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-18 Thread Simon Nash
On 19/08/2021 07:40, Alan Bateman wrote: Yes, if there is code that really wants to use the native encoding and run of wide range of JDK releases without the using COMPAT then it can read the value of native.encoding and use Charset.defaultCharset if the property is not set. -Alan. Thanks for

Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-18 Thread Alan Bateman
On 18/08/2021 22:44, Naoto Sato wrote: On 8/18/21 2:03 PM, Simon Nash wrote: I am the developer of a fairly large application that uses file I/O extensively. In most cases, the charset should be UTF-8 and I have used an explicit charset parameter on all method invocations where this applies. I

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-18 Thread Markus KARG
On Sun, 15 Aug 2021 13:37:23 GMT, Markus KARG wrote: > I think the best course of action is to reduce the scope of this PR to the > file channel cases. There is no reason why future PRs can't build on this and > add implementations for other channel types. I have split up this PR so that only

Fwd: [(Much) faster java.util.LinkedList]

2021-08-18 Thread -
-- Forwarded message - From: - Date: Wed, Aug 18, 2021 at 11:34 PM Subject: Re: [(Much) faster java.util.LinkedList] To: Rodion Efremov The main drawback is that this linked list now runs at O(sqrt(N)) than O(1) time complexity for single-element head/tail modifications, which i

[(Much) faster java.util.LinkedList]

2021-08-18 Thread Rodion Efremov
Hello, I have implemented a heuristic, indexed doubly-linked list data structure [1][2] implementing java.util.List and java.util.Deque interfaces that has superior performance compared to java.util.LinkedList and java.util.ArrayList. I would like to propose it into the upcoming versions of OpenJ

Re: RFR: 8264322: Generate CDS archive when creating custom JDK image

2021-08-18 Thread Mandy Chung
On Wed, 18 Aug 2021 21:21:06 GMT, Calvin Cheung wrote: > Please review this change for adding a `jlink` command line option > `--generate-cds-archive` for generating CDS archives as a post processing > step during the creation of a custom JDK image. > > Details can be found in the correspondin

Re: RFR: 8272616: Strange code in java.text.DecimalFormat#applyPattern

2021-08-18 Thread Iris Clark
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov wrote: > remove redundant if Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5171

Re: RFR: 8272616: Strange code in java.text.DecimalFormat#applyPattern

2021-08-18 Thread Naoto Sato
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov wrote: > remove redundant if Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5171

Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-18 Thread Naoto Sato
On 8/18/21 2:03 PM, Simon Nash wrote: I am the developer of a fairly large application that uses file I/O extensively. In most cases, the charset should be UTF-8 and I have used an explicit charset parameter on all method invocations where this applies. In some cases, the charset needs to be th

RFR: 8264322: Generate CDS archive when creating custom JDK image

2021-08-18 Thread Calvin Cheung
Please review this change for adding a `jlink` command line option `--generate-cds-archive` for generating CDS archives as a post processing step during the creation of a custom JDK image. Details can be found in the corresponding CSR [JDK-8269178](https://bugs.openjdk.java.net/browse/JDK-82691

Re: RFR: 8272616: Strange code in java.text.DecimalFormat#applyPattern

2021-08-18 Thread Brian Burkhalter
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov wrote: > remove redundant if Looks fine. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5171

RFR: 8272616: Strange code in java.text.DecimalFormat#applyPattern

2021-08-18 Thread Andrey Turbanov
remove redundant if - Commit messages: - 8272616: Strange code in java.text.DecimalFormat#applyPattern Changes: https://git.openjdk.java.net/jdk/pull/5171/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5171&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-827

Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-18 Thread Simon Nash
On 18/08/2021 20:49, Naoto Sato wrote: Hi Simon, Please post your comments at core-libs-dev mailing list, where the discussion should take place. Naoto My apologies that I am late into the discussion of this JEP. I am the developer of a fairly large application that uses file I/O extensivel

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-18 Thread Brent Christian
On Wed, 18 Aug 2021 18:35:53 GMT, Ian Graves wrote: >> 8271302: Regex Test Refresh > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Couple of fixes Marked as reviewed by bchristi (Reviewer). - PR: https://git.op

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-18 Thread Ian Graves
On Fri, 13 Aug 2021 20:17:56 GMT, Brent Christian wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Couple of fixes > > test/jdk/java/util/regex/RegExTest.java line 3952: > >> 3950: >> 3951: m = Pattern.c

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-18 Thread Ian Graves
> 8271302: Regex Test Refresh Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Couple of fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/5092/files - new: https://git.openjdk.java.net/jdk/pull/5092/files/1

Re: RFR: 8271302: Regex Test Refresh

2021-08-18 Thread Ian Graves
On Fri, 13 Aug 2021 20:16:22 GMT, Brent Christian wrote: >> 8271302: Regex Test Refresh > > test/jdk/java/util/regex/RegExTest.java line 2362: > >> 2360: >> 2361: { "test\ud834\uddc0", "test\ud834\uddc0", >>"m", true }, >> 2362: //{ "test\ud834\uddbc\ud

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Joe Darcy
On 8/18/2021 6:20 AM, Roger Riggs wrote: On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) 34 Minutes

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v4]

2021-08-18 Thread Harold Seigel
On Wed, 18 Aug 2021 13:04:46 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Integrated: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon

2021-08-18 Thread Harold Seigel
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v4]

2021-08-18 Thread Severin Gehwolf
On Wed, 18 Aug 2021 13:04:46 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Roger Riggs
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) 34 Minutes from proposed to integrated! Its hard

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v4]

2021-08-18 Thread Harold Seigel
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli:ce" in a /proc/self/cgroup file will now result in a >

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v3]

2021-08-18 Thread Harold Seigel
On Wed, 18 Aug 2021 12:25:45 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v3]

2021-08-18 Thread Severin Gehwolf
On Wed, 18 Aug 2021 12:25:45 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon [v2]

2021-08-18 Thread Severin Gehwolf
On Tue, 17 Aug 2021 17:46:29 GMT, Severin Gehwolf wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add test case, comments, and other small changes > > test/jdk/jdk/internal/platform/cgroup/TestCgroupSubsystemFacto

Re: JPackage and ask for microphone permissions broken on OSX...

2021-08-18 Thread Andy Herrick
OK - I have reproduced this problem, filed an issue, and found the fix. You can see the issue in https://bugs.openjdk.java.net/browse/JDK-8272639. Basically another key is needed in application plist to cause application to ask for microphone access. It is far to late to get any fix into JDK1

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon [v2]

2021-08-18 Thread Harold Seigel
On Tue, 17 Aug 2021 17:39:49 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon [v3]

2021-08-18 Thread Harold Seigel
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli:ce" in a /proc/self/cgroup file will now result in a >

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Thanks for reviewing, Daniel and Alan!

Integrated: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) This pull request has now been integrated. Chan

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Alan Bateman
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Marked as reviewed by alanb (Reviewer). ---

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Daniel Fuchs
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Marked as reviewed by dfuchs (Reviewer). --

RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) - Commit messages: - Avoid C-style array declarations in java packages Changes: https://git.openjdk