Re: RFR: 8273329: Remove redundant null check from String.getBytes(String charsetName)

2021-09-04 Thread Сергей Цыпанов
On Sat, 4 Sep 2021 01:43:57 GMT, Naoto Sato wrote: >> Current implementation looks like this: >> >> public byte[] getBytes(String charsetName) >> throws UnsupportedEncodingException { >> if (charsetName == null) throw new NullPointerException(); >> return encode(lookupCharset(cha

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-04 Thread Andrey Turbanov
On Sat, 4 Sep 2021 15:25:59 GMT, Jaikiran Pai wrote: > The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Propertie

RFR: 8231640: (prop) Canonical property storage

2021-09-04 Thread Jaikiran Pai
The commit in this PR implements the proposal for enhancement that was discussed in the core-libs-dev mailing list recently[1], for https://bugs.openjdk.java.net/browse/JDK-8231640 At a high level - the `store()` APIs in `Properties` have been modified to now look for the `SOURCE_DATE_EPOCH` en

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-04 Thread Jaikiran Pai
On Sat, 4 Sep 2021 15:25:59 GMT, Jaikiran Pai wrote: > The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Propertie

Re: Proposal: JDK-8231640 - (prop) Canonical property storage

2021-09-04 Thread Jaikiran Pai
On 29/08/21 6:41 pm, Jaikiran Pai wrote: On 28/08/21 8:46 pm, Alan Bateman wrote: On 28/08/2021 05:45, Jaikiran Pai wrote: I hadn't considered the system property approach to switch to old behaviour in my proposals, so this is a very good input and I personally think the most logical propos

Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array

2021-09-04 Thread liach
On Sat, 4 Sep 2021 11:59:58 GMT, q2q-2q2 wrote: > Shortcut String equality checks by checking equality of the value array src/java.base/share/classes/java/lang/String.java line 1964: > 1962: public boolean equalsIgnoreCase(String anotherString) { > 1963: if (anotherString != null)

RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array

2021-09-04 Thread q2q-2q2
Shortcut String equality checks by checking equality of the value array - Commit messages: - JDK-8272192 Changes: https://git.openjdk.java.net/jdk/pull/5370/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5370&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-04 Thread Lance Andersen
On Sep 4, 2021, at 2:53 AM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: On Sat, 4 Sep 2021 01:53:35 GMT, wxiang mailto:github.com+53162078+shiyu...@openjdk.org>> wrote: I will first create the patch to remove JAR index support from the URLClassLoader implementation, the `jar i` opt

Re: RFR: JDK-8273246 Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode

2021-09-04 Thread Mark Sheppard
On Sat, 4 Sep 2021 06:47:43 GMT, Alan Bateman wrote: >> A number of nio DatagramChannel tests are intermittently failing on >> macosx-aarch64. >> In some instances this is a receive call blocking indefinitely waiting on >> data which has >> already been sent, and should be available immediately

Re: RFR: 8255878: FilterInputStream is missing implementations of Java 9 InputStream methods [v2]

2021-09-04 Thread Alan Bateman
On Sat, 4 Sep 2021 00:39:19 GMT, Daniel Fuchs wrote: > This may potentially break any existing subclasses that assume that they only > need to override the three > `int read()` and `int read(byte[], int, it)` and `int skip(int)` methods - > because overriding only these three methods will now n