RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time

2021-09-12 Thread Jaikiran Pai
The commit here is a potential fix for the issue noted in https://bugs.openjdk.java.net/browse/JDK-8258117. The change here repurposes an existing internal interface `ModuleInfoEntry` to keep track of the last modified timestamp of a `module-info.class` descriptor. This commit uses the

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v2]

2021-09-12 Thread Joe Darcy
On Thu, 9 Sep 2021 16:30:29 GMT, Ian Graves wrote: >> Relaxing some assertion bounds to allow for small error values that still >> show improvement over previous summation method. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8231640: (prop) Canonical property storage [v11]

2021-09-12 Thread Jaikiran Pai
On Sun, 12 Sep 2021 14:03:42 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-12 Thread Alan Bateman
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. This will need discussion as to whether the JDK should put in retry

Re: RFR: 8231640: (prop) Canonical property storage [v10]

2021-09-12 Thread Jaikiran Pai
Hello Stuart, On 10/09/21 11:12 pm, Stuart Marks wrote: src/java.base/share/classes/java/util/Properties.java line 832: 830: * {@code #} character, the current date and time (formatted using the 831: * {@code EEE MMM dd HH:mm:ss zzz } {@link DateTimeFormatter date format}),

Re: RFR: 8231640: (prop) Canonical property storage [v11]

2021-09-12 Thread Jaikiran Pai
> The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Properties` have been modified to > now look for the

Integrated: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming

2021-09-12 Thread Andrey Turbanov
On Mon, 6 Sep 2021 08:08:33 GMT, Andrey Turbanov wrote: > Update code checks both non-null and instance of a class in java.naming > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > For example: > The following

Re: RFR: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2

2021-09-12 Thread David Holmes
On 11/09/2021 5:24 am, kabutz wrote: On Fri, 10 Sep 2021 14:08:05 GMT, Claes Redestad wrote: This looks good. @cl4es might want to confirm that change was not intentional. Completely unintentional, and perplexing since it's not a simple copy-paste error.. The thread priorities in Java