Re: RFR: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU [v2]

2021-09-30 Thread Aleksey Shipilev
On Fri, 1 Oct 2021 05:10:17 GMT, David Holmes wrote: >> A regression introduced in Java 17 will give the default FJ pool a >> parallelism of zero in a uniprocessor environment. The fix restores this to >> a value of 1. See bug report for details. >> >> Testing: >> - new regression test >> -

Re: RFR: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU [v2]

2021-09-30 Thread David Holmes
> A regression introduced in Java 17 will give the default FJ pool a > parallelism of zero in a uniprocessor environment. The fix restores this to a > value of 1. See bug report for details. > > Testing: > - new regression test > - tiers 1-3 > > Thanks, > David David Holmes has updated the p

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-09-30 Thread Ichiroh Takiguchi
On Thu, 30 Sep 2021 21:45:15 GMT, Naoto Sato wrote: >> Screenshot >> ![javac-screenshot](https://user-images.githubusercontent.com/33543753/135429041-0ed22b36-0b1e-4626-92ca-8b58acf8872d.png) >> >> javac does not use PrintStream for standard out/err, it uses PrintWriter. >> I put some codes on

RFR: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU

2021-09-30 Thread David Holmes
A regression introduced in Java 17 will give the default FJ pool a parallelism of zero in a uniprocessor environment. The fix restores this to a value of 1. See bug report for details. Testing: - new regression test - tiers 1-3 Thanks, David - Commit messages: - 8274349: ForkJ

Re: RFR: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml

2021-09-30 Thread Naoto Sato
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

Re: RFR: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml

2021-09-30 Thread Iris Clark
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-09-30 Thread Naoto Sato
On Thu, 30 Sep 2021 10:10:31 GMT, Ichiroh Takiguchi wrote: > * Using native.encoding system property. But > test/langtools/tools/javac/diags/CheckResourceKeys.java was failed. What was the cause of the failure? > * Use java.io.Console, like Console cons = System.console() and > cons.charset(

Re: RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test

2021-09-30 Thread Joe Wang
On Thu, 30 Sep 2021 18:32:17 GMT, Alex Kasko wrote: > I was working on backporting JDK-8268457 and found minor problems with the > test introduced there: > > 1. `compareWith*` helper methods are used without `Assert.assertTrue()` > wrapping, so they are effectively ignored > > 2. `this.getCla

Re: RFR: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml

2021-09-30 Thread Joe Wang
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v12]

2021-09-30 Thread Lance Andersen
On Tue, 28 Sep 2021 03:10:33 GMT, Lin Zang wrote: > Dear All, This PR has been pending there for quite a long time. I am > wondering maybe this PR is not so interesting? I would like to leave this PR > open for a while more, and if no new update, I would let it close > automatically by timeout

RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test

2021-09-30 Thread Alex Kasko
I was working on backporting JDK-8268457 and found minor problems with the test introduced there: 1. `compareWith*` helper methods are used without `Assert.assertTrue()` wrapping, so they are effectively ignored 2. `this.getClass().getResourceAsStream()` is used to load test input data, it act

Re: RFR: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently

2021-09-30 Thread Masanori Yano
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote: > Could you please review the 8250678 bug fixes? > > The `parse` method of ModuleDescriptor.Version class behaves incorrectly when > the input string contains consecutive delimiters. > > The `parse` method treats strings as three sections,

Re: RFR: 8269559: AArch64: Implement string_compare intrinsic in SVE [v2]

2021-09-30 Thread Andrew Haley
On Mon, 23 Aug 2021 21:48:01 GMT, TatWai Chong wrote: >> This patch implements string_compare intrinsic in SVE. >> It supports all LL, LU, UL and UU comparisons. >> >> As we haven't found an existing benchmark to measure performance impact, >> we created a benchmark derived from the test [1] fo

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-09-30 Thread Ichiroh Takiguchi
On Thu, 30 Sep 2021 09:36:34 GMT, Ichiroh Takiguchi wrote: > JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. S

RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-09-30 Thread Ichiroh Takiguchi
JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. After JDK18-b13, javac and some other langtool command's usage were garbled on Japanese Windows. These commands use PrintWriter instead of standard out/err with PrintStream. - Commit messages: - Langtools command's usage were grabl

Integrated: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

2021-09-30 Thread Severin Gehwolf
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf wrote: > Please review this test fix to work around a podman issue[1]. `podman` > expects for the "unlimited" option of `--pids-limit` to be `0` whereas > `docker` wants `-1`. See the JBS bug for details. Thoughts? > > Testing: hotspot/jdk cont