Re: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

2021-10-29 Thread Mandy Chung
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > At the time Java supported applets and webstart, a special mechanism for > launching various applications in one JVM was used to reduce memory usage and > each application was isolated from each other. > > This isolation was implemented

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
On Fri, 29 Oct 2021 16:14:57 GMT, Michael McMahon wrote: > How likely is it that existing code is using ObjectInputStream::getFields and > is already handling class not found by checking for null return from the > returned GetField? Very unlikely, a field value may be null for because it reall

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v10]

2021-10-29 Thread Daniel Fuchs
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes

Integrated: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-29 Thread Brian Burkhalter
On Tue, 26 Oct 2021 19:00:44 GMT, Brian Burkhalter wrote: > Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. This pull request has now been integrated. Changeset: 13265f99 Author:Brian Burkhalter URL:

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v10]

2021-10-29 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: > -

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Naoto Sato
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v9]

2021-10-29 Thread Aleksei Efimov
On Wed, 27 Oct 2021 16:23:29 GMT, Michael McMahon wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add @ throws NPE to hosts file resolver javadoc > > src/java.base/share/classes/java/net/InetAddress.java line 841

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Michael McMahon
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8275766: (tz) Update Timezone Data to 2021e

2021-10-29 Thread Erik Joelsson
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote: > Please review the integration of tzdata2021e (including tzdata2021d) to the > JDK. > The fix has passed all relevant JTREG regression tests and JCK tests. > > 8275754: (tz) Update Timezone Data to 2021d > 8275849: TestZoneInfo310.java fai

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v7]

2021-10-29 Thread iaroslavski
> Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor javadoc and comment changes > > Testing: > - add new data inputs i

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Joe Darcy
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
On Fri, 29 Oct 2021 15:06:12 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct comment on the handling of ClassNotFoundException > > src/java.base/share/classes/java/io/ObjectInputStream.java

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
> The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `get(String name, Object val)` method to > throw CNFE a

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException

2021-10-29 Thread Daniel Fuchs
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote: > The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `g

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException

2021-10-29 Thread Julia Boes
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote: > The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `g

Re: JDK-8275509: (jlink) SystemModulesPlugin generates a jdk.internal.module.SystemModules$all.class which isn't reproducible

2021-10-29 Thread Jaikiran Pai
Hello Ioi (and others), On 22/10/21 1:39 pm, Jaikiran Pai wrote: Hello Ioi, On 22/10/21 12:29 pm, Ioi Lam wrote: On 10/21/21 9:09 PM, Jaikiran Pai wrote: Hello Ioi, This is my initial analysis of the problem. >>> Can anyone think of similar problems that may happen elsewhere? Th

Re: RFR: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc [v2]

2021-10-29 Thread Masanori Yano
> Could you please review the 8276164 bug fixes? > > I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`. Masanori Yano has updated the pull request incrementally with two additional commits since the last revision: - 8276164: RandomAccessFile#write method could throw I

Re: RFR: JDK-8275650 Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 [v5]

2021-10-29 Thread Mark Sheppard
On Fri, 29 Oct 2021 10:38:41 GMT, Ivan Šipka wrote: >> cc @ctornqvi > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > removed file added by accident Marked as reviewed by msheppar (Reviewer). - PR: https://git.op

Re: RFR: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc

2021-10-29 Thread Alan Bateman
On Fri, 29 Oct 2021 10:37:07 GMT, Masanori Yano wrote: > Could you please review the 8276164 bug fixes? > > I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`. Thanks for separating this from the image I/O issue. For JDK-8276164 then I think we should add the @throws t

Re: RFR: 8274122: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 [v5]

2021-10-29 Thread Mark Sheppard
On Fri, 29 Oct 2021 10:38:41 GMT, Ivan Šipka wrote: >> cc @ctornqvi > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > removed file added by accident bugid in title should be 8275650: i.e. the bugid for problemlist update ---

RFR: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc

2021-10-29 Thread Masanori Yano
Could you please review the 8276164 bug fixes? I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`. - Commit messages: - 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc Changes: https://git.openj

Re: RFR: 8274122: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 [v3]

2021-10-29 Thread Ivan Šipka
On Thu, 28 Oct 2021 18:21:29 GMT, Mark Sheppard wrote: > as per comment from Igor above, the bug id in the problemlist is incorrect, > and it should be 8274122 you have used the bugid for this problemlist update @msheppar the bug id has been updated - PR: https://git.openjdk.java.

Re: RFR: 8274122: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 [v5]

2021-10-29 Thread Ivan Šipka
> cc @ctornqvi Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: removed file added by accident - Changes: - all: https://git.openjdk.java.net/jdk/pull/6025/files - new: https://git.openjdk.java.net/jdk/pull/6025/files/f

Re: RFR: 8252990: Intrinsify Unsafe.storeStoreFence [v2]

2021-10-29 Thread Wang Huang
On Thu, 28 Oct 2021 08:58:48 GMT, Aleksey Shipilev wrote: >> `Unsafe.storeStoreFence` currently delegates to stronger >> `Unsafe.storeFence`. We can teach compilers to map this directly to already >> existing rules that handle `MemBarStoreStore`. Like explicit >> `LoadFence`/`StoreFence`, we i

Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Aleksey Shipilev
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote: > See the [integration > commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30 > ) for JDK-8245095. It reintroduced `java/util/strea

Integrated: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Aleksey Shipilev
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote: > See the [integration > commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30 > ) for JDK-8245095. It reintroduced `java/util/strea

Re: RFR: 8276096: Simplify Unsafe.{load|store}Fence fallbacks by delegating to fullFence

2021-10-29 Thread Andrew Haley
On Thu, 28 Oct 2021 08:47:31 GMT, Aleksey Shipilev wrote: > `Unsafe.{load|store}Fence` falls back to `unsafe.cpp` for > `OrderAccess::{acquire|release}Fence()`. It seems too heavy-handed (useless?) > to call to runtime for a single memory barrier. We can simplify the native > `Unsafe` interfac

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v2]

2021-10-29 Thread Masanori Yano
> Could you please review the 8262297 bug fixes? > > In this case, ImageIO.write() should throw java.io.IOException rather than > java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and > wrapped in IIOException in ImageIO.write() with this fix. In addition, > IndexOutOfBou

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException

2021-10-29 Thread Masanori Yano
On Fri, 29 Oct 2021 07:13:32 GMT, Alan Bateman wrote: >> Unfortunately the parent class does not specify this exception via javadoc >> tags like "@throws IndexOutOfBoundsException", but instead just describe it >> in the method description >> >> should we fix it separately from the imageio fix

Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Claes Redestad
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote: > See the [integration > commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30 > ) for JDK-8245095. It reintroduced `java/util/strea

Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Daniel Fuchs
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote: > See the [integration > commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30 > ) for JDK-8245095. It reintroduced `java/util/strea

Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Julia Boes
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote: > See the [integration > commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30 > ) for JDK-8245095. It reintroduced `java/util/strea

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException

2021-10-29 Thread Phil Race
On Thu, 28 Oct 2021 09:29:13 GMT, Masanori Yano wrote: > Could you please review the 8262297 bug fixes? > > In this case, ImageIO.write() should throw java.io.IOException rather than > java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and > wrapped in IIOException in Ima

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException

2021-10-29 Thread Alan Bateman
On Fri, 29 Oct 2021 07:01:04 GMT, Sergey Bylokhov wrote: > Unfortunately the parent class does not specify this exception via javadoc > tags like "@throws IndexOutOfBoundsException", but instead just describe it > in the method description > > should we fix it separately from the imageio fix?

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException

2021-10-29 Thread Sergey Bylokhov
On Thu, 28 Oct 2021 14:30:20 GMT, Alan Bateman wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException in