Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-12 Thread Alexander Matveev
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6345

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v3]

2021-11-12 Thread Naoto Sato
On Fri, 12 Nov 2021 19:11:07 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit

Re: RFR: 8276609: Document setting property `jdk.serialFilter` to an invalid value throws `ExceptionInInitializerError`

2021-11-12 Thread Lance Andersen
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote: > When set on the command line `jdk.serialFilter` to an invalid value, the > invalid value is logged but the application is allowed to start without > setting the filter. > This leaves the application without the protections of the serial

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v3]

2021-11-12 Thread Naoto Sato
> Please review the subject fix. In light of JEP400, Java runtime can/should > start in UTF-8 charset if the underlying native encoding is not supported. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Force the jnu encoding to UTF-8

Re: RFR: 8277013: Allow creation of module graphs without defining modules to the VM

2021-11-12 Thread Ivan Ristović
On Thu, 11 Nov 2021 14:53:13 GMT, Ivan Ristović wrote: > Related JBS issue: https://bugs.openjdk.java.net/browse/JDK-8277013 > > The GraalVM Native Image module support must create the runtime boot-module > layer at image build time; module instances created at build time need to > reflect

Re: RFR: 8277059: Use blessed modifier order in java.xml

2021-11-12 Thread Joe Wang
On Fri, 12 Nov 2021 15:06:35 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source code in java.xml and > java.xml.crypto. This scripts verifies that modifiers are in the "blessed" > order, and fixes it otherwise. I have manually checked the changes made by > the

Re: RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load

2021-11-12 Thread Naoto Sato
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote: > Please review this simple two-hunk fix to the documentation comment of > java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a > suggestion. I believe it reads better since the plurality is more idiomatic; > native

Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-12 Thread Victor Dyakov
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional @andyherrick please review - PR: https://git.openjdk.java.net/jdk/pull/6345

Re: RFR: 8274856: Failing jpackage tests with fastdebug/release build

2021-11-12 Thread Victor Dyakov
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote: > The fix is to isolate C++ calls in the separate forked child process on > Linux. > This change requires the passing of JLI command line arguments and values of > environment variables between two processes. @andyherrick please review

Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-12 Thread Victor Dyakov
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional @sashamatveev please review - PR: https://git.openjdk.java.net/jdk/pull/6345

Re: RFR: 8277015: Use blessed modifier order in Panama code

2021-11-12 Thread Paul Sandoz
On Fri, 12 Nov 2021 11:13:24 GMT, Maurizio Cimadamore wrote: >>> You could also do this directly in the Panama repo branches. I'll volunteer >>> to help, if you want. >> >> I'll run the script on the PR I've submitted for the Foreign API, and I will >> update that one - thanks. Perhaps

Re: RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load

2021-11-12 Thread Iris Clark
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote: > Please review this simple two-hunk fix to the documentation comment of > java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a > suggestion. I believe it reads better since the plurality is more idiomatic; > native

Re: RFR: 8276609: Document setting property `jdk.serialFilter` to an invalid value throws `ExceptionInInitializerError`

2021-11-12 Thread Roger Riggs
On Wed, 10 Nov 2021 02:06:42 GMT, Jaikiran Pai wrote: >> When set on the command line `jdk.serialFilter` to an invalid value, the >> invalid value is logged but the application is allowed to start without >> setting the filter. >> This leaves the application without the protections of the

Re: RFR: 8276609: Document setting property `jdk.serialFilter` to an invalid value throws `ExceptionInInitializerError`

2021-11-12 Thread Daniel Fuchs
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote: > When set on the command line `jdk.serialFilter` to an invalid value, the > invalid value is logged but the application is allowed to start without > setting the filter. > This leaves the application without the protections of the serial

Integrated: 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File

2021-11-12 Thread Lance Andersen
On Wed, 10 Nov 2021 20:51:20 GMT, Lance Andersen wrote: > Hi all, > > This patch addresses a regression introduced in JDK 15 via JDK-8242959 where > you can no longer access a file entry contained within a Zip file when there > is also a directory entry with the same name via

Integrated: 8274835: Remove unnecessary castings in java.base

2021-11-12 Thread Andrey Turbanov
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to select only casts which are definitely safe to remove. Also didn't > touch primitive types casts. This pull request has now been integrated.

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v8]

2021-11-12 Thread iaroslavski
> Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor javadoc and comment changes > > Testing: > - add new data inputs

RFR: 8277059: Use blessed modifier order in java.xml

2021-11-12 Thread Magnus Ihse Bursie
I ran bin/blessed-modifier-order.sh on source code in java.xml and java.xml.crypto. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. - Commit messages: -

Re: RFR: JDK-8274685 - Documentation suggests there are ArbitrarilyJumpableGenerator when none

2021-11-12 Thread Roger Riggs
On Thu, 11 Nov 2021 13:34:21 GMT, Jim Laskey wrote: > "There is also an interface RandomGenerator.ArbitrarilyJumpableGenerator for > algorithms that allow jumping along the state cycle by any user-specified > distance. In this package, implementations of these interfaces include >

Re: RFR: JDK-8277003 - JumpableGenerator.rngs() documentation refers to wrong method

2021-11-12 Thread Roger Riggs
On Thu, 11 Nov 2021 13:54:37 GMT, Jim Laskey wrote: > Documentation in `RandomGenerator.rngs()` refers to > `JumpableGenerator.jump()` when it should be `JumpableGenerator.jumps()` The change is ok but you'll need to update the title to refer to the original issue: JDK-8273792 The CSR can't

Re: RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load

2021-11-12 Thread Roger Riggs
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote: > Please review this simple two-hunk fix to the documentation comment of > java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a > suggestion. I believe it reads better since the plurality is more idiomatic; > native

Re: RFR: 8277015: Use blessed modifier order in Panama code

2021-11-12 Thread Magnus Ihse Bursie
On Fri, 12 Nov 2021 11:13:24 GMT, Maurizio Cimadamore wrote: >>> You could also do this directly in the Panama repo branches. I'll volunteer >>> to help, if you want. >> >> I'll run the script on the PR I've submitted for the Foreign API, and I will >> update that one - thanks. Perhaps

Re: RFR: 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File [v2]

2021-11-12 Thread Alan Bateman
On Thu, 11 Nov 2021 17:19:04 GMT, Lance Andersen wrote: >> Hi all, >> >> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where >> you can no longer access a file entry contained within a Zip file when there >> is also a directory entry with the same name via

RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load

2021-11-12 Thread Pavel Rappo
Please review this simple two-hunk fix to the documentation comment of java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a suggestion. I believe it reads better since the plurality is more idiomatic; native English speakers should correct me if I'm wrong. The second hunk

Re: RFR: 8277015: Use blessed modifier order in Panama code

2021-11-12 Thread Maurizio Cimadamore
On Thu, 11 Nov 2021 21:34:17 GMT, Maurizio Cimadamore wrote: > > You could also do this directly in the Panama repo branches. I'll volunteer > > to help, if you want. > > I'll run the script on the PR I've submitted for the Foreign API, and I will > update that one - thanks. Perhaps

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v24]

2021-11-12 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull

Always false condition in jdk.internal.jrtfs.JrtFileSystem#getPathMatcher

2021-11-12 Thread Andrey Turbanov
Hello. I found suspicious condition in implementation of method JrtFileSystem.getPathMatcher(String) https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L178 public PathMatcher getPathMatcher(String syntaxAndInput) { int pos =