Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v16]

2021-11-14 Thread Martin Grigorov
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v16]

2021-11-14 Thread Alan Bateman
On 14/11/2021 22:56, Claes Redestad wrote: : Alan: changing `Field.modifiers` still works, but dropping the final modifier is not enough for this to work in the new impl. It won't be hard to adapt to the new world. Users who relies on this today could for example opt-out of the new MH-based im

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v3]

2021-11-14 Thread Ichiroh Takiguchi
On Fri, 12 Nov 2021 19:11:16 GMT, Naoto Sato wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Force the jnu encoding to UTF-8 if the original one is not supported > > I reproduced those failures on Debian Linux. Corre

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v16]

2021-11-14 Thread Claes Redestad
On Sun, 14 Nov 2021 19:54:50 GMT, Martin Grigorov wrote: >> Mandy Chung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 43 commits: >> >> - fix copyright header and typo >> - improve documentation of AccessorUtils >> - Merge br

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Lance Andersen
On Sun, 14 Nov 2021 15:12:16 GMT, Alan Bateman wrote: >> The ZipOutputStream class may create bogus zip data which cannot be opened >> by the ZipFile. The root cause is how the comment field is stored by the >> ZipOutputStream. According to the zip specification, the comment field >> should no

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v16]

2021-11-14 Thread Martin Grigorov
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v5]

2021-11-14 Thread Ichiroh Takiguchi
On Wed, 10 Nov 2021 21:19:30 GMT, Naoto Sato wrote: >> Ichiroh Takiguchi has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - 8274544: Langtools command's usage were garbled on Japanese Windows >> - 8274544: Lan

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Martin Buchholz
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote: > The ZipOutputStream class may create bogus zip data which cannot be opened by > the ZipFile. The root cause is how the comment field is stored by the > ZipOutputStream. According to the zip specification, the comment field should > not

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Alan Bateman
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote: > The ZipOutputStream class may create bogus zip data which cannot be opened by > the ZipFile. The root cause is how the comment field is stored by the > ZipOutputStream. According to the zip specification, the comment field should > not

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Lance Andersen
On Sun, 14 Nov 2021 11:18:48 GMT, Jaikiran Pai wrote: >> The ZipOutputStream class may create bogus zip data which cannot be opened >> by the ZipFile. The root cause is how the comment field is stored by the >> ZipOutputStream. According to the zip specification, the comment field >> should no

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Lance Andersen
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote: > The ZipOutputStream class may create bogus zip data which cannot be opened by > the ZipFile. The root cause is how the comment field is stored by the > ZipOutputStream. According to the zip specification, the comment field should > not

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-14 Thread Alan Bateman
On Sun, 14 Nov 2021 14:41:21 GMT, Naoto Sato wrote: > Initially, I thought that was the case, but I mistook your suggestion as > setting only `notSupportedJnuEncoding` in initPhase1. Reverted the fallback > location into `initPhase1()`. np, it's always tricky to touch code that executes early

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v6]

2021-11-14 Thread Alan Bateman
On Sun, 14 Nov 2021 14:44:59 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-14 Thread Naoto Sato
On Sun, 14 Nov 2021 07:23:18 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed indentation > > src/java.base/share/classes/java/lang/System.java line 2123: > >> 2121: var jnuEncoding =

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v6]

2021-11-14 Thread Naoto Sato
> Please review the subject fix. In light of JEP400, Java runtime can/should > start in UTF-8 charset if the underlying native encoding is not supported. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Move UTF-8 fallback up into initP

Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-14 Thread Andy Herrick
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6345

Re: RFR: 8274856: Failing jpackage tests with fastdebug/release build

2021-11-14 Thread Andy Herrick
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote: > The fix is to isolate C++ calls in the separate forked child process on > Linux. > This change requires the passing of JLI command line arguments and values of > environment variables between two processes. Marked as reviewed by herric

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

2021-11-14 Thread Jaikiran Pai
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote: > The ZipOutputStream class may create bogus zip data which cannot be opened by > the ZipFile. The root cause is how the comment field is stored by the > ZipOutputStream. According to the zip specification, the comment field should > not