Re: RFR: JDK-8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE

2021-11-20 Thread Jaikiran Pai
On Sat, 20 Nov 2021 19:13:43 GMT, Mandy Chung wrote: > java.lang.reflect.Field::set on static field with invalid argument type > should throw IAE. But this regression is introduced by JEP 416 throwing NPE > instead. > > `ensureObj` is called as the first check of the `Field::set` method to en

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v4]

2021-11-20 Thread Vicente Romero
> Please review this PR which aims to optimize the implementation of the > `toString` method we provide for records. A benchmark comparing the > implementation we are providing for records with lombok found out that lombok > is much faster mainly because our implementation uses `String::format`.

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v3]

2021-11-20 Thread Vicente Romero
On Fri, 19 Nov 2021 05:07:23 GMT, Vicente Romero wrote: >> Please review this PR which aims to optimize the implementation of the >> `toString` method we provide for records. A benchmark comparing the >> implementation we are providing for records with lombok found out that >> lombok is much f

RFR: JDK-8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE

2021-11-20 Thread Mandy Chung
java.lang.reflect.Field::set on static field with invalid argument type should throw IAE. But this regression is introduced by JEP 416 throwing NPE instead. `ensureObj` is called as the first check of the `Field::set` method to ensure the receiver object is checked first before the argument.

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v3]

2021-11-20 Thread Jim Laskey
On Sat, 20 Nov 2021 11:31:41 GMT, Claes Redestad wrote: >> Regarding the slot limit in `StringConcatFactory`, it's not clear to me the >> limit of 200 is normative or is merely an implementation note. The limit of >> 200 slots seems to be arbitrary and shouldn't be baked into the spec. >> Perh

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v3]

2021-11-20 Thread PROgrm_JARvis
On Sat, 20 Nov 2021 04:40:22 GMT, Stuart Marks wrote: > Regarding the slot limit in `StringConcatFactory`, it's not clear to me the > limit of 200 is normative or is merely an implementation note. The limit of > 200 slots seems to be arbitrary and shouldn't be baked into the spec. Perhaps > th

Re: RFR: 8277429: Conflicting jpackage static library name

2021-11-20 Thread Andy Herrick
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote: > 8277429: Conflicting jpackage static library name Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6485

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v3]

2021-11-20 Thread Claes Redestad
On Sat, 20 Nov 2021 04:40:22 GMT, Stuart Marks wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adding the benchmark > > Regarding the slot limit in `StringConcatFactory`, it's not clear to me the > limit of 200

Re: RFR: 8261847: performace of java.lang.Record::toString should be improved [v3]

2021-11-20 Thread Jim Laskey
On Fri, 19 Nov 2021 05:07:23 GMT, Vicente Romero wrote: >> Please review this PR which aims to optimize the implementation of the >> `toString` method we provide for records. A benchmark comparing the >> implementation we are providing for records with lombok found out that >> lombok is much f

RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-11-20 Thread Jaikiran Pai
Can I please get a review for this change which proposes to fix the issue reported in https://bugs.openjdk.java.net/browse/JDK-8003417? The issue notes that this is applicable for `WeakHashMap` which have `null` keys. However, the issue is even applicable for `WeakHashMap` instances which don't