Re: RFR: JDK-8277095 : Empty streams create too many objects [v2]

2021-12-14 Thread kabutz
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote: >> This is a draft proposal for how we could improve stream performance for the >> case where the streams are empty. Empty collections are common-place. If we >> iterate over them with an Iterator, we would have to create one small >> Iterator

Re: [jdk18] RFR: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation

2021-12-14 Thread David Holmes
On Wed, 15 Dec 2021 05:59:45 GMT, Vladimir Kozlov wrote: > A proper fix for this is to use the catchException combination. However, that > introduces significant cold startup performance regression. JDK-8278447 > tracks the work to address the performance regression using catchException > and

[jdk18] RFR: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation

2021-12-14 Thread Vladimir Kozlov
A proper fix for this is to use the catchException combination. However, that introduces significant cold startup performance regression. JDK-8278447 tracks the work to address the performance regression using catchException and asSpreader combinator. It may require significant work and

[jdk18] Integrated: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

2021-12-14 Thread Alexander Matveev
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev wrote: > This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT > instead of actual value of timeout variable. Execution of osascript was > running without timeout and thus several tests timeout. Osascript hang during >

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-12-14 Thread liach
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. Just curious, what else is recommended for such

Re: RFR: 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination

2021-12-14 Thread Сергей Цыпанов
On Tue, 14 Dec 2021 19:12:29 GMT, Mai Đặng Quân Anh wrote: > The problem, at first glance, seems to be that our compiled code is trying to > compute this mysterious number @merykitty how do you view it? 樂 - PR: https://git.openjdk.java.net/jdk/pull/6812

Integrated: 8278028: [test-library] Warnings cleanup of the test library

2021-12-14 Thread Roger Riggs
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote: > Compilation warnings of the test library introduce noise in test output and > should be addressed or suppressed. > Changes include: > - SuppressWarnings("deprecation") and SuppressWarnings("removal") > - Adding type parameters to Raw

Re: [jdk18] RFR: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

2021-12-14 Thread Alexey Semenyuk
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev wrote: > This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT > instead of actual value of timeout variable. Execution of osascript was > running without timeout and thus several tests timeout. Osascript hang during >

Re: RFR: 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination

2021-12-14 Thread Mai Đặng Quân Anh
On Mon, 13 Dec 2021 09:39:55 GMT, Сергей Цыпанов wrote: > Originally this was spotted by by Amir Hadadi in > https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor > > It looks like in the following code in `String(byte[], int, int, Charset)` >

Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-14 Thread Lance Andersen
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote: > This is a doc fix to `StringTokenizer`, where the original spec does not > account for the delimiter's length in the case of a supplementary character. > Corresponding CSR has been drafted: >

Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-14 Thread Joe Wang
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote: > This is a doc fix to `StringTokenizer`, where the original spec does not > account for the delimiter's length in the case of a supplementary character. > Corresponding CSR has been drafted: >

Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-14 Thread Iris Clark
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote: > This is a doc fix to `StringTokenizer`, where the original spec does not > account for the delimiter's length in the case of a supplementary character. > Corresponding CSR has been drafted: >

RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug

2021-12-14 Thread Naoto Sato
This is a doc fix to `StringTokenizer`, where the original spec does not account for the delimiter's length in the case of a supplementary character. Corresponding CSR has been drafted: https://bugs.openjdk.java.net/browse/JDK-8278814 - Commit messages: - 8278587:

Re: RFR: JDK-8277795: ldap connection timeout not honoured under contention [v3]

2021-12-14 Thread Rob McKenna
> This fix attemps to resolve an issue where threads can stack up on each other > while waiting to get a connection from the ldap pool to an unreachable > server. It does this by having each thread start a countdown prior to holding > the pools' lock. (which has been changed to a ReentrantLock)

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library [v2]

2021-12-14 Thread Roger Riggs
On Tue, 14 Dec 2021 03:14:10 GMT, Leonid Mesnik wrote: > Is test/micro/org/openjdk/bench/java/io/SerialFilterOverhead.java added > accidentally or by purpose? By mistake, thanks for noticing. - PR: https://git.openjdk.java.net/jdk/pull/6638

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library [v3]

2021-12-14 Thread Leonid Mesnik
On Tue, 14 Dec 2021 15:20:31 GMT, Roger Riggs wrote: >> Compilation warnings of the test library introduce noise in test output and >> should be addressed or suppressed. >> Changes include: >> - SuppressWarnings("deprecation") and SuppressWarnings("removal") >> - Adding type parameters to

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library [v3]

2021-12-14 Thread Roger Riggs
> Compilation warnings of the test library introduce noise in test output and > should be addressed or suppressed. > Changes include: > - SuppressWarnings("deprecation") and SuppressWarnings("removal") > - Adding type parameters to Raw types > - Adding a hashCode method where equals was

Re: RFR: 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination

2021-12-14 Thread amirhadadi
On Tue, 14 Dec 2021 13:20:46 GMT, Alan Bateman wrote: >>> Originally this was spotted by by Amir Hadadi in >>> https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor >> >> Before anyone looks at this, can you confirm that the patch does not

RFR: 8278642: Refactor java.util.Formatter

2021-12-14 Thread Claes Redestad
A few refactorings to how `java.util.Formatter` sets up `FormatString`s, aligning the implementation with changes explored by the TemplatedStrings JEP and ever so slightly improving performance: - turn `Flags` into an `int` (fewer allocations in the complex case) - remove some superfluous

Re: [jdk18] RFR: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

2021-12-14 Thread Andy Herrick
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev wrote: > This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT > instead of actual value of timeout variable. Execution of osascript was > running without timeout and thus several tests timeout. Osascript hang during >

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-14 Thread Andrew Leonard
On Fri, 10 Dec 2021 19:40:59 GMT, Lance Andersen wrote: >> Looks like the CSR has been approved. I have a mach5 run that should >> hopefully finish sooner rather than later and if that remains happy, I will >> approve the PR > >> @LanceAndersen let me know if mach5 looks good please, then I

Re: RFR: 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination

2021-12-14 Thread Alan Bateman
On Mon, 13 Dec 2021 09:55:36 GMT, Alan Bateman wrote: >> Originally this was spotted by by Amir Hadadi in >> https://stackoverflow.com/questions/70272651/missing-bounds-checking-elimination-in-string-constructor >> >> It looks like in the following code in `String(byte[], int, int, Charset)`

Re: [jdk18] RFR: 8278607: Misc issues in foreign API javadoc [v4]

2021-12-14 Thread Maurizio Cimadamore
> This patch fixes a number of issues and typos in the foreign API javadoc > following another internal round of reviews. Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Fix typo as per review comment. Improve javadoc for

Re: [jdk18] RFR: 8278607: Misc issues in foreign API javadoc [v3]

2021-12-14 Thread Athijegannathan Sundararajan
On Tue, 14 Dec 2021 02:07:00 GMT, Maurizio Cimadamore wrote: >> This patch fixes a number of issues and typos in the foreign API javadoc >> following another internal round of reviews. > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the