Integrated: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Joe Darcy
On Mon, 20 Dec 2021 18:23:46 GMT, Joe Darcy wrote: > Cleanup and regularization of the specs of the four > get[Declared]Constructor[s] methods. This pull request has now been integrated. Changeset: 51796728 Author:Joe Darcy URL:

Re: RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Joe Darcy
On Mon, 20 Dec 2021 18:23:46 GMT, Joe Darcy wrote: > Cleanup and regularization of the specs of the four > get[Declared]Constructor[s] methods. CSR filed and approved: https://bugs.openjdk.java.net/browse/JDK-8279046 - PR: https://git.openjdk.java.net/jdk/pull/6897

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-20 Thread Stuart Marks
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote: > Enable the security manager in rmiregistry's launcher arguments. I think there's little to worry about with custom configurations of the `rmiregistry` tool. What somebody might do is to enable a customized security manager using

Re: RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Joe Darcy
On Mon, 20 Dec 2021 20:48:35 GMT, Alan Bateman wrote: > This looks okay, just wondering if expanded NoSuchMethodException description > warrants a CSR. Hmm. I don't think a CSR is strictly necessary as the additional conditions are arguably implied by the rest of the spec, but I can run a

Re: RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Alan Bateman
On Mon, 20 Dec 2021 18:23:46 GMT, Joe Darcy wrote: > Cleanup and regularization of the specs of the four > get[Declared]Constructor[s] methods. This looks okay, just wondering if expanded NoSuchMethodException description warrants a CSR. - Marked as reviewed by alanb (Reviewer).

Re: RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Mandy Chung
On Mon, 20 Dec 2021 18:23:46 GMT, Joe Darcy wrote: > Cleanup and regularization of the specs of the four > get[Declared]Constructor[s] methods. LGTM - Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6897

RFR: JDK-8278953: Clarify Class.getDeclaredConstructor specification

2021-12-20 Thread Joe Darcy
Cleanup and regularization of the specs of the four get[Declared]Constructor[s] methods. - Commit messages: - JDK-8278953: Clarify Class.getDeclaredConstructor specification Changes: https://git.openjdk.java.net/jdk/pull/6897/files Webrev:

Re: RFR: JDK-8276302: Locale.filterTags methods ignore actual weight when matching "*" (as if it is 1)

2021-12-20 Thread Naoto Sato
On Fri, 10 Dec 2021 00:02:31 GMT, Daniel Le wrote: > Locale.filterTags methods ignore actual weight when matching "*" (as if > it is 1) because LocaleMatcher.{filterBasic,filterExtended} do so. > > Fix the bug and add regression test cases for it as well as existing > behavior. Thanks for the

Re: possible bug in jdeps as ToolProvider

2021-12-20 Thread Mandy Chung
Yes this bug is known and tracked by JDK-8277681.  The proper solution should make each JdepsTask to maintain its own map of multi-versioned entries rather than a global nameToVersion map for the running VM as described in JDK-8277681. Mandy On 12/18/21 7:47 PM, Raymond Augé wrote: Hello

RFR: 8273322: Enhance macro logic optimization for masked logic operations.

2021-12-20 Thread Jatin Bhateja
Patch extends existing macrologic inferencing algorithm to handle masked logic operations. Existing algorithm: 1. Identify logic cone roots. 2. Packs parent and logic child nodes into a MacroLogic node in bottom up traversal if input constraint are met. i.e. maximum number of inputs which a

RFR: 8276694: Pattern trailing unescaped backslash causes internal error

2021-12-20 Thread Masanori Yano
Could you please review the 8276694 bug fixes? A message specific for this exception should be printed instead of an internal error. This fix adds a new check to output an appropriate exception message when the regular expression ends with an unescaped backslash. This fix also checks the