On Thu, 16 Dec 2021 20:48:39 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request with a new t
On Thu, 13 Jan 2022 11:40:20 GMT, Lance Andersen wrote:
>> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well?
>> Separating the [] completely looks quite rare.
>> I'll leave it up to you. 8-)
>
> I think that can be a follow on clean up.
The strange formatting of `long []updateC
On Thu, 13 Jan 2022 21:57:57 GMT, Sean Mullan wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
On Thu, 13 Jan 2022 15:23:25 GMT, Claes Redestad wrote:
> I've taken up the (bad?) habit of creating it manually to keep a tab on my
> current tasks and intents.
I do that too in some cases, and for the same reason. The only potential
downside is if you create a concrete version for a specific
On Thu, 13 Jan 2022 21:54:17 GMT, Weijun Wang wrote:
>> The algorithm constraints check will be skipped (because `permittedAlgs`
>> will be `null`) but the hash check will not be skipped.
>>
>> I don't think `null` would be returned in a normal case. The only case I can
>> think of is if there
On Thu, 13 Jan 2022 21:52:59 GMT, Naoto Sato wrote:
> 8278434: timeouts in test
> java/time/test/java/time/format/TestZoneTextPrinterParser.java
This pull request has now been integrated.
Changeset: 064ee6ae
Author:Naoto Sato
URL:
https://git.openjdk.java.net/jdk18/commit/064ee6ae
8278434: timeouts in test
java/time/test/java/time/format/TestZoneTextPrinterParser.java
-
Commit messages:
- Backport 8dc4437d002db5d025b47f48e7420e3bae55bdec
Changes: https://git.openjdk.java.net/jdk18/pull/100/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=100&r
On Thu, 13 Jan 2022 19:54:44 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
>> line 211:
>>
>>> 209: }
>>> 210:
>>> 211: CodeSigner[] entrySigners = sigFileSigners.get(name);
>>
>> What if we return here if `entrySigners ==
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue such that an entry is considered signed if at least one
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
- 8279833: Loop optimization issue in String.encodeUTF8_UTF16
- 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to
build with GCC 6.3.0
- 8274007: [
On Sun, 24 Oct 2021 16:27:02 GMT, andrewluotechnologies
wrote:
> `AbstractLdapNamingEnumeration` `next` throws `NullPointerException` instead
> of `NoSuchElementException`, however the javadoc for `NamingEnumeration` says
> that next should throw `NoSuchElementException` when no elements are
On Thu, 13 Jan 2022 16:55:08 GMT, Weijun Wang wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
On Thu, 13 Jan 2022 18:32:20 GMT, Maurizio Cimadamore
wrote:
>> When looking at larger benchmarks, I noted a discrepancy between the
>> performance of off-heap segments and on-heap segments. Looking at the
>> assembly for the `MemorySegment::asSlice` method I could see some additional
>> barr
> When looking at larger benchmarks, I noted a discrepancy between the
> performance of off-heap segments and on-heap segments. Looking at the
> assembly for the `MemorySegment::asSlice` method I could see some additional
> barriers in the off-heap case, but could not initially make sense of the
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 13:48:02 GMT, Pavel Rappo wrote:
> > Yes an "or" is probably worthwhile to add.
>
> I would prefer to leave it for the follow-up cleanup if only because adding
> "or" here would make it inconsistent with other `@throws SQLException`
> descriptions in that file and perhaps e
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 10:59:13 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/text/RuleBasedBreakIterator.java line 73:
>>
>>> 71: * will be transparent to the BreakIterator. A sequence of
>>> characters will break the
>>> 72: * same way it would if any ignore characters it contain
On Thu, 13 Jan 2022 12:37:46 GMT, Pavel Rappo wrote:
> > The above is a bit confusing as it reads(same in ImageInputStream.java). I
> > think that that can be looked at later.
>
> Just to clarify: you are okay with removing the ` ` entity, right? As for
> ImageInputStream, some doc comments sh
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 12:26:17 GMT, Maurizio Cimadamore
wrote:
>> When looking at larger benchmarks, I noted a discrepancy between the
>> performance of off-heap segments and on-heap segments. Looking at the
>> assembly for the `MemorySegment::asSlice` method I could see some additional
>> barr
On Thu, 13 Jan 2022 13:56:14 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
>> line 212:
>>
>>> 210:
>>> 211: CodeSigner[] entrySigners = sigFileSigners.get(name);
>>> 212: Map permittedAlgs =
>>
>> maybe permittedAlgsChecke
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Thu, 13 Jan 2022 15:14:05 GMT, Kevin Rushforth wrote:
>>> LGTM
>>
>> Thanks!
>>
>>> (This a backport but is using the mainline bug number; already resolved).
>>
>> I think that's intentional? I entered "Backport COMMITHASH" as the PR
>> subject as per instructions and the bots have taken t
On Thu, 13 Jan 2022 13:46:53 GMT, Claes Redestad wrote:
> 8279833: Loop optimization issue in String.encodeUTF8_UTF16
This pull request has now been integrated.
Changeset: ff856593
Author:Claes Redestad
URL:
https://git.openjdk.java.net/jdk18/commit/ff8565931115d581afff679ea85b1a2d8
On Thu, 13 Jan 2022 15:05:42 GMT, Claes Redestad wrote:
> > (This a backport but is using the mainline bug number; already resolved).
>
> I think that's intentional? I entered "Backport COMMITHASH" as the PR subject
> as per instructions and the bots have taken things from there.
Yes, it's bot
On Thu, 13 Jan 2022 14:56:50 GMT, Roger Riggs wrote:
> LGTM
Thanks!
> (This a backport but is using the mainline bug number; already resolved).
I think that's intentional? I entered "Backport COMMITHASH" as the PR subject
as per instructions and the bots have taken things from there.
---
- Original Message -
> From: "Steven Schlansker"
> To: "core-libs-dev"
> Sent: Wednesday, January 12, 2022 9:56:30 PM
> Subject: LambdaMetafactory requires full privilege access, but doesn't seem
> to actually restrict functionality
> Hi core-libs-dev,
>
> I am maintaining a module
On Thu, 13 Jan 2022 13:46:53 GMT, Claes Redestad wrote:
> 8279833: Loop optimization issue in String.encodeUTF8_UTF16
LGTM
(This a backport but is using the mainline bug number; already resolved).
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk18/pu
On Thu, 13 Jan 2022 12:19:03 GMT, Roman Kennke wrote:
>> Thread.java would benefit from a refactoring similar to JDK-8278065 to use
>> ClassValue instead of the somewhat problematic WeakClassKey mechanism.
>>
>> Testing:
>> - [x] tier1
>> - [x] tier2
>> - [x] tier3
>
> Roman Kennke has updat
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream and DataInput is an irrelevant
> formatting artefact
On Thu, 13 Jan 2022 12:33:53 GMT, Sean Coffey wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
8279833: Loop optimization issue in String.encodeUTF8_UTF16
-
Commit messages:
- 8279833: Loop optimization issue in String.encodeUTF8_UTF16
Changes: https://git.openjdk.java.net/jdk18/pull/99/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=99&range=00
Issue: https:
On Thu, 13 Jan 2022 11:38:13 GMT, Lance Andersen wrote:
> Yes an "or" is probably worthwhile to add.
I would prefer to leave it for the follow-up cleanup if only because adding
"or" here would make it inconsistent with other `@throws SQLException`
descriptions in that file and perhaps elsewher
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Thu, 13 Jan 2022 11:42:48 GMT, Lance Andersen wrote:
> The above is a bit confusing as it reads(same in ImageInputStream.java). I
> think that that can be looked at later.
Just to clarify: you are okay with removing the ` ` entity, right? As for
ImageInputStream, some doc comments should pr
On Thu, 13 Jan 2022 10:02:04 GMT, Andrey Turbanov wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove obsolete comment
>
> src/java.base/share/classes/java/lang/Thread.java line 1671:
>
>> 1669: /** cache o
> When looking at larger benchmarks, I noted a discrepancy between the
> performance of off-heap segments and on-heap segments. Looking at the
> assembly for the `MemorySegment::asSlice` method I could see some additional
> barriers in the off-heap case, but could not initially make sense of the
> Thread.java would benefit from a refactoring similar to JDK-8278065 to use
> ClassValue instead of the somewhat problematic WeakClassKey mechanism.
>
> Testing:
> - [x] tier1
> - [x] tier2
> - [x] tier3
Roman Kennke has updated the pull request incrementally with one additional
commit sinc
On Thu, 13 Jan 2022 11:29:35 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/Statement.java line 784:
>>
>>> 782: * statement returns a {@code ResultSet} object, the second
>>> argument
>>> 783: * supplied to this method is not an
>>> 784: * {@code int} array whose
On Thu, 13 Jan 2022 11:28:34 GMT, Kevin Walls wrote:
>> I thought about it too, but then noticed how the position of `[]` mimics
>> that of the respective method signatures in code.
>
> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? Separating
> the [] completely looks quite
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 11:18:42 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 11:04:43 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/BatchUpdateException.java line 58:
>>
>>> 56: * A JDBC driver implementation should use
>>> 57: * the constructor {@code BatchUpdateException(String reason, String
>>> SQLState,
>>> 58: * int vendorCo
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 11:00:55 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, in ImageInputStre
On Thu, 13 Jan 2022 10:46:11 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, in ImageInputStre
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
- Most of the typos are of a trivial kind: missing whitespace.
- If any of the typos should be fixed in the upstream projects instead, please
say so; I will drop those typos from the patch.
- As I understand it, in ImageInputStream and DataInput is an irrelevant
formatting artefact and thus can
On Thu, 13 Jan 2022 10:09:45 GMT, Daniel Fuchs wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/LdapClientFactory.java line
>> 70:
>>
>>> 68: public PooledConnection createPooledConnection(PoolCallback pcb,
>>> long timeout)
>>> 69: throws NamingException {
>>> 70:
On Thu, 13 Jan 2022 01:07:52 GMT, Mark Sheppard wrote:
>> Rob McKenna has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow the test to pass on MacOSX
>
> src/java.naming/share/classes/com/sun/jndi/ldap/LdapClientFactory.java line
> 70:
On Wed, 12 Jan 2022 19:39:29 GMT, Roman Kennke wrote:
> Thread.java would benefit from a refactoring similar to JDK-8278065 to use
> ClassValue instead of the somewhat problematic WeakClassKey mechanism.
>
> Testing:
> - [x] tier1
> - [x] tier2
> - [x] tier3
src/java.base/share/classes/java
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
58 matches
Mail list logo
