On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7041
On Tue, 18 Jan 2022 01:13:45 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 39f140a2
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/39f140a20120300074167597580f9be34e812cad
Stats: 403 l
On Fri, 14 Jan 2022 14:33:13 GMT, Jim Laskey wrote:
> Tests were fatally failing (windows) on Github actions. Pumping up the memory
> requirements will hopefully alleviate.
I also pointed out that we see the same error message in our CI and the infra
folk assured me that the paging file was no
On Mon, 17 Jan 2022 18:10:02 GMT, Lance Andersen wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> test/jdk/java/util/zip/ZipFile/TestTooManyEntr
> Could you please review the JDK-8272746 bug fixes?
> Since the array index is of type int, the overflow occurs when the value of
> end.cenlen is too large because of too many entries.
> It is necessary to read a part of the CEN from the file to fix the problem
> fundamentally, but the way will
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
- 8279998: PPC64 debug builds fail with "untested: RangeCheckStub:
predicate_failed_trap_id"
- 8280034: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
On Thu, 13 Jan 2022 20:55:49 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 37143c09
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/37143c09ab56ff07767ab3ac392234e36ee82358
Stats: 124 l
On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
Hi @masyano,
Thanks for fixing `java.naming` module javadoc. The fix looks fine to me.
-
Marked as reviewed by aefimov (Committer).
PR: http
On Sat, 11 Dec 2021 01:55:50 GMT, Ioi Lam wrote:
>> **Background:**
>>
>> In the Java Language, Enums can be tested for equality, so the constants in
>> an Enum type must be unique. Javac compiles an enum declaration like this:
>>
>>
>> public enum Day { SUNDAY, MONDAY ... }
>>
>>
>> to
>
On Mon, 17 Jan 2022 09:56:13 GMT, Masanori Yano wrote:
>> Could you please review the JDK-8272746 bug fixes?
>> Since the array index is of type int, the overflow occurs when the value of
>> end.cenlen is too large because of too many entries.
>> It is necessary to read a part of the CEN from th
On Sun, 19 Dec 2021 06:51:45 GMT, liach wrote:
>> Upon review of [8261407](https://bugs.openjdk.java.net/browse/JDK-8261407),
>> by design, duplicate initialization of ReflectionFactory should be safe as
>> it performs side-effect-free property read actions, and the suggesting of
>> making the
On Mon, 17 Jan 2022 06:32:13 GMT, Prasadrao Koppula
wrote:
>> This system property should only be used for TLS, and the CBT can be used in
>> both the SPNEGO mechanism and the Kerberos 5 mechanism. Therefore I suggest
>> the name should probably contain "tls" (or maybe "https") and "negotiate"
On Sat, 15 Jan 2022 00:49:05 GMT, Weijun Wang wrote:
>> Argh - you're right I missed the fact that the 3 expressions where included
>> in parenthesis. I read it as
>>
>> ! (s.equals("always")) || ...
>
> Shall we log a message if the value is not one of the 3 forms?
Usually malformed values a
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a
On Wed, 15 Dec 2021 23:04:37 GMT, Claes Redestad wrote:
> During TemplatedStrings work Jim has noticed that we could probably profit
> from reusing the lookup tables also for the 1 or 2 leftmost bytes:
>
> // We know there are at most two digits left at this point.
> buf[--charP
On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
Could someone please review this pull request?
-
PR: https://git.openjdk.java.net/jdk/pull/7041
- Original Message -
> From: "Andrey Turbanov"
> To: "core-libs-dev"
> Sent: Monday, January 17, 2022 10:37:04 AM
> Subject: Thread.dispatchUncaughtException possible NPE?
> Hello.
Hello Andrey,
> I see that Thread.dispatchUncaughtException calls
> getUncaughtExceptionHandler() which r
> Could you please review the JDK-8272746 bug fixes?
> Since the array index is of type int, the overflow occurs when the value of
> end.cenlen is too large because of too many entries.
> It is necessary to read a part of the CEN from the file to fix the problem
> fundamentally, but the way will
On Fri, 14 Jan 2022 23:55:58 GMT, Lance Andersen wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> Thank you for making the changes. Overall it
Hello.
I see that Thread.dispatchUncaughtException calls
getUncaughtExceptionHandler() which reads volatile field twice:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Thread.java#L1978
private volatile UncaughtExceptionHandler uncaughtExceptionHandler;
public Un
On Thu, 13 Jan 2022 08:39:04 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
21 matches
Mail list logo
