On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io.PrintWriter`.
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding description
[v4]
--
On Wed, 16 Feb 2022 19:11:53 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix test
OK, good progress. Yes, leaving ConcurrentHas
On Wed, 16 Feb 2022 20:06:09 GMT, Alexey Semenyuk wrote:
> 8282007: Assorted enhancements to jpackage testing framework
This pull request has now been integrated.
Changeset: cd234f5d
Author:Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/commit/cd234f5dbebd18ebf0c78dfdf533318c
On Thu, 17 Feb 2022 05:11:40 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request incrementally with one additional
> comm
On Thu, 17 Feb 2022 03:50:39 GMT, Alexey Semenyuk wrote:
>> 8282007: Assorted enhancements to jpackage testing framework
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Copyright years fixed
Marked as reviewed by almatv
On Thu, 17 Feb 2022 03:05:36 GMT, Athijegannathan Sundararajan
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains six additiona
> Make explicit illegal argument cases of Class.arrayType.
>
> Please also review the corresponding CSR:
> https://bugs.openjdk.java.net/browse/JDK-8268300
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
--
On Thu, 17 Feb 2022 02:56:53 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request with a new target base due to a merge
>
On Wed, 16 Feb 2022 23:53:44 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't fail if requested to uninstall not installed Debian package
>
> test/jdk/tools/jpackage/helpers/jdk/jpac
> 8282007: Assorted enhancements to jpackage testing framework
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Copyright years fixed
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7502/files
- new: https:
On Wed, 16 Feb 2022 12:30:27 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing fra
On Thu, 17 Feb 2022 02:56:53 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request with a new target base due to a merge
>
On Thu, 17 Feb 2022 02:56:53 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request with a new target base due to a merge
>
> Make explicit illegal argument cases of Class.arrayType.
>
> Please also review the corresponding CSR:
> https://bugs.openjdk.java.net/browse/JDK-8268300
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated cha
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Thu, 17 Feb 2022 00:16:02 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: b6e48e67
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/b6e48e678244481dd45d38bc3ddc325fccda2acc
Stats: 423 l
On Wed, 16 Feb 2022 23:51:30 GMT, Alexey Semenyuk wrote:
>> 8282007: Assorted enhancements to jpackage testing framework
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Don't fail if requested to uninstall not installed
On Tue, 15 Feb 2022 03:45:19 GMT, Stuart Marks wrote:
>>> The changes to j.l.Class and the EnumConstantDirectory test don't belong
>>> here -- these are _uses_ of HashMap. This bug and fix should focus on
>>> HashMap itself, to ensure that the cases in question allocate a table of
>>> the righ
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8280415: Remove EA from JDK 18 version string starting with Initial RC
promotion B35 on February 10, 2022
- 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
The webrevs contain the adjustments done whi
> 8282007: Assorted enhancements to jpackage testing framework
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Don't fail if requested to uninstall not installed Debian package
-
Changes:
- all: https://git.openjdk.
On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote:
> 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
> light.exe is not in %PATH%
This pull request has now been integrated.
Changeset: 0b00ce17
Author:Alexey Semenyuk
URL:
https://git.openjdk.java.net/jd
On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote:
> 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
> light.exe is not in %PATH%
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7500
On Wed, 16 Feb 2022 22:41:40 GMT, Ian Graves wrote:
>> This is a fix in the buggy way CIBackRef traverses unicode characters that
>> could be variable-length. Originally it followed the approach that BackRef
>> does, but failed to account for unicode characters that could be 2
>> chars-long. T
On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io.PrintWriter`.
> This is a fix in the buggy way CIBackRef traverses unicode characters that
> could be variable-length. Originally it followed the approach that BackRef
> does, but failed to account for unicode characters that could be 2
> chars-long. The upper bound (groupSize) for the traversing loop is set
Remove reference to `java.io.InterruptedIOException` from
`java.io.PrintStream`, and make the specifications of `checkError()`,
`setError()`, and `clearError()` consistent between `java.io.PrintStream` and
`java.io.PrintWriter`.
-
Commit messages:
- 8254574: PrintWriter handling o
On Wed, 16 Feb 2022 21:39:20 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - Merge
On Wed, 16 Feb 2022 21:19:04 GMT, Olga Mikhaltsova
wrote:
> This fix made equal processing of strings such as ""C:\\Program
> Files\\Git\\"" before and after JDK-8250568.
>
> For example, it's needed to execute the following command on Windows:
> `C:\Windows\SysWOW64\WScript.exe "MyVB.vbs" "C:
On 2/12/2022 6:55 PM, Jatin Bhateja wrote:
On Fri, 21 Jan 2022 00:49:04 GMT, Sandhya Viswanathan
wrote:
The JVM currently initializes the x86 mxcsr to round to nearest even, see below
in stubGenerator_x86_64.cpp: // Round to nearest (even), 64-bit mode,
exceptions masked StubRoutines::x86
On Wed, 16 Feb 2022 14:48:04 GMT, Andrey Turbanov wrote:
> Couple of fields in StrictMath are unused since
> [JDK-8244146](https://bugs.openjdk.java.net/browse/JDK-8244146).
> Also I fixed incorrect javadoc for private method. Looks like typo in
> [JDK-6282196](https://bugs.openjdk.java.net/bro
On Tue, 15 Feb 2022 22:23:36 GMT, Joe Darcy wrote:
> Add explicit discussion of array types to Class.getCanonicalName, no change
> in behavior.
>
> I didn't see any existing regression tests for the various "getFooName"
> methods of Class so I created a new test file for a handful of test case
On Wed, 16 Feb 2022 20:17:31 GMT, Mandy Chung wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Augment test.
>
> test/jdk/java/lang/Class/NameTest.java line 27:
>
>> 25: * @test
>> 26: * @bug 8281671
>> 27: * @summ
On Wed, 16 Feb 2022 21:00:00 GMT, Naoto Sato wrote:
>> This is a fix in the buggy way CIBackRef traverses unicode characters that
>> could be variable-length. Originally it followed the approach that BackRef
>> does, but failed to account for unicode characters that could be 2
>> chars-long. T
On Wed, 16 Feb 2022 21:39:20 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - Merge
On Wed, 16 Feb 2022 14:48:04 GMT, Andrey Turbanov wrote:
> Couple of fields in StrictMath are unused since
> [JDK-8244146](https://bugs.openjdk.java.net/browse/JDK-8244146).
> Also I fixed incorrect javadoc for private method. Looks like typo in
> [JDK-6282196](https://bugs.openjdk.java.net/bro
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- Merge master
- fix test breakage from rename
- reformat test summary
-
On Feb 16, 2022, at 12:10 PM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
I suspect Ilya meant using syscall(2) with the NR. We had code in libnio that
used approach for the *at functions before they were added to the glibc header
files. It's a bit fragile as they are architecture s
This fix made equal processing of strings such as ""C:\\Program Files\\Git\\""
before and after JDK-8250568.
For example, it's needed to execute the following command on Windows:
`C:\Windows\SysWOW64\WScript.exe "MyVB.vbs" "C:\Program Files\Git" "Test"`
it's equal to:
`new ProcessBuilder("C:\\Win
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix test breakage from rename
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull
> Add explicit discussion of array types to Class.getCanonicalName, no change
> in behavior.
>
> I didn't see any existing regression tests for the various "getFooName"
> methods of Class so I created a new test file for a handful of test cases.
>
> Please also review the corresponding CSR:
>
On Wed, 16 Feb 2022 18:45:29 GMT, Ian Graves wrote:
> This is a fix in the buggy way CIBackRef traverses unicode characters that
> could be variable-length. Originally it followed the approach that BackRef
> does, but failed to account for unicode characters that could be 2
> chars-long. The u
Couple of fields in StrictMath are unused since
[JDK-8244146](https://bugs.openjdk.java.net/browse/JDK-8244146).
Also I fixed incorrect javadoc for private method. Looks like typo in
[JDK-6282196](https://bugs.openjdk.java.net/browse/JDK-6282196)
-
Commit messages:
- [PATCH] Remove
8282007: Assorted enhancements to jpackage testing framework
-
Commit messages:
- Trailing whitespace removed
- 8282007: Assorted enhancements to jpackage testing framework
- macOS bugix
- Don't use TKit.assertZZZ to validate test setup correctness. Throw exception
instead.
- As
On Tue, 15 Feb 2022 22:23:36 GMT, Joe Darcy wrote:
> Add explicit discussion of array types to Class.getCanonicalName, no change
> in behavior.
>
> I didn't see any existing regression tests for the various "getFooName"
> methods of Class so I created a new test file for a handful of test case
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
This pull request has now been integrated.
Changeset: 67763df4
Author:Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.java.net/jdk/commit/67763df4dc
On 16/02/2022 20:03, Brian Burkhalter wrote:
On Feb 16, 2022, at 9:51 AM, Ilya Starchenko
wrote:
I think we can just check if syscall return ENOSYS and if it’s true
fail back to more generic code.
The code would not even build without the syscall in the headers so I
don’t think so.
I s
On Feb 16, 2022, at 9:51 AM, Ilya Starchenko
mailto:redux1234...@mail.ru>> wrote:
I think we can just check if syscall return ENOSYS and if it’s true fail back
to more generic code.
The code would not even build without the syscall in the headers so I don’t
think so.
Brian
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new: https://git.openj
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with three additional
commits since the last revision:
- reformat test summary
- reformat test summary
- improve test name and remove experimental test
This is a fix in the buggy way CIBackRef traverses unicode characters that
could be variable-length. Originally it followed the approach that BackRef
does, but failed to account for unicode characters that could be 2 chars-long.
The upper bound (groupSize) for the traversing loop is set by the d
On Wed, 16 Feb 2022 17:55:55 GMT, Tim Prinzing wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix copyright date
Marked as reviewed by alanb (Revi
On Thu, 10 Feb 2022 23:27:49 GMT, Mandy Chung wrote:
> This patch removes the restriction in the raw library loading mechanism that
> does not allow mix-n-match of loading a library as a JNI library and as a raw
> library.
>
> The raw library loading mechanism is designed for panama to load na
8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
light.exe is not in %PATH%
-
Commit messages:
- 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails locally
Changes: https://git.openjdk.java.net/jdk/pull/7500/files
Webrev: https://webrevs.op
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: https://
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7448/files
On Wed, 19 Jan 2022 05:50:50 GMT, Ioi Lam wrote:
>> I don't really know this code well enough to do a good code review. I had
>> some comments though.
>
>> I don't really know this code well enough to do a good code review. I had
>> some comments though.
>
> Hi Coleen, thanks for taking a loo
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
More changes from feedback.
The javadoc is improved to reflect InvalidCallerException is thrown
On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote:
> 8281874: Can't unpack msi installers from
> test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
> test
This pull request has now been integrated.
Changeset: 81645521
Author:Alexey Semenyuk
U
On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote:
> Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
> test parameter.
> Fix the code to handle the case when installers are not created and there is
> nothing to verify in the test.
This pull request has now bee
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new: https://git.openj
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new: https://git.openj
On Thu, 3 Feb 2022 23:29:54 GMT, Naoto Sato wrote:
> Following the prior discussion [1], here is the PR for the subject
> enhancement. CSR has also been updated according to the suggestion.
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
This pull requ
On Feb 16, 2022, at 5:40 AM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
On 16/02/2022 13:13, Ilya Starchenko wrote:
I have suggestion. Copy_file_range() has been introduced in the Linux kernel
since version 4.5. system call performs an in-kernel copy between two file
descriptors wi
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new: https://git.openj
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- revert changes in ConcurrentHashMap
- 9072610: HashMap copy constructor and putAll can over-allocate table
---
On Tue, 15 Feb 2022 18:23:51 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 9072610: HashMap copy constructor and putAll can over-a
On 16/02/2022 13:13, Ilya Starchenko wrote:
I have suggestion. Copy_file_range() has been introduced in the Linux kernel since version 4.5. system call performs an in-kernel copy between two file descriptors without the additional cost of transferring data from the kernel to user space and then
On Tue, 15 Feb 2022 21:09:57 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Tue, 15 Feb 2022 19:59:43 GMT, Mandy Chung wrote:
>> This patch removes the restriction in the raw library loading mechanism that
>> does not allow mix-n-match of loading a library as a JNI library and as a
>> raw library.
>>
>> The raw library loading mechanism is designed for panama to lo
On Wed, 16 Feb 2022 12:26:45 GMT, Jatin Bhateja wrote:
>>> > Hi, IIRC for evex encoding you can embed the RC control bit directly in
>>> > the evex prefix, removing the need to rely on global MXCSR register.
>>> > Thanks.
>>>
>>> Hi @merykitty , You are correct, we can embed RC mode in instruc
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic
On Mon, 14 Feb 2022 17:14:10 GMT, Jatin Bhateja wrote:
>> That pseudocode would make a very useful comment too. This whole patch is
>> very thinly commented.
>
>> > Hi, IIRC for evex encoding you can embed the RC control bit directly in
>> > the evex prefix, removing the need to rely on global
On Fri, 11 Feb 2022 20:49:33 GMT, Joe Darcy wrote:
>> Thanks, Joe.
>>
>> Regarding the RFE, do you plan to open an issue to address the documentation
>> for `getCanonicalName`?
>
> Filed https://bugs.openjdk.java.net/browse/JDK-8281671
Thanks for filing that.
-
PR: https://git.op
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic
Currently, `InflaterInputStream::read()` first does a native call to the
underlying zlib `inflate()` function and only afterwards checks if the inflater
requires input (i.e. `Inflater::needsInput()`) or has finished inflating
(`Inflater::finished()`). This leads to an unnecessary native call to
76 matches
Mail list logo
