On Tue, 15 Mar 2022 02:47:20 GMT, Xiaohong Gong wrote:
> Note that in terms of Java semantics, negation of floating point values needs
> to be implemented as subtraction from negative zero rather than positive zero:
>
> double negate(double arg) {return -0.0 - arg; }
>
> This is to handle sign
On Fri, 11 Mar 2022 06:29:22 GMT, Xiaohong Gong wrote:
> The current vector `"NEG"` is implemented with substraction a vector by zero
> in case the architecture does not support the negation instruction. And to
> fit the predicate feature for architectures that support it, the masked
> vector
On Wed, 16 Mar 2022 17:16:06 GMT, liach wrote:
>> liach has updated the pull request incrementally with two additional commits
>> since the last revision:
>>
>> - merge branch 'identityhashmap-bench' of
>> https://github.com/liachmodded/jdk into identityhashmap-default
>> - fix whitespace
>
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
> Change `CallSite` to a sealed class, as `CallSite` is an abstract class which
> does not allow direct subclassing by users per its documentation. Since I
> don't have a JBS account, I posted the content for the CSR in a GitHub Gist
> at https://gist.github.com/150d5aa7f8b13a4deddf95969ad39d73
On Fri, 18 Mar 2022 19:11:45 GMT, jmehrens wrote:
> > you are not expected to inspect a random object by its string.
> > ToString representations tend to show up in exception messages and logging.
> > Seems like this adapter just won't adapt that call. Not a deal breaker.
>
> > Also the rever
On Fri, 18 Mar 2022 21:05:01 GMT, altrisi wrote:
> Note that there's a class in tests (or something similar) that extends
> CallSite directly:
> https://github.com/openjdk/jdk/blob/d8893fad23d1ee6841336b96c34599643edb81ce/test/hotspot/jtreg/vmTestbase/vm/mlvm/patches/java.base/java/lang/invoke/
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 17 Mar 2022 08:07:23 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at http
On Thu, 17 Mar 2022 20:56:34 GMT, Mikael Vidstedt wrote:
> Note: this PR replaces the one I messed up earlier.
>
> Background, from JBS:
>
> src/java.base/share/native/libverify/check_code.c: In function
> 'read_all_code':
> src/java.base/share/native/libverify/check_code.c:942:5: error: 'leng
On Mon, 14 Mar 2022 10:35:58 GMT, Tobias Hartmann wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Windows build failure fix.
>
> `compiler/c2/cr6340864/TestFloatVect.java` and `TestDoubleVect.java` fail o
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic
On Fri, 18 Mar 2022 15:40:09 GMT, Tyler Steele wrote:
>> As mentioned in the issue, I'd like to perform the following tidying on
>> ClassLoader.c
>>
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Fri, 18 Mar 2022 13:10:10 GMT, liach wrote:
>you are not expected to inspect a random object by its string.
ToString representations tend to show up in exception messages and logging.
Seems like this adapter just won't adapt that call. Not a deal breaker.
> Also the reverse order comparat
On Fri, 18 Mar 2022 08:39:46 GMT, Alan Bateman wrote:
>> This change removes support for
>> `-Dsun.misc.URLClassPath.disableJarChecking`. As discussed in the bug the
>> feature doesn't current work, and only ever supported scenarios where a
>> security manager is installed, so it seems safe to
On Fri, 18 Mar 2022 08:39:46 GMT, Alan Bateman wrote:
> I don't know what the motivation for this change is but there is more to this
> story and I think will require agreement from the security area before
> removing it.
Thanks @AlanBateman. The motivation is that I was investigating an unrel
On Thu, 17 Mar 2022 23:44:32 GMT, Liam Miller-Cushon wrote:
> This change removes support for `-Dsun.misc.URLClassPath.disableJarChecking`.
> As discussed in the bug the feature doesn't current work, and only ever
> supported scenarios where a security manager is installed, so it seems safe
>
On Fri, 18 Mar 2022 04:01:05 GMT, Jiangli Zhou wrote:
>> This change removes support for
>> `-Dsun.misc.URLClassPath.disableJarChecking`. As discussed in the bug the
>> feature doesn't current work, and only ever supported scenarios where a
>> security manager is installed, so it seems safe to
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will ensur
On Fri, 18 Mar 2022 15:40:09 GMT, Tyler Steele wrote:
>> As mentioned in the issue, I'd like to perform the following tidying on
>> ClassLoader.c
>>
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has
On Sun, 13 Mar 2022 14:08:57 GMT, Ravi Reddy wrote:
> Hi All,
>
> This review request contains fix for infinite loop issue in
> DeflaterOutputStream.finish() in an exception scenario.
> 1. The issue is with 'finished' flag not getting set to correct value when
> there is an IOException in
>
> As mentioned in the issue, I'd like to perform the following tidying on
> ClassLoader.c
>
> - Alphabetize includes.
> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
> - Replace 'return 0' with 'return NULL'.
Tyler Steele has updated the pull request incrementally with one additional
commi
On Fri, 18 Mar 2022 15:13:17 GMT, Tyler Steele wrote:
>> As mentioned in the issue, I'd like to perform the following tidying on
>> ClassLoader.c
>>
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has
On Fri, 18 Mar 2022 07:43:21 GMT, Alan Bateman wrote:
>> Tyler Steele has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve comment
>>
>> - Reword to avoid double use of malloc(X)
>> - Remove bug id
>
> src/java.base/share/nativ
On Fri, 18 Mar 2022 15:25:20 GMT, ExE Boss wrote:
>> I can split down the comment if you prefer. It might be appropriate to do in
>> the as-yet-unmerged cleanup PR I have open for the same file.
>>
>> I am not sure what you mean by 'use identification'. Can you clarify?
>
> I think it’s a typo
On Fri, 18 Mar 2022 15:22:48 GMT, Tyler Steele wrote:
>> src/java.base/share/native/libjava/ClassLoader.c line 104:
>>
>>> 102: // On AIX malloc(0) returns NULL which looks like an out-of-memory
>>> condition; so adjust it to malloc(1)
>>> 103: #ifdef _AIX
>>> 104: body = (jbyte *)m
On Fri, 18 Mar 2022 15:13:17 GMT, Tyler Steele wrote:
>> As mentioned in the issue, I'd like to perform the following tidying on
>> ClassLoader.c
>>
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has
> The thread factory used to create the process reaper threads unnecessarily
> inherits the callers thread context classloader.
> The result is retention of the class loader.
>
> The thread factory used for the pool of process reaper threads is modified to
> use an InnocuousThread with a given s
> As mentioned in the issue, I'd like to perform the following tidying on
> ClassLoader.c
>
> - Alphabetize includes.
> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
> - Replace 'return 0' with 'return NULL'.
Tyler Steele has updated the pull request incrementally with one additional
commi
> As mentioned in the issue, I'd like to perform the following tidying on
> ClassLoader.c
>
> - Alphabetize includes.
> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
> - Replace 'return 0' with 'return NULL'.
Tyler Steele has updated the pull request with a new target base due to a merge
o
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will ensur
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will ensur
> 18 mars 2022 kl. 11:04 skrev Alan Bateman :
>
> I can't tell if you are planning to integrate this or wait until there is
> discussion on the locations proposed in the Informational JEP that you've
> just submitted. Maybe you plan to just integrate and then adjust/move again
> if needed?
I
On Fri, 18 Mar 2022 13:06:12 GMT, jmehrens wrote:
> > The toString method of both classes do not implement anything so i dont
> > think we should override it,
>
> The inherited implementation is descriptive enough because the the class
> names are the implementation:
> https://github.com
On Fri, 18 Mar 2022 00:24:56 GMT, Yasser Bazzi wrote:
> The toString method of both classes do not implement anything so i dont think
> we should override it,
The inherited implementation is descriptive enough because the the class names
are the implementation:
https://github.com/openjdk/
On Tue, 18 Jan 2022 15:57:58 GMT, Roger Riggs wrote:
> The thread factory used to create the process reaper threads unnecessarily
> inherits the callers thread context classloader.
> The result is retention of the class loader.
>
> The thread factory used for the pool of process reaper threads
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 22:00:15 GMT, Liam Miller-Cushon wrote:
> This change improves an exception message to include a path, e.g. `Invalid
> Jar file: some.jar` instead of just `Invalid Jar file`.
>
> The exception is currently [always being caught and
> ignored](https://github.com/openjdk/jdk/b
On Thu, 17 Mar 2022 23:44:32 GMT, Liam Miller-Cushon wrote:
> This change removes support for `-Dsun.misc.URLClassPath.disableJarChecking`.
> As discussed in the bug the feature doesn't current work, and only ever
> supported scenarios where a security manager is installed, so it seems safe
>
On Thu, 17 Mar 2022 16:08:11 GMT, Tyler Steele wrote:
>> As mentioned in the issue, I'd like to perform the following tidying on
>> ClassLoader.c
>>
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has
On Thu, 17 Mar 2022 16:23:14 GMT, Tyler Steele wrote:
>> As described in the linked issue, NullClassBytesTest fails due an
>> OutOfMemoryError produced on AIX when the test calls defineClass with a byte
>> array of size of 0. The native implementation of defineClass then calls
>> malloc with
On Fri, 18 Mar 2022 02:15:36 GMT, David Holmes wrote:
> Update looks good. Sorry for the AIX_ONLY misdirect.
>
> Thanks, David
It would be real nice to have the same set of macros in JDK too, though.
-
PR: https://git.openjdk.java.net/jdk/pull/7829
On Tue, 15 Mar 2022 22:58:48 GMT, Tyler Steele wrote:
> As described in the linked issue, NullClassBytesTest fails due an
> OutOfMemoryError produced on AIX when the test calls defineClass with a byte
> array of size of 0. The native implementation of defineClass then calls
> malloc with a si
45 matches
Mail list logo
