Re: RFR: 8186958: Need method to create pre-sized HashMap [v7]

2022-03-30 Thread XenoAmess
On Wed, 30 Mar 2022 00:12:59 GMT, Stuart Marks wrote: >> XenoAmess has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update jmh >> - refine javadoc; refine implement when expectedSize < 0 > > OK, finally got some time to look at this. H

Re: RFR: 8186958: Need method to create pre-sized HashMap [v8]

2022-03-30 Thread XenoAmess
> 8186958: Need method to create pre-sized HashMap XenoAmess has updated the pull request incrementally with one additional commit since the last revision: update codes - Changes: - all: https://git.openjdk.java.net/jdk/pull/7928/files - new: https://git.openjdk.java.net/jdk/

Re: RFR: 8283726: x86 intrinsics for compare method in Integer and Long [v2]

2022-03-30 Thread Vamsi Parasa
> Implements x86 intrinsics for compare() method in java.lang.Integer and > java.lang.Long. Vamsi Parasa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contain

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v16]

2022-03-30 Thread Paul Sandoz
On Wed, 30 Mar 2022 21:51:16 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v15]

2022-03-30 Thread ExE Boss
On Wed, 30 Mar 2022 20:59:34 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Roger Riggs
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote: > A few integer divisions and multiplications can be replaced with test + > addition, leading to a decent speed-up on java.time microbenchmarks such as > `GetYearBench`. Numbers from my local x86 workstation, seeing similar > speed-up on

Re: RFR: JDK-8277095 : Empty streams create too many objects [v2]

2022-03-30 Thread Muescha
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote: >> This is a draft proposal for how we could improve stream performance for the >> case where the streams are empty. Empty collections are common-place. If we >> iterate over them with an Iterator, we would have to create one small >> Iterator ob

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v16]

2022-03-30 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Integrated: 8283801: Cleanup confusing String.toString calls

2022-03-30 Thread Andrey Turbanov
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote: > String.toString() calls doesn't make much sense. Only one place, where it > could be used - to generate NPE. But in a few places of JDK codebase it's > called, even when NPE will happen anyway. > I propose to cleanup such places. > Foun

Re: RFR: 8283801: Cleanup confusing String.toString calls

2022-03-30 Thread Andrey Turbanov
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote: > String.toString() calls doesn't make much sense. Only one place, where it > could be used - to generate NPE. But in a few places of JDK codebase it's > called, even when NPE will happen anyway. > I propose to cleanup such places. > Foun

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v15]

2022-03-30 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-30 Thread Liam Miller-Cushon
On Fri, 18 Mar 2022 18:59:16 GMT, Sean Mullan wrote: >> I don't know what the motivation for this change is but there is more to >> this story and I think will require agreement from the security area before >> removing it. > > I agree with @AlanBateman. Please don't proceed with this fix until

Re: RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Naoto Sato
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote: > A few integer divisions and multiplications can be replaced with test + > addition, leading to a decent speed-up on java.time microbenchmarks such as > `GetYearBench`. Numbers from my local x86 workstation, seeing similar > speed-up on

Re: RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

2022-03-30 Thread Stephen Colebourne
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote: > Fixes test failures caused by depending on the default locale. Specifying > explicit `Locale.US` will do. Marked as reviewed by scolebourne (Author). - PR: https://git.openjdk.java.net/jdk/pull/8045

Re: RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Stephen Colebourne
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote: > A few integer divisions and multiplications can be replaced with test + > addition, leading to a decent speed-up on java.time microbenchmarks such as > `GetYearBench`. Numbers from my local x86 workstation, seeing similar > speed-up on

Re: RFR: 8283994: Make Xerces DatatypeException stackless

2022-03-30 Thread Joe Wang
On Wed, 30 Mar 2022 11:38:59 GMT, Aleksey Shipilev wrote: > See bug report for more details. This change improves > SPECjvm2008:xml.validation for about +3%: > > > baseline: 298.353 ± 1.008 ops/min > patched: 309.912 ± 1.347 ops/min > > Of course, the real improvements might be even high

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v14]

2022-03-30 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

2022-03-30 Thread Roger Riggs
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote: > Fixes test failures caused by depending on the default locale. Specifying > explicit `Locale.US` will do. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8045

Integrated: 8283470: Update java.lang.invoke.VarHandle to use sealed classes

2022-03-30 Thread Mandy Chung
On Wed, 23 Mar 2022 16:27:29 GMT, Mandy Chung wrote: > This patch changes VarHandle and its implementation hierarchy to use sealed > classes. All VarHandle permitted classes are package-private and either > final or sealed abstract classes. > > Please also review the CSR: https://bugs.openjdk

Re: RFR: 8283060: RawNativeLibraries should allow multiple clients to load/unload the same library

2022-03-30 Thread Mandy Chung
On Wed, 30 Mar 2022 13:21:41 GMT, Jaikiran Pai wrote: >> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load` >> returns the same `NativeLibrary` instance of a given path if it's called >> multiple times. This means that multiple clients have to coordinate that the >> last

Re: RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

2022-03-30 Thread Iris Clark
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote: > Fixes test failures caused by depending on the default locale. Specifying > explicit `Locale.US` will do. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8045

Re: RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Claes Redestad
On Wed, 30 Mar 2022 16:08:15 GMT, Brian Burkhalter wrote: > Looks all right assuming tests pass. Thanks! Tier1+2 testing passed. - PR: https://git.openjdk.java.net/jdk/pull/8039

Re: RFR: 8282508: Updating ASM to 9.2 for JDK 19 [v3]

2022-03-30 Thread Erik Gahlin
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote: >> Please review this PR which is updating the ASM included in the JDK to ASM >> 9.2. This version should be included in JDK19. There are basically two >> commits here, one that was automatically generated and that mostly changes >> file

RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

2022-03-30 Thread Naoto Sato
Fixes test failures caused by depending on the default locale. Specifying explicit `Locale.US` will do. - Commit messages: - 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException Changes: https://git.openjdk.java.net/jdk/pull/8045/files Webrev:

Re: RFR: 8282508: Updating ASM to 9.2 for JDK 19 [v3]

2022-03-30 Thread Lance Andersen
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote: >> Please review this PR which is updating the ASM included in the JDK to ASM >> 9.2. This version should be included in JDK19. There are basically two >> commits here, one that was automatically generated and that mostly changes >> file

Re: RFR: 8282508: Updating ASM to 9.2 for JDK 19 [v3]

2022-03-30 Thread Vicente Romero
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote: >> Please review this PR which is updating the ASM included in the JDK to ASM >> 9.2. This version should be included in JDK19. There are basically two >> commits here, one that was automatically generated and that mostly changes >> file

Re: RFR: 5087440: java.io bulk read(...) end-of-stream return value descriptions ambiguous [v2]

2022-03-30 Thread Lance Andersen
On Wed, 30 Mar 2022 16:28:16 GMT, Brian Burkhalter wrote: >> Minimal version of possible fixes: make the bulk read `@return` verbiage >> consistent in the `java.io` package. > > Brian Burkhalter has refreshed the contents of this pull request, and > previous commits have been removed. The incre

Re: RFR: 5087440: java.io bulk read(...) end-of-stream return value descriptions ambiguous [v2]

2022-03-30 Thread Brian Burkhalter
> Minimal version of possible fixes: make the bulk read `@return` verbiage > consistent in the `java.io` package. Brian Burkhalter has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous conten

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature

2022-03-30 Thread Quan Anh Mai
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote: > Currently the vector load with mask when the given index happens out of the > array boundary is implemented with pure java scalar code to avoid the IOOBE > (IndexOutOfBoundaryException). This is necessary for architectures that do > not

Re: RFR: 5087440: (ch spec) java.io, nio bulk read(...) end-of-stream return value descriptions ambiguous

2022-03-30 Thread Roger Riggs
On Wed, 30 Mar 2022 16:05:03 GMT, Brian Burkhalter wrote: > Minimal version of possible fixes: make the bulk read `@return` verbiage > consistent in the `java.io` package. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8044

Re: RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Brian Burkhalter
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote: > A few integer divisions and multiplications can be replaced with test + > addition, leading to a decent speed-up on java.time microbenchmarks such as > `GetYearBench`. Numbers from my local x86 workstation, seeing similar > speed-up on

RFR: 5087440: (ch spec) java.io,nio bulk read(...) end-of-stream return value descriptions ambiguous

2022-03-30 Thread Brian Burkhalter
Minimal version of possible fixes: make the bulk read `@return` verbiage consistent in the `java.io` package. - Commit messages: - 5087440: (ch spec) java.io,nio bulk read(...) end-of-stream return value descriptions ambiguous Changes: https://git.openjdk.java.net/jdk/pull/8044/fi

Integrated: 8283715: Update ObjectStreamClass to be final

2022-03-30 Thread Stuart Marks
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. This pull request has now been integrated. Changeset: ae57258b Author:Stuart Marks URL: https://git.openjdk.java.net/jdk/commit/ae57258b46b8b6953148cd8cf71faf75eef118da Stats: 10 lines in 2 fi

Re: RFR: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10

2022-03-30 Thread Naoto Sato
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote: > redo of 8280400 I believe `src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties` and `test/jdk/sun/text/resources/LocaleData` have to be adjusted according to the l10n changes. - PR: https:

Re: RFR: 8283060: RawNativeLibraries should allow multiple clients to load/unload the same library

2022-03-30 Thread Jaikiran Pai
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote: > A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load` > returns the same `NativeLibrary` instance of a given path if it's called > multiple times. This means that multiple clients have to coordinate that the > last one

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-30 Thread Naoto Sato
On Wed, 30 Mar 2022 00:46:49 GMT, Joe Wang wrote: >> Resets state of a Catalog instance on each matching call so that it can be >> reused. Adjusts CatalogResolver's resolve routine so that it continues to >> observes the PREFER feature in a resolution process. Without the adjustment, >> Prefer

RFR: 8283996: Reduce cost of year and month calculations

2022-03-30 Thread Claes Redestad
A few integer divisions and multiplications can be replaced with test + addition, leading to a decent speed-up on java.time microbenchmarks such as `GetYearBench`. Numbers from my local x86 workstation, seeing similar speed-up on aarch64 and other x86 setups. Baseline: Benchmark

Re: RFR: 8283060: RawNativeLibraries should allow multiple clients to load/unload the same library

2022-03-30 Thread Jorn Vernee
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote: > A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load` > returns the same `NativeLibrary` instance of a given path if it's called > multiple times. This means that multiple clients have to coordinate that the > last one

RFR: 8283994: Make Xerces DatatypeException stackless

2022-03-30 Thread Aleksey Shipilev
See bug report for more details. This change improves SPECjvm2008:xml.validation for about +3%: baseline: 298.353 ± 1.008 ops/min patched: 309.912 ± 1.347 ops/min Of course, the real improvements might be even higher, as exception might be thrown from much deeper call hierarchy. Addition

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature

2022-03-30 Thread Quan Anh Mai
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote: > Currently the vector load with mask when the given index happens out of the > array boundary is implemented with pure java scalar code to avoid the IOOBE > (IndexOutOfBoundaryException). This is necessary for architectures that do > not

Re: RFR: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10

2022-03-30 Thread Kevin Rushforth
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote: > redo of 8280400 Since this is identical to the original fix, I would expect the same Tier2 test failure as reported in [JDK-8283804](https://bugs.openjdk.java.net/browse/JDK-8283804). - PR: https://git.openjdk.java.net/jdk/p

RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature

2022-03-30 Thread Xiaohong Gong
Currently the vector load with mask when the given index happens out of the array boundary is implemented with pure java scalar code to avoid the IOOBE (IndexOutOfBoundaryException). This is necessary for architectures that do not support the predicate feature. Because the masked load is impleme

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-30 Thread Lance Andersen
On Tue, 29 Mar 2022 12:45:51 GMT, Volker Simonis wrote: > > Hello Volker, An additional thing that we might have to consider here is > > whether adding this javadoc change to `InflaterInputStream` is ever going > > to "show up" to end user applications. What I mean is, I think in many > > case

Re: RFR: 8265768 [aarch64] Use glibc libm impl for dlog,dlog10,dexp iff 2.29 or greater on AArch64.

2022-03-30 Thread Tobias Hartmann
On Tue, 25 May 2021 15:32:40 GMT, gregcawthorne wrote: >> Glibc 2.29 onwards provides optimised versions of log,log10,exp. >> These functions have an accuracy of 0.9ulp or better in glibc >> 2.29. >> >> Therefore this patch adds code to parse, store and check >> the runtime glibcs version in os_

Integrated: 8283800: Simplify String.indexOf/lastIndexOf calls

2022-03-30 Thread Andrey Turbanov
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote: > In a few places String.indexOf/lastIndexOf methods are called with default > parameter for index: `0` for `indexOf`, length() for `lastIndexOf`. > I propose to cleanup such calls. It makes code a bit easier to read. In case > of `indexO

Integrated: 8283846: Remove unused jdk.internal.reflect.SignatureIterator

2022-03-30 Thread Andrey Turbanov
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote: > It was no longer used due to JDK-4479184 long ago. This pull request has now been integrated. Changeset: b323f54f Author:Andrey Turbanov URL: https://git.openjdk.java.net/jdk/commit/b323f54feef13a47bb02af608eb1f6474692d905 S