On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object)))
> to mention such behavior.
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>>
On Sun, 17 Apr 2022 16:17:30 GMT, liach wrote:
> Convert dynamic proxies to hidden classes. Modifies the serialization of
> proxies (requires change in "Java Object Serialization Specification"). Makes
> the proxies hidden in stack traces. Removes duplicate logic in proxy building.
>
> The
On Fri, 22 Apr 2022 07:08:24 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>>
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Fri, 29 Apr 2022 18:27:27 GMT, Mikhailo Seledtsov
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/jdk/jdk/jfr/api/consumer/TestManyRecordings.java line
On Fri, 29 Apr 2022 20:45:20 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/java/time/format/ZoneName.java.template line 60:
>>
>>> 58:
>>> 59: public static String toZid(String zid) {
>>> 60: return aliases.getOrDefault(zid, zid);
>>
>> Is the behavior if zid == null
On Fri, 29 Apr 2022 20:36:59 GMT, Roger Riggs wrote:
>aliases.getOrDefault will throw NPE on null
No, It will not. `aliases` is a HashMap. And HashMap supports null values and
keys.
-
PR: https://git.openjdk.java.net/jdk/pull/8463
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Sat, 5 Mar 2022 19:54:44 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
`Map.containsKey` call is sometimes unnecessary, when it's known that Map
doesn't contain `null` values.
Instead we can just use Map.get and compare result with `null`.
I found one of such place, where Map.containsKey calls could be eliminated -
`java.time.format.ZoneName`.
it gives a bit of
On Fri, 29 Apr 2022 18:28:45 GMT, Weijun Wang wrote:
>> Shouldn't the comparison be better implemented by the caller then, who will
>> know whether spaces are important or not? That's why I had suggested taking
>> a `Predicate` that could be called with each line removed, and the
>> caller
On Wed, 27 Apr 2022 11:03:48 GMT, Jatin Bhateja wrote:
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
Hi All,
Patch adds the planned support for new vector operations and APIs targeted for
[JEP 426: Vector API (Fourth
Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
Following is the brief summary of changes:-
1) Extends the scope of existing lanewise API for following new
On Fri, 29 Apr 2022 14:19:40 GMT, Daniel Fuchs wrote:
>> The comparison is intentionally made lax so the caller does not need to
>> provide the exact indentation or even new line characters. We think along
>> with `fromLine` and `toLine` this is enough to make sure we are not
>> modifying the
On Fri, 29 Apr 2022 18:23:35 GMT, Mikhailo Seledtsov
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/jdk/jdk/jfr/api/consumer/TestManyClasses.java line
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato wrote:
> This was caused by incorporating CLDR v39, which switched the Norwegian
> locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources
> from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly
>
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 02:12:19 GMT, Iris Clark wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change punctuation from review feedback.
>
> src/java.base/share/classes/java/lang/System.java line 743:
>
>> 741: *
On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato wrote:
> This was caused by incorporating CLDR v39, which switched the Norwegian
> locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources
> from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly
>
On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that adds dedicated filler objects to
>> the VM?
>>
>> Currently, when formatting areas of dead objects all gcs use instances of
>> j.l.Object and int-arrays.
>>
>> This has the
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 06:35:44 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
On Fri, 29 Apr 2022 12:02:59 GMT, Jaikiran Pai wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated to add space character in begining of multiline string
>
> test/lib/jdk/test/lib/util/FileUtils.java line
On Fri, 29 Apr 2022 13:02:06 GMT, Weijun Wang wrote:
>> Also calling trim() assumes that white spaces are not significant. This
>> might not be the case in the general case (for instance - think of markdown
>> files were leading spaces are significant).
>
> The comparison is intentionally made
> Removing the Duplicate keys present in XSLTErrorResources.java and
> XPATHErrorResources.java
>
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
Shruthi has updated the pull request incrementally with one additional commit
since the last revision:
Updating
On Fri, 29 Apr 2022 12:51:21 GMT, Jaikiran Pai wrote:
> Quick question - the path you note, is that even applicable for x64? I see
> that it has a "System32" so just curious.
Yes, System32 is not related to 32 vs 64 bit. As I understand it, that name was
introduced when moving from 16 to 32
On Fri, 29 Apr 2022 12:44:26 GMT, Daniel Fuchs wrote:
>> test/lib/jdk/test/lib/util/FileUtils.java line 394:
>>
>>> 392: var removed = "";
>>> 393: for (int i = fromLine; i <= toLine; i++) {
>>> 394: removed += lines.remove(fromLine - 1).trim();
>>
>>
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 12:35:59 GMT, Daniel Fuchs wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285452: updated to use lines()
>
> test/lib/jdk/test/lib/util/FileUtils.java line 394:
>
>> 392: var
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8285452: updated to use lines()
-
Changes:
- all:
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8285452: updated to from.lines()
-
Changes:
- all:
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Fri, 29 Apr 2022 10:46:31 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated to add space character in begining
On Fri, 29 Apr 2022 10:36:50 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: Add a new test library API to
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8285915?
With this change, the environment details collected by the failure handler will
now include the contents of the `/etc/hosts/` file, which can be useful in
certain cases when debugging
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 10:46:58 GMT, Sibabrata Sahoo wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated to add space character in begining of multiline string
>
>
On Fri, 29 Apr 2022 10:46:31 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated to add space character in begining
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
updated to add space character in begining of multiline string
-
Changes:
- all:
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8285452: Add a new test library API to replace a file content using
FileUtils.java
-
Changes:
Hi,
Thanks for the pointers.
> Just to mention a few:
>
https://urldefense.com/v3/__https://www.baeldung.com/java-9-http-client__;!!ACWV5N9M2RV99hQ!MbomkSmr-rXolK88z_JdINs3IEG8MTH_B7DHDq6wYgUeJQvZNGT7Iwb3yFswd57S1l85R53Yo_zq8zIvWdw$
>
Hi,
Just to mention a few:
https://www.baeldung.com/java-9-http-client
https://developer.ibm.com/tutorials/java-theory-and-practice-3/
Also from this issue also assume it's support:
https://bugs.openjdk.java.net/browse/JDK-8138990
and this issue also contains a reference to:
Hi,
java.net.http.HttpClient only supports Basic authentication out
of the box.
Which tutorials are claiming that Digest authentication is supported?
Can you send some links?
At the moment there is no plan to support digest authentication out of
the box. It can be easily implemented at the
* Syntactically improves a few cases from 8285676
(https://github.com/openjdk/jdk/pull/8410)
* Fixes a few misspelled `@param` tags for elements that, although are not
included in the API Documentation, are visible in and processed by IDEs
-
Commit messages:
- Fix misspelled
On Fri, 29 Apr 2022 08:45:42 GMT, Pavel Rappo wrote:
> Good catch. Sorry I missed it. This occurs in all `java/lang/ref` files.
I've created a PR; feel free to review it at your convenience.
-
PR: https://git.openjdk.java.net/jdk/pull/8410
On Thu, 28 Apr 2022 19:06:04 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/ref/PhantomReference.java line 48:
>>
>>> 46: * The {@link #refersTo(Object) refersTo} method can be used to test
>>> 47: * whether some object is the referent of a phantom reference.
>>> 48: *
On Fri, 29 Apr 2022 08:06:24 GMT, Maurizio Cimadamore
wrote:
> would a jep unneeded be enough to "unstuck" this PR?
Yes if no bug. Conceptually, the `/jep unneeded` will behave as no jep command.
-
PR: https://git.openjdk.java.net/jdk/pull/7888
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Fri, 29 Apr 2022 00:44:01 GMT, Guoxiong Li wrote:
> Remind: please use the command `/jep JEP-424` [1] to mark this PR.
>
> [1]
> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep
Question: I'm willing to try it out. If something goes wrong - would a
On Mon, 25 Apr 2022 04:35:13 GMT, Sergey Bylokhov wrote:
> The new test added as part of the
> [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot
> trigger that bug and pass w/ and w/o fix.
>
> An updated test validates the "default" case when the `jdk.io.File.enableADS`
On Fri, 29 Apr 2022 05:09:35 GMT, David Holmes wrote:
> That only seems to be half of the issue though. If we are defining
> _WIN32_WINNT=0x0601 because the minimum required OS API support level is
> Windows 7, then don't we need a check that the build platform is also at
> least Windows 7?
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>>
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
69 matches
Mail list logo
