On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote:
> This patch backs out the changes made by
> [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and
> [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there
> are failures due to div nodes floating above th
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>> sub
On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote:
> This patch backs out the changes made by
> [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and
> [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there
> are failures due to div nodes floating above th
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
This pull request has now been integrated.
Changeset: 26c7c92b
Author:Yasumasa Suenaga
URL:
https://git.openjdk.java.net/jdk/commit/26c7c92bc93f3eecf7ce69c69f1999ba879d1d60
Stats: 5 lines in
> On May 11, 2022, at 4:39 PM, Alexander Matveev
> wrote:
>
> - It is not possible to support native JDK commands such as "java" inside Mac
> App Store bundles due to embedded info.plist. Workarounds suggested in
> JDK-8286122 does not seems to be visible.
I was just thinking about this. I
On Tue, 10 May 2022 14:58:28 GMT, zhw970623 wrote:
> The copyright year of
> src/java.base/share/classes/jdk/internal/vm/FillerObject.java should be 2022.
Looks good and trivial.
Thanks for spotting and fixing it.
-
Marked as reviewed by jiefu (Reviewer).
PR: https://git.openjdk.
On Fri, 13 May 2022 08:24:24 GMT, Jatin Bhateja wrote:
>> src/hotspot/share/opto/c2compiler.cpp line 521:
>>
>>> 519: if (!Matcher::match_rule_supported(Op_SignumF)) return false;
>>> 520: break;
>>> 521: case vmIntrinsics::_VectorComExp:
>>
>> Why `_VectorComExp` intrinsic is special
On Fri, 13 May 2022 08:24:21 GMT, Jatin Bhateja wrote:
> LUT should be generated only if UsePopCountInsturction is false
Should there be `!UsePopCountInsturction` check then?
> restrict the scope of flag to only scalar popcount operation
Interesting. But AArch64 code does cover vector cases w
On Wed, 20 Apr 2022 16:14:42 GMT, XenoAmess wrote:
>> Need to add apiNote documentation section to capacity-based constructors
>> like for maps.
>
>> Need to add apiNote documentation section to capacity-based constructors
>> like for maps.
>
> @liach done.
@XenoAmess oops, sorry for the dela
On Thu, 12 May 2022 07:59:36 GMT, John Hendrikx wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
javac and javadoc changes look OK
test/langto
The copyright year of
src/java.base/share/classes/jdk/internal/vm/FillerObject.java should be 2022.
-
Commit messages:
- [PATCH] 8286462: The copyright year of
src/java.base/share/classes/jdk/internal/vm/FillerObject.java should be 2022
Changes: https://git.openjdk.java.net/jdk/pu
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev
wrote:
> - It is not possible to support native JDK commands such as "java" inside Mac
> App Store bundles due to embedded info.plist. Workarounds suggested in
> JDK-8286122 does not seems to be visible.
> - With proposed fix we will enforce
On Wed, 20 Apr 2022 15:37:13 GMT, Shruthi wrote:
> Removing the Duplicate keys present in XSLTErrorResources.java and
> XPATHErrorResources.java
>
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
This pull request has now been integrated.
Changeset: b5a3d284
Aut
On Tue, 17 May 2022 06:18:25 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use stringStream to simplify controller path assembly
>
> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92:
>
>>
On Wed, 18 May 2022 18:09:54 GMT, Severin Gehwolf wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92:
>>
>>> 90: }
>>> 91: ss.print_raw(_root, last_matching_slash_pos);
>>> 92: _path = os::strdup(ss.base());
>>
>> Do you mean `Find the longest commo
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
> substring match for the cgroupv1 file paths was based on the fact
This patch is a batch naming cleanup for the foreign linker implementation.
The naming changes are as follows:
- ProgrammableInvoker -> DowncallLinker
- ProgrammableUpcallHandler -> UpcallLinker
- 'native invoker' -> 'downcall stub'
- 'optimzed entry blob' -> 'upcall stub'
- OptimizedEn
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
--
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/j
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
This is to incorporate the latest language subtag registry definition (version
2022-03-02) into JDK19.
-
Commit messages:
- LSR 2022-03-02
- LSR 2021-12-29
- LSR 2021-08-06
- LSR 2021-07-21
Changes: https://git.openjdk.java.net/jdk/pull/8776/files
Webrev: https://webrevs.openjd
A new API to execute kinit.
-
Commit messages:
- 8286969: Add a new test library API to execute kinit in SecurityTools.java
Changes: https://git.openjdk.java.net/jdk/pull/8775/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8775&range=00
Issue: https://bugs.openjdk.ja
On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote:
> This patch backs out the changes made by
> [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and
> [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there
> are failures due to div nodes floating above it
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
LGTM for i18n changes.
-
Marked as reviewed by naoto (Reviewer).
PR: https
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as revi
On Thu, 12 May 2022 17:17:37 GMT, Jorn Vernee wrote:
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
> ad
On Wed, 4 May 2022 23:16:41 GMT, Vladimir Kozlov wrote:
>> src/hotspot/cpu/x86/x86_64.ad line 6998:
>>
>>> 6996: ins_encode %{
>>> 6997: __ cmovl(Assembler::parity, $dst$$Register, $src$$Register);
>>> 6998: __ cmovl(Assembler::notEqual, $dst$$Register, $src$$Register);
>>
>> Should t
This patch backs out the changes made by
[JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and
[JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there are
failures due to div nodes floating above its validity checks.
Thanks.
-
Commit messages:
-
On Wed, 18 May 2022 15:05:26 GMT, Jorn Vernee wrote:
>> It's not quite that simple since a binding recipe for a single parameter can
>> have multiple VMStores for instance if a struct is decomposed into multiple
>> values.
>>
>> It can be done by pulling the binding loops up to the `specialize
On Wed, 18 May 2022 11:27:24 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Looked at
-java.security.jgss.
LGTM
--
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Looked at
- java.base/.../sun/security
- jdk.crypto.*
- test/*/com/sun/crypto/provider
On Wed, 18 May 2022 14:51:02 GMT, Jorn Vernee wrote:
>> I wasn't suggesting to add more bindings. I was more suggesting to filter
>> out the load/store from the set of bindings (since these are virtualized
>> anyways) that are passed to `doBindings`. Then, before executing a set of
>> bindings
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Wed, 4 May 2022 01:59:17 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch optimises the matching rules for floating-point comparison with
> respects to eq/ne on x86-64
>
> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
> is always set, so we don't need `cmpOpUCF2`
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
> Hi,
>
> This patch optimises the matching rules for floating-point comparison with
> respects to eq/ne on x86-64
>
> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
> is always set, so we don't need `cmpOpUCF2` for the eq/ne cases, which
> improves the sequence of
On Wed, 18 May 2022 14:21:55 GMT, Maurizio Cimadamore
wrote:
>> I'm not sure if there is anything actionable here?
>>
>> I've thought in the past that it might be nice to have
>> `GetArgument`/`SetArgument` and `GetReturnValue`/`SetReturnValue` binding
>> operators as well, to make the inputs
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
It's the last issue in the series, and it still touches different areas of the
code.
-
Commit messages:
- 8284209: Replace remaining usages of 'the a' in source code
- 8284209: Replac
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is null-hostile
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
Hi,
so your suggestion is that String::coder would be ASCII if all
codepoints are 0-127, then LATIN1 if it contains at least one char in
the 128-255 range, otherwise UTF16? As you say this would mean we could
skip scanning StringCoding::hasNegatives scans and similar overheads
when converting kno
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net
On Wed, 18 May 2022 11:23:07 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 336:
>>
>>> 334:
>>> 335: if (callingSequence.forUpcall()) {
>>> 336: // for upcalls, recipes have a result, which we handle
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
I tried to avoid changing external libraries, there are quite a few such typos.
Let me know if I should revert any files.
-
Commit messages:
- 8284213: Replace usages of 'the a' in xml
On Wed, 18 May 2022 11:27:24 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Wed, 18 May 2022 11:27:24 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
Also, I fixed a couple of spelling mistakes.
-
Commit messages:
- 8284191: Replace usages of 'the an' in hotspot and java.base
- 8284191: Replace usages of 'the an' in hotspot and java
On Wed, 18 May 2022 11:10:58 GMT, Aleksey Shipilev wrote:
> It would be beneficial to bring over the Loom-specific test groups from the
> loom repo to aid development/porting work.
>
> https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108
> https://github.com/openjdk/loom/bl
After the introduction of compact strings in Java 9, the current String may
store byte arrays encoded as Latin1 or UTF-16.
Here's a troublesome thing: Latin1 is not compatible with UTF-8. Not all
Latin1 byte strings are legal UTF-8 byte strings:
They are only compatible within the ASCII range, when
On Tue, 17 May 2022 10:19:04 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequence.java
>> line 109:
>>
>>> 107: * @return the caller method type.
>>> 108: */
>>> 109: public MethodType callerMethodType() {
>>
>> Would it make sense to ei
On Tue, 17 May 2022 08:41:59 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Bin
On Tue, 17 May 2022 11:18:20 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 943:
>>
>>> 941: Z, B, S, C, I, J, F, D, L;
>>> 942:
>>> 943: static BasicType of(Class cls) {
>>
>> This seems a duplication of ASM Typ
On Tue, 17 May 2022 06:00:37 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecia
On Tue, 17 May 2022 10:08:00 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 131:
>>
>>> 129: private int[] scopeSlots;
>>> 130: private int curScopeLocalIdx = -1;
>>> 131: private int RETURN_ALLOCATOR_IDX = -1;
>>
>>
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
> adds freeing of downcall stubs, since those changes were
It would be beneficial to bring over the Loom-specific test groups from the
loom repo to aid development/porting work.
https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108
https://github.com/openjdk/loom/blob/6f42923b3342e41d95b262733205283068802b40/test/hotspot/jtreg/TEST.gr
On Wed, 18 May 2022 07:40:43 GMT, Thomas Stuefe wrote:
>> src/java.base/share/native/libjli/java.c line 1631:
>>
>>> 1629: const char *arg = jargv[i];
>>> 1630: if (arg[0] == '-' && arg[1] == 'J') {
>>> 1631: assert(arg[2] != '\0' && "Invalid JAVA_ARGS or
>>> EXTRA_J
On Tue, 17 May 2022 16:22:15 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Fri, 25 Mar 2022 13:48:20 GMT, Jorn Vernee wrote:
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As
On Mon, 16 May 2022 15:29:38 GMT, Сергей Цыпанов wrote:
>> Even in the no exceptions case, the `exceptionTypes` array still has to be
>> allocated/copied by `Method.getExceptionTypes()`[^1] when the `ProxyMethod`
>> constructor[^2] is invoked.
>>
>> So if anything, the `List.of(…)` call should
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is null-hostile
On Wed, 18 May 2022 06:12:41 GMT, David Holmes wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
67 matches
Mail list logo
