On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
@stuart-marks Mind review this simple cleanup?
-
PR: https://git.openjdk.java.net/jdk/pull/8179
On Wed, 18 May 2022 06:30:34 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source launche
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan
On Fri, 20 May 2022 22:22:43 GMT, Sandhya Viswanathan
wrote:
>> I see that you swapped `src, dst` in `match()` but `format` is sill
>> incorrect and the code is confusing.
>
> I agree with @vnkozlov that this needs explanation. Could you please add
> comments here with IR and example code gene
Sync improved in test
-
Commit messages:
- 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails
with Xcomp
Changes: https://git.openjdk.java.net/jdk/pull/8821/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8821&range=00
Issue: https://bugs.op
On Wed, 4 May 2022 23:16:41 GMT, Vladimir Kozlov wrote:
>> src/hotspot/cpu/x86/x86_64.ad line 6998:
>>
>>> 6996: ins_encode %{
>>> 6997: __ cmovl(Assembler::parity, $dst$$Register, $src$$Register);
>>> 6998: __ cmovl(Assembler::notEqual, $dst$$Register, $src$$Register);
>>
>> Should t
On Fri, 20 May 2022 20:02:28 GMT, Roger Riggs wrote:
>> liach has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Convert PrimitiveTypeInfo to an enum
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 932:
>
>> 930:
> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace the
> hash map with a simple lookup, similar to what's done in
> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
liach has updated the pull request incrementally with one additional commit
since
On Wed, 18 May 2022 14:59:33 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch optimises the matching rules for floating-point comparison with
>> respects to eq/ne on x86-64
>>
>> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
>> is always set, so we don't need `cm
On Sun, 15 May 2022 14:17:41 GMT, Piotr Tarsa wrote:
>> iaroslavski has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)
>>
>> * Improved mixed insertion sort
>> * Optimized i
On Wed, 20 Apr 2022 16:52:31 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add documents
src/ja
On Fri, 20 May 2022 04:55:37 GMT, liach wrote:
> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace the
> hash map with a simple lookup, similar to what's done in
> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
src/java.base/share/classes/java/l
On Fri, 20 May 2022 18:22:47 GMT, liach wrote:
>> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
>> `Class.forName(String)`. `make test
>> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
>> `LazyInitializationTest` failing the eager initialization c
On Tue, 17 May 2022 23:40:04 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incr
On Tue, 17 May 2022 23:40:04 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incr
On Fri, 20 May 2022 11:51:09 GMT, ExE Boss wrote:
>> liach has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> remove unused field
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 608:
>
>> 606: mv.visitMet
> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
> `Class.forName(String)`. `make test
> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
> `LazyInitializationTest` failing the eager initialization check on the
> baseline and passing with this patch.
On Wed, 18 May 2022 06:30:34 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source launche
On Wed, 20 Apr 2022 16:36:16 GMT, XenoAmess wrote:
>>> no, we use other way, but yes for we take care of thread safety.
>>
>> Fair enough.
>>
>>> Don't think it necessary... I think making it cannot touched by other
>>> object (with security manager on) is enough.
>>
>> I was thinking more fo
On Sat, 30 Apr 2022 17:00:03 GMT, Andrey Turbanov wrote:
> Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use
> single call `HashMap.getOrDefault`.
> It's faster and clearer.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/
On Sat, 30 Apr 2022 17:00:03 GMT, Andrey Turbanov wrote:
> Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use
> single call `HashMap.getOrDefault`.
> It's faster and clearer.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/p
On Fri, 20 May 2022 04:06:19 GMT, liach wrote:
>> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
>> `Class.forName(String)`. `make test
>> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
>> `LazyInitializationTest` failing the eager initialization c
On Fri, 20 May 2022 10:57:44 GMT, Jorn Vernee wrote:
>> This patch is a batch naming cleanup for the foreign linker implementation.
>>
>> The naming changes are as follows:
>>
>> - ProgrammableInvoker -> DowncallLinker
>> - ProgrammableUpcallHandler -> UpcallLinker
>> - 'native invoker' -
On Fri, 20 May 2022 09:51:24 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> Patch adds the planned support for new vector operations and APIs targeted
>> for [JEP 426: Vector API (Fourth
>> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>>
>> Following is the brief summary of chan
On Wed, 18 May 2022 16:54:06 GMT, Jorn Vernee wrote:
> This patch is a batch naming cleanup for the foreign linker implementation.
>
> The naming changes are as follows:
>
> - ProgrammableInvoker -> DowncallLinker
> - ProgrammableUpcallHandler -> UpcallLinker
> - 'native invoker' -> 'down
> This patch is a batch naming cleanup for the foreign linker implementation.
>
> The naming changes are as follows:
>
> - ProgrammableInvoker -> DowncallLinker
> - ProgrammableUpcallHandler -> UpcallLinker
> - 'native invoker' -> 'downcall stub'
> - 'optimzed entry blob' -> 'upcall stub'
On Fri, 20 May 2022 10:36:17 GMT, Maurizio Cimadamore
wrote:
>> This patch is a batch naming cleanup for the foreign linker implementation.
>>
>> The naming changes are as follows:
>>
>> - ProgrammableInvoker -> DowncallLinker
>> - ProgrammableUpcallHandler -> UpcallLinker
>> - 'native i
On Wed, 18 May 2022 16:54:06 GMT, Jorn Vernee wrote:
> This patch is a batch naming cleanup for the foreign linker implementation.
>
> The naming changes are as follows:
>
> - ProgrammableInvoker -> DowncallLinker
> - ProgrammableUpcallHandler -> UpcallLinker
> - 'native invoker' -> 'down
On Fri, 20 May 2022 09:51:24 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> Patch adds the planned support for new vector operations and APIs targeted
>> for [JEP 426: Vector API (Fourth
>> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>>
>> Following is the brief summary of chan
On Thu, 19 May 2022 21:19:49 GMT, Paul Sandoz wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - 8284960: Chan
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
>
> 1) Extends the scope of existing lanewise API for fo
On Sun, 15 May 2022 12:47:10 GMT, Andrey Turbanov wrote:
> They are unused and leftover since JDK 7. It's good to remove them.
This pull request has now been integrated.
Changeset: 4587337e
Author:Andrey Turbanov
URL:
https://git.openjdk.java.net/jdk/commit/4587337e956ed6f1a59e9d98
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Build changes look good. Thanks for the cleanu
Following the logic from the comment directly above the changed line, since it
doesn't matter which controller we pick, pick any available controller instead
of the one called "memory" specifically. This way we are guarded against
getting `null` as `anyController`, which is being immediately pas
On Thu, 19 May 2022 10:47:23 GMT, Claes Redestad wrote:
> The current short and byte mixers and prependers simply delegate to the int
> variants. At the LambdaForm level the values has already been implicitly cast
> to int, so removing this indirection and directly adapting to call the
> int-b
On Sat, 30 Apr 2022 17:00:03 GMT, Andrey Turbanov wrote:
> Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use
> single call `HashMap.getOrDefault`.
> It's faster and clearer.
Marked as reviewed by redestad (Reviewer).
-
PR: https://git.openjdk.java.net/jd
On Wed, 18 May 2022 02:03:34 GMT, Mandy Chung wrote:
>Do you know why there are test failures (they look unrelated)?
All failed tests seems Loom-integration related. They fail only x86. Seems they
are fixed in master under [JDK-8286476
](https://bugs.openjdk.java.net/browse/JDK-8286476)
-
39 matches
Mail list logo
