On Fri, 20 May 2022 08:34:58 GMT, Maxim Kartashev
wrote:
> Following the logic from the comment directly above the changed line, since
> it doesn't matter which controller we pick, pick any available controller
> instead of the one called "memory" specifically. This way we are guarded
> again
On Thu, 26 May 2022 16:04:17 GMT, Maxim Kartashev
wrote:
>> Following the logic from the comment directly above the changed line, since
>> it doesn't matter which controller we pick, pick any available controller
>> instead of the one called "memory" specifically. This way we are guarded
>> a
On Mon, 30 May 2022 00:10:50 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> i
On Sat, 28 May 2022 03:31:30 GMT, Yasumasa Suenaga wrote:
> We found using `0` as `NULL` in java_md_common.c . `0` is not a pointer, so
> we should use `NULL` where we want to handle it.
>
> https://github.com/openjdk/jdk/pull/8646#discussion_r882294076
>
> Also I found using `0` as NUL char i
On Sun, 29 May 2022 18:15:52 GMT, Sergey Kuksenko wrote:
> 5. skip() is not implemented, when not-so-trivial implementation is possible
> (9 classes):
For the low-level streams (e.g. connected to socket) then it would be common to
see them wrapped by buffered streams. So it might not be worth
On Fri, 13 May 2022 01:35:40 GMT, Xiaohong Gong wrote:
>> Checking whether the indexes of masked lanes are inside of the valid memory
>> boundary is necessary for masked vector memory access. However, this could
>> be saved if the given offset is inside of the vector range that could make
>> s
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Sun, 29 May 2022 18:23:03 GMT, Sergey Kuksenko wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> invert if; refine javadoc.
>
> Another InputStreams cleaning direction.
>
> Many InputStream subclasses have read(byte
On Tue, 24 May 2022 20:40:51 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> invert if; refine jav
On Tue, 24 May 2022 20:40:51 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> invert if; refine jav
On Thu, 26 May 2022 15:43:57 GMT, XenoAmess wrote:
> > Is there any practical scenario where the current code (skip buffer
> > allocation on each invocation) creates issues?
>
> @kuksenko Not found any yet :)
In that case, what is the value of this PR? Do we need a code change for the
sake of
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
This pull request has now been integrated.
Changeset: 3d2d0395
Author:Anthony Vanelverdinghe
Committer: Jaikiran Pai
URL:
`String.contains` was introduced in Java 5.
Some code in java.naming still uses old approach with `String.indexOf` to check
if String contains specified substring.
I propose to migrate such usages. Makes code shorter and easier to read.
-
Commit messages:
- [PATCH] Use String.contai
14 matches
Mail list logo
