Re: RFR: JDK-8173094, 8173751, 8173752, 8173755, 8173802

underlying output stream with the single * argument b. You're gone over 80 chars in length here. You can bring a word or two down to the last line. Do you want me to push this change for you? Regards, Sean. On 10/02/17 19:18, Abhijit Roy wrote: Hi Sean, As per your suggestion, I

Re: RFR: JDK-8173094 Error in API documentation for SwingWorker

, Seán Coffey wrote: Hi Abhijit, you'll need to correct the Copyright year format in your edits. It needs to be "Copyright (c) , , Oracle..." format. For the ZipFile change, you need to use lower case 's' in @since. Looks good otherwise. regards, Sean. On 10/02/17 10:51, Abhijit Ro

RFR: JDK-8173094 Error in API documentation for SwingWorker

Hi all, Please review the java doc fix for the below Bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8173094 Description: Error in API documentation for SwingWorker Webrev-http://cr.openjdk.java.net/~rpatil/ababroy/8173094/webrev.00/ I have addressed some other doc issues which I

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

, Ivan Gerasimov wrote: Hi Abhijt! As you're changing the description of 'F' pattern in DateTimeFormatterBuilder, it makes sense to do the same in DateTimeFormatter. With kind regards, Ivan On 21.12.2016 9:30, Abhijit Roy wrote: Hi Roger, I have fixed the same error in DateTimeFormatterBuiler

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

7:16 AM, Ivan Gerasimov wrote: Hi Abhijt! As you're changing the description of 'F' pattern in DateTimeFormatterBuilder, it makes sense to do the same in DateTimeFormatter. With kind regards, Ivan On 21.12.2016 9:30, Abhijit Roy wrote: Hi Roger, I have fixed the same error

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

/2016 9:28 AM, Roger Riggs wrote: Hi Abhijit, Please also fix the same error in DateTimeFormatter; line 300. I would use '24' as the example of the hour of day. It would emphasize that the range is 1-24. Roger On 12/16/2016 6:19 AM, Abhijit Roy wrote: Hi all, Please review the java doc fix

RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

Hi all, Please review the java doc fix for the below bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8171348 Description: Incorrect documentation for DateTimeFormatter letter 'k' Webrev: http://cr.openjdk.java.net/~rpatil/8171348/webrev.00/ I have just rectified and modified those

RFR: JDK-8164923, JDK-8170566, JDK-8169482, JDK-8170653

Hi all, Please review the java doc fixes for the below bugs: Bug: https://bugs.openjdk.java.net/browse/JDK-8164923 Description: Error in the documentation for java.lang.Random Webrev: http://cr.openjdk.java.net/%7Erpatil/8164923/webrev.00/ Bug :

Review request for JDK-8163266 : Doc for ValidationEvent#getSeverity()

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8163266 Bug - Doc for ValidationEvent#getSeverity() should say it returns a constant from ValidationEvent instead of ValidationError Webrev - http://cr.openjdk.java.net/~ntv/ababroy/8163266/webrev.00/

RE: https://bugs.openjdk.java.net/browse/JI-9032379

Hi All, It was a mistake from my end. Please ignore it. Thanks, Abhijit From: Abhijit Roy Sent: Friday, April 01, 2016 02:35 PM To: core-libs-dev@openjdk.java.net Subject: https://bugs.openjdk.java.net/browse/JI-9032379 Hi, Need some suggestion for this issue (2nd part

https://bugs.openjdk.java.net/browse/JI-9032379

Hi, Need some suggestion for this issue (2nd part). Thanks Abhijit

Review request for JDK-8151065 : Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit)

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151868 Bug - Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit) Webrev - http://cr.openjdk.java.net/~ntv/abhijit/webrev.00/ I have just rectified and modified those error.

RE: Review request for JDK-8151063 : Typo in java.lang.invoke.StringConcatFactory

P.S. Use Nagle's algorithm :-) > > -- > -- [1] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039429 > .html > >> On 11 Mar 2016, at 08:33, Abhijit Roy <abhijit.r@oracle.com> wrote: >> >> Hi all, >> >> >>

RE: Review request for JDK-8151065 : Typo in javax.naming.CompoundName

Hi Vincent, It'll be great if Pavel can do this for me. Thanks Abhijit -Original Message- From: Vincent Ryan Sent: Friday, March 11, 2016 5:14 PM To: Abhijit Roy Cc: Pavel Rappo; core-libs-dev Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName Your fix

RE: Review request for JDK-8151065 : Typo in javax.naming.CompoundName

To: Abhijit Roy Cc: core-libs-dev; Vincent Ryan Subject: Re: Review request for JDK-8151065 : Typo in javax.naming.CompoundName Hi Abhijit, Looks good. (Disclaimer: I'm not a "Reviewer".) Are you going to update this in JDK 8 or in JDK 9, or both? The reason I'm asking is that the bug states

Review request for JDK-8151063 : Typo in java.lang.invoke.StringConcatFactory

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151063 Bug - Typo in java.lang.invoke.StringConcatFactory Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151063/webrev.00/ I have rectified error and updated that one. And moving forward it for

Review request for JDK-8151062 : Unclosed parenthesis in java.util.EnumMap.clone() Javadoc

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151062 Bug - Unclosed parenthesis in java.util.EnumMap.clone() Javadoc Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151062/webrev.00/ I have just rectified and closed the corresponding

Review request for JDK-8151065 : Typo in javax.naming.CompoundName

Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151065 Bug - Typo in javax.naming.CompoundName Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151065/webrev.00/ I have just rectified and modified those error. And moving forward it for review.

Review request for JDK-8145545 : Typos in Javadoc of XmlAdapter

Hi all,  Please review a fix for Bug  - https://bugs.openjdk.java.net/browse/JDK-8145545  Bug - Typos in Javadoc of XmlAdapter Webrev - http://cr.openjdk.java.net/~ntv/ababroy/8145545/webrev.00/  I have just rectified and modified those error. And moving forward it for review.