[verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

Please review these changes: bug: https://bugs.openjdk.java.net/browse/JDK-8139986 Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986/ Background: These changes introduce a new system property named "jdk.debug" intended to identify the type of the build. The build system has already been

Re: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

Thanks Magnus! Alejandro On 11/3/2015 12:24 PM, Magnus Ihse Bursie wrote: Hi Alejandro, On 2015-11-03 18:45, Alejandro E Murillo wrote: Please review these changes: bug: https://bugs.openjdk.java.net/browse/JDK-8139986 Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986/ Looks good

Re: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

On 11/3/2015 3:42 PM, Daniel D. Daugherty wrote: On 11/3/15 10:45 AM, Alejandro E Murillo wrote: Please review these changes: bug: https://bugs.openjdk.java.net/browse/JDK-8139986 Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986/ jdk/src/java.base/share/classes/sun/misc

Re: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

Thanks David! Alejandro On 11/3/2015 8:52 PM, David Holmes wrote: Looks good to me! Thanks, David On 4/11/2015 3:45 AM, Alejandro E Murillo wrote: Please review these changes: bug: https://bugs.openjdk.java.net/browse/JDK-8139986 Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986

Re: [verona.stage] RFR 8087203: Adapt Version.java.template to the JEP-223 new version string format

Thanks Iris Alejandro On 9/17/2015 4:17 PM, Iris Clark wrote: Hi, Alejandro. This cleanup looks good to me. Thanks, iris (not a JDK 9 Reviewer) -Original Message- From: Alejandro E Murillo Sent: Wednesday, September 16, 2015 11:04 AM To: core-libs-dev@openjdk.java.net Cc: verona

Re: [verona.stage] RFR 8134365: Test test/sun/misc/Version/Version.java should follow Verona rules for trailing zeros

On 9/16/2015 6:44 PM, Mandy Chung wrote: On Sep 16, 2015, at 11:23 AM, Alejandro E Murillo <alejandro.muri...@oracle.com> wrote: Please review this change: Bug: https://bugs.openjdk.java.net/browse/JDK-8134365 Webrev: http://cr.openjdk.java.net/~amurillo/9/8134365/ This change mo

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

related code in jaxp. As Alan pointed out, it would be some clean-up. Thanks, Joe On 6/19/2015 9:53 AM, Alejandro E Murillo wrote: Hi Alan, just to you. didn't hear back from you, so I'll assume you are fine with the corrections. We want to get this into further testing so I'm going to push

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Hi Alan, just to you. didn't hear back from you, so I'll assume you are fine with the corrections. We want to get this into further testing so I'm going to push the changes cheers Alejandro On 6/18/2015 4:56 PM, Alejandro E Murillo wrote: Thanks Alan, see below On 6/18/2015 7:41 AM, Alan

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Hi David, thanks for the review, see below On 6/18/2015 1:40 AM, David Holmes wrote: Hi Alejandro, I looked at the hotspot and JDK changes. On 17/06/2015 8:55 AM, Alejandro E Murillo wrote: Please review these changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8087202 Webrev: http

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Thanks Alan, see below On 6/18/2015 7:41 AM, Alan Bateman wrote: On 16/06/2015 23:55, Alejandro E Murillo wrote: Please review these changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8087202 Webrev: http://cr.openjdk.java.net/~amurillo/9/8087202 The implementation

[verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Please review these changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8087202 Webrev: http://cr.openjdk.java.net/~amurillo/9/8087202 These are intended to: (1) Add support for the patch field of the new version string format (2) Remove unused fields remaining from the old version

Re: RFR: JDK-8085822 JEP 223: New Version-String Scheme (initial integration)

On 6/10/2015 6:13 AM, Magnus Ihse Bursie wrote: On 2015-06-10 11:58, David Holmes wrote: Hi Magnus, Generally looks good - a few comments/queries below. In general, I believe most issues you found are valid. :-) However, as I said before in this thread, I'd like to see them resolved in the

Re: JDK 9 RFR of JDK-8075551: Add tiered testing definitions to the jaxp repo

On 6/1/2015 6:15 PM, huizhe wang wrote: On 6/1/2015 3:16 PM, joe darcy wrote: Hello, Please review these changes to regularize the jaxp regression testing infrastructure with the JDK tiered testing policy. [1] JDK-8075551: Add tiered testing definitions to the jaxp repo

Re: Build failures on solaris

Definitively a P1. This is also blocking this week hotspot snapshot: http://prt-web.us.oracle.com//archive/2014/05/2014-05-09-174238.amurillo.jdk9-hs-2014-05-09-jdk9-dev-control/logs/solaris_sparcv9_5.10-fastdebug.log.FAILED.log please fix ASAP Thanks Alejandro On 5/9/2014 12:16 PM, Eric

Re: Build failures on solaris

we need is someone with Reviewer/committer rights to step in and apply it. On 05/09/14 14:48, Alejandro E Murillo wrote: Definitively a P1. This is also blocking this week hotspot snapshot: http://prt-web.us.oracle.com//archive/2014/05/2014-05-09-174238.amurillo.jdk9-hs-2014-05-09-jdk9-dev

Re: Urgent: Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

what's wrong with pushing them to jdk9/hs-rt? We did this a couple of weeks ago with Erik (Gahlin) changes, it might disrupt nightly, as we still do not have the JPRT changes in place, but that was the agreement we have for jdk9: tightly coupled changes should be pushed through the hotspot