On Mon, 29 Mar 2021 21:09:56 GMT, Alex Blewitt
wrote:
> 8264397: Use the blessed modifier order in jdk.incubator.foreign
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/3253
On Tue, 30 Mar 2021 21:26:34 GMT, Alex Blewitt
wrote:
>> Hi @alblue, thanks for the contribution. We will make sure to integrate this
>> at some point, but I don't think now is the right moment to do this kind of
>> stylistic changes to the API/implementation. If yo
On Tue, 30 Mar 2021 11:48:36 GMT, Maurizio Cimadamore
wrote:
>> Happy to submit a fix elsewhere if that's the right thing to do?
>
> Hi @alblue, thanks for the contribution. We will make sure to integrate this
> at some point, but I don't think now is the right moment to do this kind of
> styl
On Mon, 29 Mar 2021 23:54:19 GMT, Claes Redestad wrote:
>> 8264397: Use the blessed modifier order in jdk.incubator.foreign
>
> This one should probably be fixed in the upstream repo over at
> https://github.com/openjdk/panama-foreign (I believe). /ping @JornVernee
> @mcimadamore
Happy to subm
8264397: Use the blessed modifier order in jdk.incubator.foreign
-
Commit messages:
- 8264397: Use the blessed modifier order in jdk.incubator.foreign
Changes: https://git.openjdk.java.net/jdk/pull/3253/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3253&range=00
Iss
On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt
wrote:
> 8264332: Use the blessed modifier order in jdk.charsets
This pull request has now been integrated.
Changeset: 364cce14
Author: Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/364cc
On Sun, 28 Mar 2021 13:53:27 GMT, Alex Blewitt
wrote:
> 8264334: Use the blessed modifier order in jdk.jpackage
This pull request has now been integrated.
Changeset: 30b4b17c
Author: Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/30b4b
8264334: Use the blessed modifier order in jdk.jpackage
-
Commit messages:
- 8264334: Use the blessed modifier order in jdk.jpackage
Changes: https://git.openjdk.java.net/jdk/pull/3234/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3234&range=00
Issue: https://bugs.o
On Tue, 23 Mar 2021 21:41:32 GMT, Alex Blewitt
wrote:
> 8264091: Use the blessed modifier order in java.logging
This pull request has now been integrated.
Changeset: 45e1bab8
Author: Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/45e1b
On Wed, 24 Mar 2021 02:00:28 GMT, Iris Clark wrote:
>> 8264091: Use the blessed modifier order in java.logging
>
> Marked as reviewed by iris (Reviewer).
>
> On 24 Mar 2021, at 02:00, Iris Clark ***@***.***> wrote:
>
>
> @irisclark approved this pull request.
>
> —
> You are receiving this
8264091: Use the blessed modifier order in java.logging
-
Commit messages:
- 8264091: Use the blessed modifier order in java.logging
Changes: https://git.openjdk.java.net/jdk/pull/3163/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3163&range=00
Issue: https://bugs.o
On Tue, 23 Mar 2021 17:19:10 GMT, Joe Wang wrote:
>> The JDK's copy of the xalan and xerces code has diverged significantly from
>> upstream so maybe this change is okay, Joe Wang can say.
>
> Hi Alex, thanks for looking into this. As Alan mentioned, these code came
> from Apache, while we've
On Fri, 19 Mar 2021 16:17:40 GMT, Alex Blewitt
wrote:
> As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the
> blessed modifier order.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/3091
On Fri, 19 Mar 2021 23:40:00 GMT, Alex Blewitt
wrote:
>> As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the
>> blessed modifier order.
>
> Would someone mind creating a bug for me under the parent bug JDK-8263854?
@shipilev would you mind creating a
On Fri, 19 Mar 2021 16:17:40 GMT, Alex Blewitt
wrote:
> As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the
> blessed modifier order.
Would someone mind creating a bug for me under the parent bug JDK-8263854?
-
PR: https://git.openjdk.java.net/jd
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the
blessed modifier order.
-
Commit messages:
- Reordered final static to static final
- Use the blessed modifier order in java.xml
Changes: https://git.openjdk.java.net/jdk/pull/3091/files
Webrev: https://
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
This pull request has now been integrated.
Changeset: 5262d95b
Author: Alex B
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
This pull request has no
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
This pull request has now been integra
Additional changes found in `java.base` of `final private` -> `private final`.
Filed with existing bug because it's the same module; can change to a different
bug number if required.
-
Commit messages:
- 8263658: Use the blessed modifier order in java.base
Changes: https://git.ope
Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa` packages.
@cl4es would you mind creating a subtask of JDK-8263854 so I can update the PR
title?
-
Commit messages:
- Use the blessed modifier order in java.sql/rowset/transation.xa
Changes: https://git.openjdk.j
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional
commit since the last revision:
Added more replacements of
On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad wrote:
>> Thanks @cl4es -- do I need to update the git commit message as well, or is
>> updating the title of the PR sufficient? I recall you suggesting not to do
>> amend/rebases previously.
>
> No, the git commit messages here doesn't matter, t
On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad wrote:
>> @cl4es would you mind creating a parent task of something like "Source code
>> cleanups" and then another sub task for this change please?
>
> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this
> along with an
On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt
wrote:
>> As with #2993 changing the order of `final static` to `static final` for the
>> `java.management`, `java.management.rmi` and `java.naming` modules.
>
> Would someone mind creating a bug for me? In addition, if it would
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Would someone mind creating a bug for me? In addition, if it would help, we
could
As with #2993 changing the order of `final static` to `static final` for the
`java.management`, `java.management.rmi` and `java.naming` modules.
-
Commit messages:
- Use the blessed modifier order in java.management/naming
Changes: https://git.openjdk.java.net/jdk/pull/3078/files
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes th
On Thu, 18 Mar 2021 17:03:28 GMT, Claes Redestad wrote:
>> If I have other fixes for different modules, should I file PRs with the same
>> bug number e.g. "8263658: Use the blessed modifier order in
>> java.logging/java.desktop" or should we have separate bug numbers for them?
>
>> If I have ot
On Thu, 18 Mar 2021 16:50:39 GMT, Claes Redestad wrote:
>> Is that there to indicate a placeholder value that was once used and is kept
>> for documentation purposes? Should the corresponding JavaDoc be removed as
>> well? Should I do this in the same commit/PR as this one, or submit a new
>>
ing.
>
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&resolved=false&rules=java%3AS1124
Alex Blewitt has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous co
On Thu, 18 Mar 2021 14:50:43 GMT, Claes Redestad wrote:
>> Sonar displays a warning message that modifiers should be declared in the
>> order listed in the JLS; specifically, that isntead of using `final static`
>> the `static final` should be preferred.
>>
>> This fixes the issues in the `jav
On Thu, 18 Mar 2021 15:08:09 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/com/sun/security/ntlm/NTLMException.java line 52:
>>
>>> 50: * from server.
>>> 51: */
>>> 52: //public static final int DOMAIN_UNMATCH = 3;
>>
>> Maybe this one ought to be removed instead?
>
Sonar displays a warning message that modifiers should be declared in the order
listed in the JLS; specifically, that isntead of using `final static` the
`static final` should be preferred.
This fixes the issues in the `java.base` package for ease of reviewing.
https://sonarcloud.io/project/iss
34 matches
Mail list logo
