RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi, Based on these maillist threads: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-March/065076.html https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-November/063643.html I am looking for comments and suggestions, whether the following change to JarURLConnection.getJarFi

Re: [11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

On 03/01/2020 02:26 PM, Alan Bateman wrote: On 01/03/2020 12:03, Alex Kashchenko wrote: Hi, Please review the fix to JDK-8232854 for 11u: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8232854 This issue has not been fixed in the main line (jdk/jdk) yet. It may be that the eventual fix

[11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

Hi, Please review the fix to JDK-8232854 for 11u: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8232854 Webrev: http://cr.openjdk.java.net/~akasko/jdk11u/8232854/webrev.00/ Patch is implemented based on a test code included with the Jira issue. It fixes the case, when URLClassLoader is

Re: RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

On 01/06/2020 10:54 AM, Aleksey Shipilev wrote: On 1/6/20 10:57 AM, Alex Kashchenko wrote: On 12/24/2019 11:54 AM, Alex Kashchenko wrote: On 12/24/2019 01:39 AM, Philip Race wrote: Have you verified this with VS 2017 ? Not that I can see a problem but I doubt we want to trade breaking 2017 to

Re: RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

On 12/24/2019 11:54 AM, Alex Kashchenko wrote: On 12/24/2019 01:39 AM, Philip Race wrote: Have you verified this with VS 2017 ? Not that I can see a problem but I doubt we want to trade breaking 2017 to fix 2013 ... Yes, VS 2017 compiles fine with this fix. [...] Bug: https

Re: RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

On 12/24/2019 01:39 AM, Philip Race wrote: Have you verified this with VS 2017 ? Not that I can see a problem but I doubt we want to trade breaking 2017 to fix 2013 ... Yes, VS 2017 compiles fine with this fix. [...] -- -Alex

RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

Hi, Please review this minor change to jpackage, that is required for successful compilation with VS2013 toolchain: Bug: https://bugs.openjdk.java.net/browse/JDK-8236125 Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/ Some details on this problem: https://stackoverflow.com/a

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

Hi, On 09/18/2018 07:22 PM, Erik Joelsson wrote: Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-820

Re: JVM (1.8.0_91) crashes in Windows native code

Hi, On 06/24/2016 03:03 PM, Alex Kashchenko wrote: Hi Vinay, On 06/23/2016 06:56 PM, Vinay Purohit wrote: Hello, I'm not sure if this is the right forum for posting an issue we are experiencing with JRE 1.8.0_92. The JVM crashes in the Windows native code and generates a log

Re: JVM (1.8.0_91) crashes in Windows native code

Hi Vinay, On 06/23/2016 06:56 PM, Vinay Purohit wrote: Hello, I'm not sure if this is the right forum for posting an issue we are experiencing with JRE 1.8.0_92. The JVM crashes in the Windows native code and generates a log (see attachment, hs_err_pid15724.log), but not the usual stack-tr

Re: RFR: JDK-8133206 - Higher native memory usage caused by upgrade to zlib 1.2.8

Hi, On 11/10/2015 10:44 AM, Alex Kashchenko wrote: Please review the following fix to JDK-8133206: - bug: https://bugs.openjdk.java.net/browse/JDK-8133206 - webrev for jdk9: http://cr.openjdk.java.net/~akasko/jdk9/8133206/webrev.00/ This fix is a forward-port of the patch to jdk7u created

RFR: JDK-8133206 - Higher native memory usage caused by upgrade to zlib 1.2.8

Please review the following fix to JDK-8133206: - bug: https://bugs.openjdk.java.net/browse/JDK-8133206 - webrev for jdk9: http://cr.openjdk.java.net/~akasko/jdk9/8133206/webrev.00/ This fix is a forward-port of the patch to jdk7u created by Nikolay Gorshkov: - webrev for jdk7u: http://