On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
JDK-8238048 (fixed in jdk15) moved major_version, minor_version,
generic_signature_index and source_file_name_index from InstanceKlass to
ConstantPool.
We still have some incorrect code in CP merge during class redefinition.
rewrite_cp_refs(scratch_class) updates generic_signature_index and
sou
Changes:
- ClassFileReconstituter is updated to restore "MethodParameters" attribute;
- handling of the attribute in VM_RedefineClasses is moved to be consistent
with other code (like local variable table);
- copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to
/test/lib as it's u
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by amenkov (Reviewer).
-
PR: https:
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote:
> The fix adds "-XX:PerfMaxStringConstLength" argument running target app
> (default is 1024, 8K should be enough for any environments)
Ping.
Need 2nd reviewer
-
PR: https://git.openjdk.java.net/jdk/pull/5858
The fix adds "-XX:PerfMaxStringConstLength" argument running target app
(default is 1024, 8K should be enough for any environments)
-
Commit messages:
- JDK-8274930
Changes: https://git.openjdk.java.net/jdk/pull/5858/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5858
On Wed, 15 Sep 2021 07:12:25 GMT, Andrey Turbanov
wrote:
> 8274464: Remove redundant stream() call before forEach in java.* modules
Marked as reviewed by amenkov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5520
Updated AllModulesCommandTest to use dynamic port launching debuggee.
Parsing debuggee listening address functionality is required in several tests
(and we have other tests which need to be fixed the same way), so moved the
code to new class in jdk.test.lib
-
Commit messages:
- JDK
The test actually failed starting from jdk13, but the error is masked by
JDK-8264667 (and shell part of the test didn't verify result of the java
execution)
The fix:
- updates JvmtiClassFileReconstituter to add attributes in the same order as
javac does
- makes the test java instead of shell
- a
On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote:
> The test actually failed starting from jdk13, but the error is masked by
> JDK-8264667 (and shell part of the test didn't verify result of the java
> execution)
> The fix:
> - updates JvmtiClassFileReconstituter to a
The fix updates ResetPeakThreadCount.java test - increases number of threads,
but relaxes conditions so start/termination of system threads don't cause
failures.
Additional changes:
- store threads in a list instead of array (we need only to start/terminate
some number of threads, so linked list
JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
The fix un-problemlists RemovingUnixDomainSocketTest and changes serviceability
tests to use OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings instead
of stderrShouldBeEmptyIgnoreVMWarnings
-
Comm
On Thu, 28 Jan 2021 13:45:15 GMT, Zhengyu Gu wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment
>
> Sorry, I overlooked some of details. Final change looks fine to me.
On Tue, 19 Jan 2021 23:18:04 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Non-lava launchers should process all "-J" arguments
>
> Hi Alex,
>
On Fri, 15 Jan 2021 23:50:16 GMT, Alex Menkov wrote:
> The fix adds NMT handling for non-java launchers
This pull request has now been integrated.
Changeset: bdc305e1
Author: Alex Menkov
URL: https://git.openjdk.java.net/jdk/commit/bdc305e1
Stats: 30 lines in 2 files changed:
> The fix adds NMT handling for non-java launchers
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Updated comment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2106/files
- new: ht
On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes wrote:
> What do you mean by this? The -J args are not "translated" here but later in
> TranslateApplicationArgs.
I meant that they are translated in TranslateApplicationArgs. Looks like it's
not clear. Updated the comment as you suggested.
-
On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Non-lava launchers should process all "-J" arguments
>
> Alex,
>
> This
On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Non-lava launchers should process all "-J" arguments
>
> Alex,
>
> This
> The fix adds NMT handling for non-java launchers
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Non-lava launchers should process all "-J" arguments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pu
The fix adds NMT handling for non-java launchers
-
Commit messages:
- Handle NMT for non-java launchers
Changes: https://git.openjdk.java.net/jdk/pull/2106/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2106&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-82
On Fri, 15 Jan 2021 23:50:16 GMT, Alex Menkov wrote:
> The fix adds NMT handling for non-java launchers
Added serviceability as serviceability tools use launcher functionality
-
PR: https://git.openjdk.java.net/jdk/pull/2106
OperatingSystemMXBean was changed in jdk14 (see JDK-8226575):
New methods getTotalMemorySize and getFreeMemorySize were added, old
getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated.
The fix adds fallbacks for the values (i.e. if new methods fail, jconsole calls
old methods
Hi Igor,
LGTM.
--alex
On 06/10/2020 12:29, Igor Ignatyev wrote:
Hi Alex,
sure, here is the incremental diff, so now Error is thrown if bb arrays are
empty -- http://cr.openjdk.java.net/~iignatyev//8183040/webrev.0-1
Thanks,
-- Igor
On Jun 10, 2020, at 12:20 PM, Alex Menkov wrote:
Hi
went
completely wrong.
Yes, the test still fails in the case, but if I see
IndexOutOfBoundsException (or something similar) as a test failure
reason, my first thought that this is the test issue.
Could you please add the checks.
--alex
-- Igor
On Jun 9, 2020, at 6:36 PM, Alex Menkov wrote
Hi Igor,
In SATestUtils.java you do
var bb = ... Files.readAllBytes(...) ...
and then use bb[0]
if the file has 0 length, old code throws EOFException and new one will
throw IndexOutOfBoundsException.
And looks like the caller doesn't expect it (it catches IOException).
--alex
On 06/09/2020
+1
--alex
On 03/12/2020 13:53, Mandy Chung wrote:
This change looks okay.
Mandy
On 3/12/20 1:50 PM, Jonathan Gibbons wrote:
Please review a simple fix regarding the non-standard use of some CSS
in some doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags
Hi Igor,
Looks good.
--alex
On 09/07/2018 15:11, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html
327 lines changed: 13 ins; 270 del; 44 mod;
Hi all,
could you please review the patch which removes jdk.testlibrary.JDKToolFinder
and JDKToolLauncher a
28 matches
Mail list logo
