Re: a quick question about String

On 12/24/21 10:33 AM, Enrico Olivelli wrote: Alan, are you talking about the fact that you cannot "wrap" an existing byte[] that you know that you are already encoded ? In that case the main problem is that the String is supposed to be immutable and when you pass the byte[] it must be copied in

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

On Wed, 24 Mar 2021 16:31:20 GMT, Claes Redestad wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix style > > Looks good. The need to retain singleton/identity semantics of constants like > this when archivin

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28.08.2020 17:40, Alan Bateman wrote: On 28/08/2020 15:32, Alexander Scherbatiy wrote:   I run the java/nio/channels tests with the fix. There are five failed tests that fail with and without the fix:     java/nio/channels/DatagramChannel/AdaptorMulticasting.java java/nio/channels

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28.08.2020 15:55, Alan Bateman wrote: On 28/08/2020 12:25, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

t.java Thanks, Alexander. On 26.08.2020 13:42, Alan Bateman wrote: On 25/08/2020 18:00, Alexander Scherbatiy wrote: Hello, Could your review the fix for the issue:   Bug: https://bugs.openjdk.java.net/browse/JDK-8252248   Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/ : The fix has bee

RFR 8252248: __SIGRTMAX is not declared in musl libc

Hello, Could your review the fix for the issue:   Bug: https://bugs.openjdk.java.net/browse/JDK-8252248   Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/ Building JDK on Alpine Linux with musl libc gives the error: src/java.base/linux/native/libnet/linux_close.c:63:25: error: '__S

RFR: 8249612 Remove unused ISNANF and ISNAND from jdk_util_md.h

Hello, Could you review a simple clean up of jdk_util_md.h files:   Bug: https://bugs.openjdk.java.net/browse/JDK-8249612   Fix: http://cr.openjdk.java.net/~alexsch/8249612/webrev.00 JDK-8001334 [1] defines ISNANF and ISNAND in jdk_util_md.h. JDK-8199424 [2] removes ISNANF and ISNAND usage. ISNA

Re: jpackage with a single java property

is form fails:    --java-options -Dfoo="bar 2" Initially I can see no reason both form shouldn't work, so this looks like a bug to me. /Andy On 3/4/2020 5:20 AM, Alexander Scherbatiy wrote: Hello, CSR for JEP 343: Packaging Tool [1] has description for option value whic

jpackage with a single java property

Hello, CSR for JEP 343: Packaging Tool [1] has description for option value which consists of a list of strings: "If an option value is otherwise a list of strings, they must separated by space characters.  Since the shell would otherwise take them as separate  arguments, the list must be qu

Re: RFR: 8046485: Add missing @since tag under javax.swing.*

The fix looks good for me. Thanks, Alexandr. On 6/11/2014 4:00 AM, Henry Jen wrote: Hi, Please review a trivial webrev that provides missing @since tag for elements under javax.swing, Essentially it's simply add @since 1.2 for all classes/interfaces/exception that are missing @since

Re: RFR JDK 8: 8022190 Fix varargs lint warnings in the JDK

The fix looks good for me. Thanks, Alexandr. On 8/5/2013 5:04 AM, Joe Darcy wrote: Hello, Please review this fix for 8022190: Fix varargs lint warnings in the JDK http://cr.openjdk.java.net/~darcy/8022190.0/ Full patch below. While the @SafeVarargs annotation generally suppre