Re: RFR(XS) : 8180895 : java/security/AccessController/DoPrivAccompliceTest.java has to be improved

2017-05-26 Thread Artem Smotrakov
@summary doesn't seem to be correct, the test uses user.name system property. Otherwise, looks good for me. Artem On 05/23/2017 10:17 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html 81 lines changed: 37 ins; 23 del; 21 mod; Hi all, could you pl

[9] RFR: 8164159: java/nio/file/WatchService/UpdateInterference.java test leaves daemon threads

2016-08-16 Thread Artem Smotrakov
Hello, Please review the following patch for java/nio/file/WatchService/UpdateInterference.java test. The test creates a couple of daemon threads which have an infinite loop inside. When the test finishes, those daemon still keep running as long as jtreg use this instance of JVM to run other

Re: [9] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions

2016-05-20 Thread Artem Smotrakov
Hello, Could someone review this fix, please? http://cr.openjdk.java.net/~asmotrak/8152207/hotspot/webrev.01/ http://cr.openjdk.java.net/~asmotrak/8152207/jdk/webrev.00/ Artem On 05/10/2016 01:49 PM, Artem Smotrakov wrote: Hi Christian, Thank you for review. Here is updated webrev http

Re: [9] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions

2016-05-10 Thread Artem Smotrakov
Hi Christian, Thank you for review. Here is updated webrev http://cr.openjdk.java.net/~asmotrak/8152207/hotspot/webrev.01/ Artem On 05/09/2016 01:24 PM, Christian Thalinger wrote: On May 4, 2016, at 1:48 PM, Artem Smotrakov mailto:artem.smotra...@oracle.com>> wrote: Hello, Please

[9] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions

2016-05-04 Thread Artem Smotrakov
Hello, Please review two small patches for jdk and hotspot repos which add array bound checks to functions which return a length of bytecode instruction. Please see details in https://bugs.openjdk.java.net/browse/JDK-8152207 http://cr.openjdk.java.net/~asmotrak/8152207/jdk/webrev.00/ http://

[9] RFR: 8155859: Problem list tools/pack200/Pack200Props.java

2016-05-02 Thread Artem Smotrakov
Hello, tools/pack200/Pack200Props.java fails on multiple platforms. Please see details in https://bugs.openjdk.java.net/browse/JDK-8155857 Please review the following patch below which adds the test to ProblemList.txt Bug: https://bugs.openjdk.java.net/browse/JDK-8155859 diff -r 2bf84670f0

[9] RFR: 8146249: libjimage should use delete[] with new[]

2016-02-02 Thread Artem Smotrakov
Hello, Please review this small fix for jdk9/dev repo. It updates a couple of files in libjimage to use delete[] operator together with new[]. This fix is similar to https://bugs.openjdk.java.net/browse/JDK-8140649 Bug: https://bugs.openjdk.java.net/browse/JDK-8146249 Webrev: http://cr.openj

[9] RFR: 8140649: imageFile should use delete[] with new[]

2015-11-02 Thread Artem Smotrakov
Hello, Please review this small fix for jdk9/dev repo. It updates imageFile.cpp to use delete[] operator together with new[]. It also adds a check to ImageLocation::set_data(u1*) method to prevent a possible null-dereference. Bug: https://bugs.openjdk.java.net/browse/JDK-8140649 Webrev: htt

[9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-26 Thread Artem Smotrakov
Hello, Please review a couple of new tests for jarsigner's warnings. Basically tests run jarsigner and check warning/error messages and exit codes according to [1]. https://bugs.openjdk.java.net/browse/JDK-8049171 http://cr.openjdk.java.net/~asmotrak/8049171/webrev.00 [1] http://docs.oracle

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-26 Thread Artem Smotrakov
On 01/26/2015 11:11 AM, Wang Weijun wrote: JarUtils: You can break after line 83. Sure, I have updated the webrev http://cr.openjdk.java.net/~asmotrak/8049171/webrev.03/ Otherwise very good. Thanks for reviewing this. Thanks Max On Jan 26, 2015, at 15:55, Artem Smotrakov wrote: Hi

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-25 Thread Artem Smotrakov
Hi Max, Here is an updated webrev, please take a look. http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/ Artem On 01/26/2015 05:03 AM, Weijun Wang wrote: On 1/23/2015 16:12, Artem Smotrakov wrote: If the MANIFEST and the signature files must be at the beginning, should it be

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-23 Thread Artem Smotrakov
Hi Max, Please see inline. On 01/23/2015 05:18 AM, Wang Weijun wrote: I have updated the webrev, updateJar() method does the following: >- creates a new jar file (destJarFilename) >- puts files which are specified in files parameter to destJarFilename >- copies files from srcJarFilename to dest

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-22 Thread Artem Smotrakov
, at 14:35, Artem Smotrakov wrote: Hello, Please review a couple of new tests for jarsigner's warnings. Basically tests run jarsigner and check warning/error messages and exit codes according to [1]. https://bugs.openjdk.java.net/browse/JDK-8049171 http://cr.openjdk.java.net/~asmotrak/80