On Fri, 29 Jan 2021 05:53:57 GMT, Bo Zhang
wrote:
> Previously, `ImageBufferCache` contains a ThreadLocal field which holds
> strong reference to `ImageBufferCache$BufferReference.class`. When loaded
> from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
> in memory
Request for review, thanks!
> On 3 Feb 2021, at 09:29, Bo Zhang
> wrote:
>
>> Previously, `ImageBufferCache` contains a ThreadLocal field which holds
>> strong reference to `ImageBufferCache$BufferReference.class`. When loaded
>> from `jrt-fs.jar`, this will
ix replace the old `ImageBufferCache$BufferReference` class with
> `WeakReference`, which is verified by provided test.
Bo Zhang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous conten
Previously, `ImageBufferCache` contains a ThreadLocal field which holds
strong reference to `ImageBufferCache$BufferReference.class`. When loaded
from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
in memory forever and never being GCed.
The fix replace the old `ImageBufferCache$
Thanks Henry, this change looks good to me. I assume this patch will be
backported to 11GA, will it be back ported to 10 as well?
Regards,
Bo
> On 28 Sep 2018, at 00:49, Henry Jen wrote:
>
> Agree, please find updated webrev[1].
>
> [1] http://cr.openjdk.java.net/~henryjen/jdk/8210810/1/webre
Yes, that would be better. Please feel free to move it.
> On 27 Sep 2018, at 16:45, Alan Bateman wrote:
>
> On 27/09/2018 03:58, Henry Jen wrote:
>> Hi,
>>
>> Need a quick review of the webrev[1] for JDK-8210810[2], it’s pretty much
>> what Bo contributed, just add some trailing text “aaa\” to
l help you to push the fix. The only minor improvement I like to
> see is to verify content after the escape character, which I took the liberty
> to do it. Webrev coming soon.
>
> Cheers,
> Henry
>
>> On Sep 26, 2018, at 4:03 PM, Bo Zhang > <mailto:zhangbo...@gm
Can anyone please take a look?
Thank you.
> On 25 Sep 2018, at 14:27, Bo Zhang wrote:
>
> Hi all,
>
> This is my first time to try to submit a patch. Please forgive me if I did
> anything inappropriate. I’ve signed the OCA with the name “Bo Zhang”.
>
> Bug descript
Hi all,
This is my first time to try to submit a patch. Please forgive me if I did
anything inappropriate. I’ve signed the OCA with the name “Bo Zhang”.
Bug description:
8210810 <https://bugs.openjdk.java.net/browse/JDK-8210810>: Incorrect argument
file parser behavior in certain
