Re: Code review request for #6469160, #7088271: (fmt) format("%.1g", 0.0) throws ArrayOutOfBoundsException

2012-01-26 Thread Brandon Passanisi
ts to make sure there aren't any regressions. Webrev: http://cr.openjdk.java.net/~bpassani/6469160/1/webrev/ <http://cr.openjdk.java.net/%7Ebpassani/6469160/1/webrev/> Thanks. On 1/24/2012 11:58 PM, David Holmes wrote: Hi Brandon, On 25/01/2012 5:03 PM, Brandon Passanisi wr

Re: Code review request for #6469160, #7088271

2012-01-24 Thread Brandon Passanisi
Hi David. Thank you for your review comments. My answers to your questions are below: On 1/23/2012 9:56 PM, David Holmes wrote: Hi Brandon, On 21/01/2012 4:19 AM, Brandon Passanisi wrote: Resending again... Hello core-libs. I was wondering of somebody could be please review the following

Code review request for #6469160, #7088271

2012-01-20 Thread Brandon Passanisi
make sure there weren't any regressions in behavior. Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Code review request for #6469160, #7088271

2012-01-04 Thread Brandon Passanisi
make sure there weren't any regressions in behavior. Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Re: Review request for #6783209

2012-01-03 Thread Brandon Passanisi
he new test I had written and instead have updated Basic-X.java.template as you have suggested. I have created an updated webrev for review that reflects these changes. Webrev: http://cr.openjdk.java.net/~bpassani/6783209/1/webrev/ Thanks. Thanks, iris -Original Message- From: Brandon

Review request for #6783209

2012-01-03 Thread Brandon Passanisi
27; without a width to ensure there aren't regressions. Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Code review request for #6469160, #7088271

2011-12-23 Thread Brandon Passanisi
matter's Basic-X template of tests with a little over 20 test format strings that were causing exceptions without the change and the output of each is compared with the output from C's printf with the same format string. And, I ran all of the Basic-X tests to make sure there weren

Re: Code Review Request for Bug #4802647

2011-12-23 Thread Brandon Passanisi
ebrev for review is a reflection of this: Webrev URL: http://cr.openjdk.java.net/~bpassani/4802647_7123424/3/webrev/ Thanks. On 12/21/2011 11:23 AM, Brandon Passanisi wrote: Yes, my intent was "extends AbstractSet" instead of "extends NewAbstractCollection". I h

Re: Code Review Request for Bug #4802647

2011-12-21 Thread Brandon Passanisi
instead of "extends NewAbstractCollection". Jason -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Re: Code Review Request for Bug #4802647

2011-12-19 Thread Brandon Passanisi
ayList and java.util.concurrent.CopyOnWriteArrayList. Should a new bug be filed for these cases? Thanks. [1]: http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-November/008283.html On 12/2/2011 2:34 AM, Alan Bateman wrote: On 01/12/2011 22:42, Brandon Passanisi wrote: Hi Jason. Thanks for your re

Re: Review Request for 7116997 (warning cleanup java.util.PropertyPermission)

2011-12-02 Thread Brandon Passanisi
n 12/1/11 1:18 PM, Brandon Passanisi wrote: I have a webrev pertaining to the warning cleanup changes for java.util.PropertyPermission ready for review. Here's the info: Bug: 7116997 Webrev: http://cr.openjdk.java.net/~dmocek/bpassanisi/7116997/webrev.00/ <http://cr.openjdk.java.net/%7Edmo

Review request for bug #5063455

2011-12-02 Thread Brandon Passanisi
racle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Oracle Java Standards Conformance Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Re: Cleanup fallthrough in FilePermission and PropertyPermission was: Request for Review of 7116890 (Warning Cleanup java.io)

2011-12-02 Thread Brandon Passanisi
fix for both and cc the review request to you. -- Sebastian Am 01.12.2011 23:54, schrieb Brandon Passanisi: Hi Sebastian. I was speaking with Stuart Marks earlier today and he mentioned that the "fallthrough" code in FilePermission.java also exists in java.util.PropertyPermission.

Re: Request for Review of 7116890 (Warning Cleanup java.io)

2011-12-01 Thread Brandon Passanisi
t and will start discussion of FilePermission change on core-libs-dev after the cleanup event. I created a new webrev with the suggested changes here[2] [2] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/Warning_Cleanup_Java_io/CR7116890_0/index.html -- Sebastian -- Oracle <ht

Re: Code Review Request for Bug #4802647

2011-12-01 Thread Brandon Passanisi
h the JDK? Any override of these methods could repeat the same (bad) behavior. Jason -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Oracle Java Standards Conformance Green Oracle <http://www.oracle.com/commitment> Oracle is committed to devel

Review Request for 7116997 (warning cleanup java.util.PropertyPermission)

2011-12-01 Thread Brandon Passanisi
ebrev.00/> Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Oracle Java Standards Conformance Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

Re: Code Review Request for Bug #4802647

2011-11-30 Thread Brandon Passanisi
On 11/21/2011 3:58 PM, David Holmes wrote: On 22/11/2011 4:29 AM, Brandon Passanisi wrote: Thank you for the review David. I'll make the changes to the test program as you have suggested and I will also update the bug report with the comments you have given. I'll then send out an upda

Re: Expected behavior with -esa

2011-11-23 Thread Brandon Passanisi
, Eamonn McManus wrote: Isn't an AssertionError *always* a bug? Éamonn On 23 November 2011 12:04, Brandon Passanisi wrote: I'm currently looking at a bug report: http://monaco.sfbay.sun.com/detail.jsf?cr=5066854 which describes an issue where a simple program was run with the opti

Expected behavior with -esa

2011-11-23 Thread Brandon Passanisi
I'm currently looking at a bug report: http://monaco.sfbay.sun.com/detail.jsf?cr=5066854 which describes an issue where a simple program was run with the option -esa to enable system assertions. The bug author describes that, in the provided sample code, an AssertionError occurs when the spec

Question regarding java.util.Formatter width

2011-11-21 Thread Brandon Passanisi
:2664) at java.util.Formatter.parse(Formatter.java:2528) at java.util.Formatter.format(Formatter.java:2469) at java.io.PrintStream.format(PrintStream.java:970) at java.io.PrintStream.printf(PrintStream.java:871) at formatterwidthzero.F

Re: Code Review Request for Bug #4802647

2011-11-21 Thread Brandon Passanisi
ound it" in regards to the fix to AbstractCollection.java... it sounds like you agree to keep the change as-is. Is this correct? On 11/20/2011 6:19 PM, David Holmes wrote: Hi Brandon, On 19/11/2011 11:21 AM, Brandon Passanisi wrote: Hello core-libs-dev@openjdk.java.net. Please review t

Code Review Request for Bug #4802647

2011-11-18 Thread Brandon Passanisi
: http://cr.openjdk.java.net/~mduigou/4802647/0/webrev/ Thanks. -- Oracle <http://www.oracle.com> Brandon Passanisi | Principle Member of Technical Staff Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment