Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Joe, alan and every one I'm working on jaxp functional test colocation which is traced by the bug JDK-8043091 . We have finished to convert a few suite and the jaxp/xpath tracked by bug JDK-8051561

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

338, 1401855509338, 1401855509836, 1401855510836] Thanks, Eric On 2014/6/4 9:16, Martin Buchholz wrote: On Tue, Jun 3, 2014 at 6:12 PM, Eric Wang <mailto:yiming.w...@oracle.com>> wrote: Hi Martin, To sleep(1000) is not enough to reproduce the failure, because it is much lower tha

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

Hi Martin, To sleep(1000) is not enough to reproduce the failure, because it is much lower than the period DELAY_MS (10*1000) of the repeated task created by "scheduleAtFixedRate(t, counter(y3), past, DELAY_MS)". Try sleep(DELAY_MS), the failure can be reproduced. Thanks, Eric On 2014/6/4 8:

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

ailed); if (failed > 0) throw new AssertionError("Some tests failed");} interface F { void f() throws Throwable; } void assertThrows(Class k, F... fs) { for (F f : fs) try {f.f(); fail("Expected " + k.getName() + " not thrown");}

RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

Hi, Please help to review the fix for bug https://bugs.openjdk.java.net/browse/JDK-8004807 as below: http://cr.openjdk.java.net/~ewang/JDK-8004807/webrev.00/ The root cause of the failure is if Timer.cancel() is not called in time, the recurring timer task keeps running which cause the the a

RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

Hi Everyone, I'm working on the test bug https://bugs.openjdk.java.net/browse/JDK-8035633, There are 4 tests (one is in a closed test) failed due to NullPointerException. All tests failed at similar places "if (isWindows && ni.getDisplayName().contains("Teredo"))", the root cause is the Netwo

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

f manually. 4. When you post the webrev, you should post updated webrevs under a directory with an incremented sequence number (in this case, webrev.01). That way, links to, and comments on, previous webrevs will not be invalidated. Thanks, s'marks On 1/24/14 1:43 AM, Eric Wang wrote:

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

Hi Stuart, Please review the webrev http://cr.openjdk.java.net/~ewang/JDK-8031179/webrev.00/, if you are OK with the changes, could you please be my sponsor? Thanks, Eric On 2014/1/24 15:14, Eric Wang wrote: Hi Stuart, Thanks for the suggestion! sorry for reply this mail late as i was busy

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

e also remove the merging of the MarshalledObject tests, I think we can proceed with the othervm changes. Eric, can you make these changes and send out another webrev? Thanks. s'marks On 1/16/14 7:18 AM, Eric Wang wrote: Hi Stuart, I have generated a webrev for review, can you please hel

RFR for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification is sent, so both the main thread and Checker threa

Re: Question about JDK-8023087

Including the corelibs-dev team, so someone may help me. Thanks, Eric On 2013/10/1 10:39, Eric Wang wrote: Hi Alan, I'm looking at the bug https://bugs.openjdk.java.net/browse/JDK-8023087 which is filed for CCC changes https://bugs.openjdk.java.net/browse/JDK-8007405. There'r

Review quest for bug 8022879: sun/nio/cs/MalformedSurrogates.java fails intermittently

Hi, Please help to review the fix below for bug https://jbs.oracle.com/bugs/browse/JDK-8022879 http://cr.openjdk.java.net/~ewang/8022879/webrev.00/ The test has defect as it wouldn't be executed if the file.encoding is UTF-8 (lots of test machines in nightly are UTF-8), it also doesn't chec

[PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

beginning. Thanks! -Dan On 03/12/2013 11:28 PM, Eric Wang wrote: Hi, Please review the code change, I have updated the test to make sure test only access files and directories created by itself. http://cr.openjdk.java.net/~ewang/8009258/webrev.01/ Here is the execution result: http://cr.openjdk

Re: [PATCH] Review request: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up

d On 15/05/2013 9:07 PM, Eric Wang wrote: On 2013/5/15 17:38, Alan Bateman wrote: On 15/05/2013 10:10, Eric Wang wrote: Hi, Please help to review the fix for bug 8004177 <https://jbs.oracle.com/bugs/browse/JDK-8004177> and 8004178 <https://jbs.oracle.com/bugs/browse/JDK-8004178>, th

Re: [PATCH] Review request: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up

On 2013/5/15 17:38, Alan Bateman wrote: On 15/05/2013 10:10, Eric Wang wrote: Hi, Please help to review the fix for bug 8004177 <https://jbs.oracle.com/bugs/browse/JDK-8004177> and 8004178 <https://jbs.oracle.com/bugs/browse/JDK-8004178>, this fix is to make sure all child thre

Re: [PATCH] Review request: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up

Hi Chris, Thanks you for the review and sponsor this change. Regards, Eric On 2013/5/15 17:26, Chris Hegarty wrote: Looks fine to me Eric. Let me know if you need someone to sponsor this change for you. -Chris. On 15/05/2013 10:10, Eric Wang wrote: Hi, Please help to review the fix for

[PATCH] Review request: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up

Hi, Please help to review the fix for bug 8004177 and 8004178 , this fix is to make sure all child threads finished before main thread exits. http://cr.openjdk.java.net/~ewang/8004177/webrev.00/

Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

Including more reviewer... Thanks, Eric On 2013/3/13 14:28, Eric Wang wrote: Hi, Please review the code change, I have updated the test to make sure test only access files and directories created by itself. http://cr.openjdk.java.net/~ewang/8009258/webrev.01/ Here is the execution result

Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

/3/5 1:39, Alan Bateman wrote: On 04/03/2013 17:32, Eric Wang wrote: Hi, Please help to review fix below for bug 8009258 <https://jbs.oracle.com/bugs/browse/JDK-8009258>, TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently. http://cr.openjdk.java.net/~ewang/8009258/web

Re: [PATCH] Review request: 8009259 TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently

On 2013/3/5 2:25, Alan Bateman wrote: On 04/03/2013 16:13, Eric Wang wrote: Hi, Please help to review the fix below for bug 8009259 <https://jbs.oracle.com/bugs/browse/JDK-8009259> TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently. http://cr.openjdk.java.net/~ewang/8

Re: [PATCH] Review request: 8009259 TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently

admit I never seen this test fail before ( though I do see the small race window ). Let me know if you need a sponsor for this. -Chris. On 03/04/2013 04:13 PM, Eric Wang wrote: Hi, Please help to review the fix below for bug 8009259 <https://jbs.oracle.com/bugs/browse/JDK-8009259> TE

[PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

Hi, Please help to review fix below for bug 8009258 , TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently. http://cr.openjdk.java.net/~ewang/8009258/webrev.00/ The File.canRead() method should not be used to check read permission o

[PATCH] Review request: 8009259 TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently

Hi, Please help to review the fix below for bug 8009259 TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently. http://cr.openjdk.java.net/~ewang/8009259/webrev.00/ The test failed due to wrong assumption of thread scheduling, so fix

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

tra, as we will now always exercise this part on windows. And are we sure the Solaris issues are no longer a concern? I assume the problem was doing the disk space checks on remote filesystems. Thanks, David On 28/08/2012 12:52 PM, Eric Wang wrote: Hi David, Amy & Alan Thanks for your re

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi David, Amy & Alan Thanks for your review, Based on your comments I have updated the fix again, Can you please review again? http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Thanks, Eric On 2012/8/22 17:27, David Holmes wrote: On 22/08/2012 6:10 PM, Eric Wang wrote:

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi David, To use dirFile.length() == 0 to replace the disk space measurement as guess the original test tries to prove that there's no extra disk spent when creating empty folders. Regards, Eric On 2012/8/22 16:02, David Holmes wrote: Hi Eric, On 22/08/2012 5:54 PM, Eric Wang

[PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi, Please help to review the fix below for bug **6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Root cause is the test is not reliable when system i

Re: CR 6899850 Updated, jeff.dinkins now responsible manager, P4 java/classes_util TESTBUG: DateRegression fails with "Date hashCode misbehaves"

be we should just fix this while it is fresh in our minds. (Naoto - I should explain that Eric Wang is in the SQE team and has been spending some time on fixing several of our regression tests that we excluded, by putting down on ProblemList). -Alan On 16/08/2012 18:11, Alan Bateman wrote:

[PATCH] Review Request for bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin

Hi Alan, Please help to review the below fix for** bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin. http://dl.dropbox.com/u/90659131/fixes/7132247/webrev/index.html Root cause of this bug is: 1. CYGWIN doesn't handle "

[PATCH] Review Request: 7076644 TEST_BUG: test/java/io/File/Basic.java fails with cygwin

Hi Alan, Can you please help to review the fix below for bug http://monaco.us.oracle.com/detail.jsf?cr=7076644? http://dl.dropbox.com/u/90659131/fixes/7076644/webrev/index.html As discussed, it is caused a known issue of cygwin that chmod doesn't work, see http://cygwin.com/faq/faq-nochunks.

[PATCH] review request: 7148829 sun/net/InetAddress/nameservice/simple/CacheTest.java failing

Hi Chris, Please help to review the fix for bug 7148829 sun/net/InetAddress/nameservice/simple/CacheTest.java failing http://dl.dropbox.com/u/90659131/fixes/7148829/webrev/index.html The root cause is on certain Vitrual Machines the wall clo

[PATCH] Review request: 7081476 test/java/net/InetSocketAddress/B6469803.java failing intermittently

Hi Chris, Please help to review the fix for 7081476 : test/java/net/InetSocketAddress/B6469803.java failing intermittently. http://dl.dropbox.com/u/90659131/fixes/7081476/webrev/index.html The test failed when it is running with java/net/Dat

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi Marks, Thanks for your great help to review and push my first fix.:-) Regards, Eric On 2012/7/6 6:19, Stuart Marks wrote: Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd s'marks On 7/3/12 6:54 PM, Eric Wang wrote: Opps, It is my carelessness, I will be more careful i

[Patch] Review request - bug 7147060 com/sun/org/apache/xml/internal/security/transforms/ClassLoaderTest.java doesn't run in agentvm mode

Hi David & Stuart, Can you please help to review the fix for the bug 7147060 , Thanks you! The test reports ClassNotFoundException which is caused by below reasons: 1. Class can be found in "test.classes" instead of "test.src". 2. In agentvm m

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

sion, I'll push them in a couple days (U.S. holiday coming up). s'marks On 7/3/12 12:20 AM, Stuart Marks wrote: This approach looks good to me. Please go ahead and update 7123972 as well, and I'll post these webrevs tomorrow (my time). Thanks. s'marks On 7/2/12 11:41 PM, Er

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

me as 6948101 and the same comments I had on that bug apply here as well, so please make similar updates to this one. Thanks. s'marks On 6/29/12 1:36 AM, Eric Wang wrote: Hi Stuart & David?? Attachment is the new changes to make code simply by following David suggestion, Can you help

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

David, I have added the comments before the loop, please help to review. If it is OK, I'll update the 7123972 as well. Thanks, Eric On 2012/7/3 12:22, David Holmes wrote: Hi Eric, On 3/07/2012 1:28 PM, Eric Wang wrote: Hi Stuart and David, Thanks for the suggestion about the timeou

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi Stuart and David, Thanks for the suggestion about the timeout. so there are three ways to handle the timeout. 1. Add comment to explain that test failed due to default timeout 2. Specify the the timeout option 3. Timeout programly Is it ok for you that i'd like to choose the second way "ex

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

cates there really was a failure. I'll give people a chance to look at the webrev and if there aren't any more comments in another day or so I'll push in the changeset. Thanks for developing this! s'marks On 6/26/12 11:50 PM, Eric Wang wrote: Hi David, Thank you! I run th

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi David, I have made changes by following your suggestion. Can you please help to review again? Thanks a lot! I also change the code of 7123972 which is sent in another mail. Regards, Eric On 2012/6/29 11:04, David Holmes wrote: On 29/06/2012 12:10 PM, Eric Wang wrote: Hi Stuart, Thank

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

remove(timeout), so we could set some timeout without waiting the full jtreg timeout if we don't want to. Or we could call System.gc() in a loop using remove() with a short timeout (instead of sleep), similar to the current test, although it's not clear to me this is necessary. s'mark

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

e a chance to look at the webrev and if there aren't any more comments in another day or so I'll push in the changeset. Thanks for developing this! s'marks On 6/26/12 11:50 PM, Eric Wang wrote: Hi David, Thank you! I run the test several times on 3 platforms (windows, solaris a

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi David, Thank you for review! Hi Stuart, Can you please help to review and post the webrev, Thanks a lot! Eric On 2012/6/27 15:32, David Holmes wrote: On 27/06/2012 4:57 PM, Eric Wang wrote: Hi David & Stuart, Thank you for the help! please review the in webrev 6948101.zip in attach

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

the reviews are complete. s'marks [1] http://openjdk.java.net/census On 6/26/12 2:56 PM, David Holmes wrote: Hi Eric, On 26/06/2012 7:26 PM, Eric Wang wrote: Please help to review the fix attached for test bug 6948101 <http://monaco.us.oracle.com/detail.jsf?cr=6948101> which is sa

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

as now run against a JDK with the original bug, the test would hang. So I think we need to add a timeout in there as well. David On 25/06/2012 6:06 PM, Eric Wang wrote: On 2012/6/21 20:16, David Holmes wrote: Hi Eric, On 21/06/2012 8:57 PM, Eric Wang wrote: Hi David, Thanks for your review, I

[PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi All, Please help to review the fix attached for test bug 6948101 which is same root cause as bug 7123972 . The test makes wrong assumption that GC is started immediately to recycle unused

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

ther mail thread. Thanks, Eric On 2012/6/25 16:06, Eric Wang wrote: On 2012/6/21 20:16, David Holmes wrote: Hi Eric, On 21/06/2012 8:57 PM, Eric Wang wrote: Hi David, Thanks for your review, I have updated the code by following your suggestion. please see the attachment. I'm not sure whe

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

On 2012/6/21 20:16, David Holmes wrote: Hi Eric, On 21/06/2012 8:57 PM, Eric Wang wrote: Hi David, Thanks for your review, I have updated the code by following your suggestion. please see the attachment. I'm not sure whether there's a better way to guarantee object finalized by GC

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

till throw InterruptException if execution is timeout (2 minutes of JTreg by default). Regards, Eric On 2012/6/21 14:32, David Holmes wrote: Hi Eric, On 21/06/2012 4:05 PM, Eric Wang wrote: I come from Java SQE team who are interested in regression test bug fix. Here is the first simple fix for b

Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Hi All, I come from Java SQE team who are interested in regression test bug fix. Here is the first simple fix for bug 7123972 , Can you please help to review and comment? Attachment is the patch Thanks! This bug is caused by wrong assumption