Integrated: 8183374: Refactor java/lang/Runtime shell tests to java

On Mon, 19 Apr 2021 15:07:16 GMT, Fernando Guallini wrote: > Refactor the following shell tests to java: > test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh > test/jdk/java/lang/Runtime/exec/SetCwd.java > > In addition, the test SetCwd was running itself in separate ja

Re: RFR: 8183374: Refactor java/lang/Runtime shell tests to java

On Mon, 19 Apr 2021 15:07:16 GMT, Fernando Guallini wrote: > Refactor the following shell tests to java: > test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh > test/jdk/java/lang/Runtime/exec/SetCwd.java > > In addition, the test SetCwd was running itself in separate ja

RFR: 8183374: Refactor java/lang/Runtime shell tests to java

Refactor the following shell tests to java: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh test/jdk/java/lang/Runtime/exec/SetCwd.java In addition, the test SetCwd was running itself in separate java subprocesses in order to exercise Runtime.exec. It was creating a folder structure wit

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

> Wouldn't you require the sun.arch.data.model == "64" jtreg config in these > tests also ? > > regards, > Sean. > > On 28/08/2020 19:13, Fernando Guallini wrote: >> >> >> >> >> >> >> >> Hi, >> &

RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

Hi, May I please get reviews and a sponsor for this trivial change: webrev: http://cr.openjdk.java.net/~fguallini/8249694/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8249694 Tests do not need to have ‘@ignore' because with @requires os.maxMemory is enough to ensure

Re: RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

to 10g perhaps ? It might avoid border line resource failures. Also I think it might need a "sun.arch.data.model == "64" " requirement : @requires (sun.arch.data.model == "64" & os.maxMemory >= 10g) regards, Sean. On 26/08/2020 18:17, Fernando Guallini wrote:

RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

Hi, Could I please get reviews and a sponsor for: webrev: http://cr.openjdk.java.net/~fguallini/8249699/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8249699 The test wa

Re: RFR: JDK-8222241 - Example in ServiceLoader API docs should have one provides directive

> On 29/05/2020 18:12, Fernando Guallini wrote: >> Hi, >> in the ServiceLoader API docs, the given example specifying the service >> providers for a particular service should be comma-separated instead of >> using two separate ‘provides’ directives, that would result

RFR: JDK-8222241 - Example in ServiceLoader API docs should have one provides directive

Hi, in the ServiceLoader API docs, the given example specifying the service providers for a particular service should be comma-separated instead of using two separate ‘provides’ directives, that would result in a compilation error. Web rev: http://cr.openjdk.java.net/~pconcannon/fguallin/8

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

s test and remove it if obsolete, if that is fine with you. -Fernando > On 11 May 2020, at 17:27, Joe Wang wrote: > > > > On 5/11/2020 2:32 AM, Alan Bateman wrote: >> On 08/05/2020 18:19, Fernando Guallini wrote: >>> Hi Daniel and Alan, >>> @compile/module=

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

ments. > > Maybe the explanations below should be added to the test in some > comment to help future maintainers (and reviewers). > > best regards, > > -- daniel > > > On 08/05/2020 18:19, Fernando Guallini wrote: >> Hi Daniel and Alan, >> @compile/module=jav

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version of Node and Document interfaces - Compiles DocumentImpl patching java.xml with those 2 interf

RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi all, Please, review the following change: webrev: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8209774 Change

RFR[8183266] - [TESTBUG]Add test to cover XPathEvaluationResult.XPathResultType.getQNameType method

Hi all, Please, review the following change: webrev: http://cr.openjdk.java.net/~joehw/jdk15/8183266/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8183266 Change details: - Added test coverage for XPathEvaluationResult.XPathResultType.getQNameType method - Added type check for the getQN