Looks good to me.
Fred
> On Dec 5, 2019, at 09:36, Harold Seigel wrote:
>
> Hi,
>
> Please review this small change to simplify Class.getRecordComponents() by
> changing the return type of getRecordComponents0() to RecordComponent[].
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_
Much cleaner!
Thumbs up!
Fred
> On Aug 14, 2019, at 15:42, Mandy Chung wrote:
>
> I have further discussion with Coleen and walkthrough the vframe
> implementation. Here is what we confirm and agree.
>
> vframeStream::bci might return an invalid bci whereas javaVFrame::bci returns
> a vali
This looks good to me, with two comments:
I don’t like the static final RETAIN_CLASS_REF for the same
reasons as Aleksey, but I can live with that.
The protocol between the JVM and the Java class is well explained
on the JVM side (javaClasses.cpp:4227). I think it would be valuable
to provide the
I’m seeing no issue with rcx being aliased in this code.
Fred
> On Oct 30, 2017, at 15:44, Paul Sandoz wrote:
>
> Hi,
>
> Thanks for reviewing.
>
>> On 30 Oct 2017, at 11:05, Dmitry Samersoff
>> wrote:
>>
>> Paul,
>>
>> templateTable_x86.cpp:
>>
>> 564 const Register flags = rcx;
>> 56
Brent,
hotspot/src/share/vm/prims/stackwalk.cpp:
230 if (!expressions &&
231 values->at(i)->type() == T_INT &&
232 values->int_at(i) == 0 && // empty first slot of long?
233 i+1 < values->size() &&
234 values->at(i+1)->type() == T_INT) {
How does this tes
Thanks for the review Alan!
Fred
On 18/07/2016 10:39, Alan Bateman wrote:
On 18/07/2016 14:48, frederic parain wrote:
Hello,
src/java.base/windows/native/libjava/jni_util_md.c file contains
incorrect GPL header which fails make/scripts/lic_check.sh script check.
Failure is caused by
Hello,
src/java.base/windows/native/libjava/jni_util_md.c file contains
incorrect GPL header which fails make/scripts/lic_check.sh script check.
Failure is caused by missing comma after modification years. Please,
help to review its addition:
http://cr.openjdk.java.net/~fparain/8161034/w
IA64)
I'll move that functionality to another place, so no need to fix it.
You're right, I meant AMD64.
Thanks,
Fred
-Original Message-
From: Frederic Parain [mailto:frederic.par...@oracle.com]
Sent: Montag, 14. Dezember 2015 15:44
To: Lindenmaier, Goetz ; Karen Kinnear
Cc: h
_yellow_reserved_zone? This would make clear in the code that this
are two separate zones.
I anyways have to adapt most of the calls to these accessors.
Best regards,
Goetz.
-Original Message-
From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On
Behalf Of Frederic Par
Karen,
Thank you for your review.
Fred
On 23/11/2015 20:10, Karen Kinnear wrote:
Frederic,
Looks good.
Many thanks.
Karen
On Nov 23, 2015, at 12:44 PM, Frederic Parain
mailto:frederic.par...@oracle.com>> wrote:
Karen,
Thank you for your review, my answers are in-lined below
All fixed.
Thank you Dan.
Fred
On 02/12/2015 19:22, Daniel D. Daugherty wrote:
On 12/1/15 9:21 AM, Frederic Parain wrote:
Hi Dan,
Thank you for your detailed review.
My answers are in-lined below.
New webrev:
http://cr.openjdk.java.net/~fparain/8046936/webrev.02/hotspot/
Re-reviewed by
tion in caller that you do have a java frame.
It doesn't make sense to check the current frame (no bytecode has been
executed yet, so risk of partially executed critical section). I did the
change but not for all platforms. This is now fixed for Solaris_SPARC
and Windows too.
4. test l
tter than doing nothing.
Maybe there is some decent empirical strategy, but I can't
tell until hotspot support of @ReservedStackAccess is in place.
So my vote is still to keep the JDK changes out for now.
-Doug
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ently accepted :-)
7. I see the change in trace.xml, and I see an include added to
SharedRuntime.cpp,
but I didn’t see where it was used - did I just miss it?
trace.xml changes define a new event.
This event is created at sharedRuntime.cpp::3006 and it is used
in the next 3 lines.
Thanks,
be a very valuable addition to this JEP work.
Thanks,
Fred
I'd be looking at expanding the current application of the annotation
to cover all affected areas of AQS, AQLS, ReentrantLock and
ReeentrantReadWriteLock. StampedLock is a bit more problematic - there
it seems we do need
oncerned about keeping the size of the
reserved area small.
Fred
On 6/11/2015 12:17 AM, Frederic Parain wrote:
Please review the changesets for JEP 270: Reserved Stack Areas for
Critical Sections
CR: https://bugs.openjdk.java.net/browse/JDK-8046936
Webrevs:
hotspot:
http://cr.openjdk.java.net
opinion before
doing this.
Regards,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ke os::open and readFully. A
project-wide commitment
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Thank you Coleen, Harold, Alan and Sherman
for your reviews.
Fred
On 07/10/2014 15:06, Alan Bateman wrote:
On 06/10/2014 07:32, Frederic Parain wrote:
Thank you very much for catching the JVM_O_DELETE issue.
I moved the O_DELETE support into the ZipFile.c file
(code was the same for all non
jdk_core group of
tests is the right group to exercise this area.
-Alan
Hi,
ZipFile.c expects the JVM_Open() to handle the JVM_O_DELETE, with
explicit unlink on linux/solaris for example.
I would assume the open from the c library does not handle it and we
need to do it explicitly by ZipFile.c
Alan,
Thank you for your feedback, see my comments below.
On 03/10/2014 17:19, Alan Bateman wrote:
On 30/09/2014 07:40, Frederic Parain wrote:
Hi all,
Please review changes for bug JDK-805 "Cleanup of old
and unused VM interfaces"
CR:
https://bugs.openjdk.java.net/browse/J
nly change with a promoted
JDK.
Please send your comments.
Thanks,
Coleen
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Looks good to me.
Thanks,
Fred
On 24/06/2014 17:11, Coleen Phillimore wrote:
On 6/24/14, 4:41 AM, Frederic Parain wrote:
Hi Coleen,
It seems that there's still a reference to JVM_GetClassLoader
in file jdk/src/share/native/common/check_code.c. The code looks
like dead code, but it wou
to set a final field
after initialization. I’m not sure we need to care about that either
if you need Unsafe to do it.
Normal reflection can set a final field if you can successfully call
setAccessible(true) on the Field object.
David
-
cheers
/Joel
--
Frederic Parain - Oracle
Grenob
Changeset: e857b2a3ecee
Author:fparain
Date: 2013-06-05 08:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e857b2a3ecee
7150256: Add back Diagnostic Command JMX API
Reviewed-by: mchung, jbachorik
! make/java/management/Exportedfiles.gmk
! make/java/management/FILES_c.gmk
!
ut 's'.
On 5/3/2013 11:40 AM, frederic parain wrote:
MBeanServer.setAttributes() returns an AttributeList
but the return type of DynamicMBean.setAttributes() is
void. Does it mean that in our case, setAttributes()
should simply be a no-op method?
Fred
On 03/05/2013 20:19, Daniel Fuchs
>
and
<http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#setAttributes%28javax.management.ObjectName,%20javax.management.AttributeList%29>
-- daniel
Thanks
Mandy
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
t;
-- daniel
Thanks
Mandy
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ws UOE which seem to be okay. It's good to confirm
what is specified or not specified per DynamicMBean spec
Thanks
Mandy
On 5/3/2013 9:43 AM, frederic parain wrote:
Hi all,
After an intense work with Mandy, here's a new webrev which
fix the issue with the PlatformMa
ne 39: diamond operator
Since the test is for MXBeans, it's more appropriate to exclude
non-MXBean from this test or rename the test to cover the new platform
mbeans.
On 4/18/2013 7:23 AM, frederic parain wrote:
DiagnosticCommandImpl.Wrapper class
If there is any issue initializing the
icCommand.cpp
lines 105/109 - what prints if p._name is null?
thanks,
Karen
On Apr 30, 2013, at 12:26 PM, frederic parain wrote:
Hi all,
This is a second request for review to add back
Remote Diagnostic Commands.
This work adds a new platform MBean providing
remote access to the diag
tpone the
fix of this issue after the JDK8 feature freeze
(leaving for vacations soon, I won't have time to
fix tests before the feature freeze).
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
,
It's good to see the management interface for diagnostic commands is back.
On 12/17/12 6:58 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7150256/webrev.01/
Please send your makefiles change to build-dev and build-infra for
review to ensure necessary change is made in th
they require.
The webrev is here:
http://cr.openjdk.java.net/~fparain/7150256/webrev.00/
The second part of this project is the support for this
feature in the HotSpot VM, and is tracked by CR 8004095
(separate request for review will be sent for it).
Thanks,
Fred
--
Frederic Parain - Oracle
Changeset: 62228dc7a4ac
Author:fparain
Date: 2012-03-28 02:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62228dc7a4ac
7156831: The jcmd man page is not included in generated bundles
Reviewed-by: dholmes, sla, dsamersoff
! make/common/Release.gmk
Changeset: 0e4f259f0a1f
Author:fparain
Date: 2012-03-14 09:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e4f259f0a1f
7074616: java.lang.management.ManagementFactory.getPlatformManagementInterfaces
fails
Reviewed-by: dholmes, sla
! src/share/classes/java/lang/management
eturn true;
// object is not an object name case
if (!(object instanceof ObjectName)) return false;
ObjectName on = (ObjectName) object;
return _canonicalName.equals(on._canonicalName);
}
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33
improve performance.
It seems to me that this is a case of "fixing" something for one
use-case without knowing what the impact will be on other use-cases!
Is there perhaps a solution that makes String.intern more scalable?
David
-
On 24/02/2012 1:36 AM, Frederic Parain wrote:
Th
Oracle, Grenoble Engineering Center - France
Phone : +33 4 76 18 80 09 Fax :
+33 4 76 18 80 23
Frederic Parain said on date 2/23/2012 6:01 PM:
No particular reason. But after thinking more about it,
equals() should be a better choice, clearer code, and
.00/>
I've tested this fix with the jdk_lang and jdk_management
test suites.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com <mailto:frederic.par...@oracle.com&g
http://cr.openjdk.java.net/~fparain/6988220/webrev.00/
I've tested this fix with the jdk_lang and jdk_management
test suites.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 20d39a0e6fdc
Author:fparain
Date: 2012-02-15 10:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20d39a0e6fdc
7145925: Removing remote access to diagnostic commands in the
HotSpotDiagnosticMBean
Reviewed-by: acorn, mchung, phh
! make/java/management/mapfile-vers
Changeset: 59884f656b7d
Author:fparain
Date: 2012-02-15 09:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59884f656b7d
7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Reviewed-by: alanb
! test/ProblemList.txt
! test/sun/tools/jcmd/jcmd_Output1.awk
Thanks Alan,
I've fixed the indentation in the BEGIN block.
Fred
On 02/15/12 10:04 AM, Alan Bateman wrote:
On 14/02/2012 11:01, Frederic Parain wrote:
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdat
Changeset: 13aef38438d8
Author:fparain
Date: 2012-02-14 07:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13aef38438d8
7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData
Reviewed-by: fparain, dholmes
! test/sun/tools/jcmd/jcmd-Defaults.sh
! test/sun/tools/jcmd/jcm
http://cr.openjdk.java.net/~fparain/7144833/webrev.00/
The webrev also contains the removal of the sun/tools/jps/jps-Vvml.sh
test from the problem list. The test has been fixed (see CR 6986875)
but the test was still in the exclusion list.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - F
Changeset: ac26d04e76c3
Author:fparain
Date: 2012-02-01 03:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac26d04e76c3
7120974: ManagementPermission "control" needs clarification
Reviewed-by: mchung, dholmes
! src/share/classes/java/lang/management/ManagementPermission.ja
Changeset: 0194fe5ca404
Author:fparain
Date: 2012-01-04 03:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0194fe5ca404
7104647: Adding a diagnostic command framework
Reviewed-by: mchung, dholmes
! make/common/Release.gmk
! make/java/management/mapfile-vers
! make/launcher
more :-)
Thanks,
Fred
On 13/12/2011 12:31 AM, Frederic Parain wrote:
Hi Robert,
These issues should be solved with the new webrevs:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/
Regards,
Fred
On 12/ 9/11 03:17 PM
212 }
Space is missed after 'while':
320 while(arg != NULL) {
326 while(arg != NULL) {
Thanks,
Serguei
On 12/12/11 7:56 AM, Frederic Parain wrote:
Minor updates:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/
Fred
On 12/12/11 03:29 PM, Fr
,
then you have to also change the logic on line 58 so that
args_len is also not too long.
You're right, this is definitively odd.
I've fixed _cmd_len and updated line 58.
lines 79, 104: typo: 'simple' -> 'single'
Fixed
line 318 - what is 'idx&#x
Minor updates:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/
Fred
On 12/12/11 03:29 PM, Frederic Parain wrote:
Hi Paul,
Thank you for the review.
I've applied all your recommendations except the refactoring
in diagnosticCommandFramework.cpp (too few lines can be r
cpp:
On line 41, insert blanks before the actual arguments. (see above
generic comment)
On line 77, the "if" is indented one space too many.
In management.cpp:
I'd be consistent with having or not having a space between "while",
"if" and "for"
and the f
replaced by spaces.
Best regards,
/Robert
-Original Message- From: Paul Hohensee Sent: Thursday,
December 08, 2011 7:26 PM To: Frederic Parain Cc:
serviceability-...@openjdk.java.net;
core-libs-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net Subject: Re: Request for
Review (XXL
On 12/7/11 2:32 AM, Mandy Chung wrote:
On 12/2/2011 5:57 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.00/
L112: Since you are in this file, can you fix the typo
"java.security.SecurityException" to "java.lang.SecurityException"?
ramework itself
doesn't depend on this organization, so it will be a set of rules
defining a convention in the way commands are named.
Diagnostic commands can easily organized in a hierarchical way, so the
template for a command name can be:
.[sub-domain.]
This template can be extended with sub-sub-domains and so on.
A special set of commands without domain will be reserved for the
commands related to the diagnostic framework itself, like the "help"
command.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: e0c3fd538f1f
Author:fparain
Date: 2011-05-16 17:28 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0c3fd538f1f
7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
Summary: Add a JMX notification to GarbageCollectorMXBeans
Reviewed-by: ac
Changeset: 8daf9e0c9a2e
Author:fparain
Date: 2011-05-13 13:20 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8daf9e0c9a2e
7031754: javax.management docs need to be updated to replace Java SE 6
occurrences
Summary: Remove references to a specific version of the Java Platform
58 matches
Mail list logo
