Re: RFR: 8262889: Compiler implementation for Record Patterns [v2]

2022-05-06 Thread Gavin Bierman
On Fri, 6 May 2022 14:09:24 GMT, Jan Lahoda wrote: >> 8262889: Compiler implementation for Record Patterns >> >> A first version of a patch that introduces record patterns into javac as a >> preview feature. For the specification, please see: >> http://cr.openjdk.java.net/~gbierman/jep427+405/j

Integrated: 8265130: Make ConstantDesc class hierarchy sealed

2021-06-01 Thread Gavin Bierman
On Thu, 20 May 2021 21:07:04 GMT, Gavin Bierman wrote: > Hi all, > > Please review this patch to make the ConstantDesc hierarchy `sealed`, as was > promised in its Javadoc, now that sealed classes are finalising in JDK 17. > > Thanks, > Gavin This pull request ha

Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v3]

2021-05-21 Thread Gavin Bierman
On Fri, 21 May 2021 03:26:49 GMT, liach wrote: >> Gavin Bierman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing file constants.patch added by mistake > > src/java.base/share/classes/java/lang/c

Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v4]

2021-05-21 Thread Gavin Bierman
> Hi all, > > Please review this patch to make the ConstantDesc hierarchy `sealed`, as was > promised in its Javadoc, now that sealed classes are finalising in JDK 17. > > Thanks, > Gavin Gavin Bierman has updated the pull request incrementally with one additional

Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v2]

2021-05-20 Thread Gavin Bierman
On Thu, 20 May 2021 21:32:08 GMT, Mandy Chung wrote: >> Gavin Bierman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing javadoc comments about future use of sealed > > src/java.base/sh

Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v3]

2021-05-20 Thread Gavin Bierman
> Hi all, > > Please review this patch to make the ConstantDesc hierarchy `sealed`, as was > promised in its Javadoc, now that sealed classes are finalising in JDK 17. > > Thanks, > Gavin Gavin Bierman has updated the pull request incrementally with one additional

Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v2]

2021-05-20 Thread Gavin Bierman
> Hi all, > > Please review this patch to make the ConstantDesc hierarchy `sealed`, as was > promised in its Javadoc, now that sealed classes are finalising in JDK 17. > > Thanks, > Gavin Gavin Bierman has updated the pull request incrementally with one additional

RFR: 8265130: Make ConstantDesc class hierarchy sealed

2021-05-20 Thread Gavin Bierman
Hi all, Please review this patch to make the ConstantDesc hierarchy `sealed`, as was promised in its Javadoc, now that sealed classes are finalising in JDK 17. Thanks, Gavin - Commit messages: - 8265130: Make ConstantDesc class hierarchy sealed Changes: https://git.openjdk.java.

Re: RFR: JDK-8227046: compiler implementation for sealed classes, JDK-8227047: Javadoc for sealed types and JDK-8227044: javax.lang.model for sealed classes

2020-05-19 Thread Gavin Bierman
> On 19 May 2020, at 13:44, Jan Lahoda wrote: > > Hi Vicente, > > javac changes look overall OK to me. > > A few comments: > -the handling of non-sealed in JavacParser is fairly good, even though I > wonder if handling it in the tokenizer would not be better. If I read the > specification