On Tue, 21 Sep 2021 15:27:12 GMT, Daniel Fuchs wrote:
>> I just realized I commented on a test file, while the actual culprit is in
>> `FileServerHandler.java`. But I guess it applies to all usages of this class
>> and method.
>
> Hmm... When printing messages on the console don't we want a loc
On Tue, 21 Sep 2021 14:59:18 GMT, Hannes Wallnöfer wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>>
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Sun, 10 Jan 2021 17:04:19 GMT, Attila Szegedi wrote:
>> _(NB: For this leak to occur, an application needs to be either creating and
>> discarding linkers frequently, or creating and discarding class loaders
>> frequently while creating Dynalink type converters for classes in them.
>> Neith
On Sun, 7 Feb 2021 15:45:00 GMT, Peter Levart wrote:
>> Attila Szegedi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename ClassLoaderRelation to RetentionDirection; it is better
>> self-documenting this way.
>
> I think this looks g
On Thu, 17 Dec 2020 17:10:10 GMT, Jonathan Gibbons wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
On Thu, 17 Dec 2020 16:39:17 GMT, Jonathan Gibbons wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
On Mon, 14 Dec 2020 09:34:31 GMT, Hannes Wallnöfer wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
> resource file, and n
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview API
On Mon, 19 Oct 2020 14:09:51 GMT, Hannes Wallnöfer wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc
>> behavior to more closely adhere to JEP 12.
>> The notable changes are:
>>
&g
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc
> behavior to more closely adhere to JEP 12.
> The notable changes are:
>
> * adding support for Preview APIs (javac un
e tests to use some static
> release or source version, which we don’t want either). I updated the CSR to
> the new code. It also needs to be
> reviewed: https://bugs.openjdk.java.net/browse/JDK-8251181
>
> Thanks,
> Hannes
Hannes Wallnöfer has updated the pull request incrementally
On Tue, 22 Sep 2020 17:30:19 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from lahodaj/JDK-8216497
>>
>>Automatic
e tests to use some static
> release or source version, which we don’t want either). I updated the CSR to
> the new code. It also needs to be
> reviewed: https://bugs.openjdk.java.net/browse/JDK-8251181
>
> Thanks,
> Hannes
Hannes Wallnöfer has updated the pull request incrementally
On Tue, 15 Sep 2020 12:56:13 GMT, Erik Joelsson wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR bel
On Tue, 15 Sep 2020 11:30:09 GMT, Jan Lahoda wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR below.
This pull request is identical with the RFR previously sent for the Mercurial
repository:
https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
I'm copy-pasting the comments from the original RFR below.
Most of the new code is added to the Extern class where it fits in qui
Hi Vicente,
I’ve looked at the Javadoc changes again, everything looks good to me.
Hannes
> Am 28.11.2019 um 05:37 schrieb Vicente Romero :
>
> Hi,
>
> Please review the code for the records feature at [1]. This webrev includes
> all: APIs, runtime, compiler, serialization, javadoc, and more!
Hi Roger,
There are quite a few occurrences of the reverse calling pattern "".equals(str)
in core libs.
This is a bit more tricky because it allows str to be null, but when used
following a null/not-null check it could be replaced with isEmpty() as well.
I wonder if these should be included in
This would definitely be a useful addition to the public MethodHandles API.
Achieving this functionality with currently available means is extremely tricky
and certainly does not produce readable or maintainable code.
Hannes
> Am 22.10.2018 um 14:07 schrieb Jim Laskey :
>
> Thank you for doing
Hi Jan,
Works as expected with jjs now.
Thanks,
Hannes
> Am 30.05.2018 um 17:06 schrieb Jan Lahoda :
>
> Hi,
>
> An updated webrev is here:
> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/
>
> A webrev showing changes from the previous revision is here:
> http://cr.openjdk.j
Hi Jan,
Nashorn changes look good.
I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit
the tab key, it autocompletes to „java.math “, adding a space character at the
end. This is a bit inconvenient, and the old version of jline didn’t do that.
Hannes
> Am 25.05.201
+1
Hannes
> Am 03.02.2017 um 09:57 schrieb Sundararajan Athijegannathan
> :
>
> +1
>
> -Sundar
>
> On 03/02/17, 10:24 AM, Amy Lu wrote:
>> src/jdk/nashorn/api/tree/test/ParseAPITest.java
>>
>> This nashorn test keeps failing at linux-i586, windows-i586 and
>> solaris-sparcv9 (JDK-8173863)
>
+1
Hannes
> Am 19.10.2016 um 07:06 schrieb Sundararajan Athijegannathan
> :
>
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8071588
>
> jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/
>
> nashorn webrev:
> http://cr.openjdk.java.net/~sundar/8071588/
+1
Hannes
> Am 18.10.2016 um 13:36 schrieb Sundararajan Athijegannathan
> :
>
> Please review http://cr.openjdk.java.net/~sundar/8071678/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8071678
>
> Thanks,
>
> -Sundar
>
Please review the following changes:
Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nashorn/webrev.00/
These are two one-liners that add a file existence check
27 matches
Mail list logo
