RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-11 Thread Jason Tatton
This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 byte encoded Strings). It is provided for x86 and ARM64. The implementation is greatly inspired by the indexOf(char) intrinsic for StringUTF16. To incorporate it I had to make a small change to StringLatin1.java (refacto

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-11 Thread Jason Tatton
On Tue, 8 Sep 2020 11:59:36 GMT, Jason Tatton wrote: > This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 > byte encoded Strings). It is provided for > x86 and ARM64. The implementation is greatly inspired by the indexOf(char) > intrinsic for Str

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-17 Thread Jason Tatton
On Fri, 11 Sep 2020 23:04:01 GMT, Jason Tatton wrote: >> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 >> byte encoded Strings). It is provided for >> x86 and ARM64. The implementation is greatly inspired by the indexOf(char) >> intri

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-18 Thread Jason Tatton
On Thu, 17 Sep 2020 18:20:08 GMT, Jason Tatton wrote: >> Hi Andrew, >> >> The current indexOf char intrinsics for StringUTF16 and the new one here for >> StringLatin1 both use the AVX2 – i.e. 256 >> bit instructions, these are also affected by the frequency sca

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v2]

2020-09-18 Thread Jason Tatton
1_mixed_char | avgt | 5 | **17,875.185** | ± 407.716 > | ns/op | > | IndexOfBenchmark.utf16_mixed_char | avgt | 5 | 18,292.802 | ± 167.306 | > ns/op | > > > The objective of the patch is to bring the performance of StringLatin1 > indexOf(char) in line with StringUTF16 > in

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-18 Thread Jason Tatton
On Fri, 18 Sep 2020 11:04:34 GMT, Jason Tatton wrote: >> Hi everyone, >> >> This patch is just missing a couple of reviewers... Please can someone step >> forward? >> >> I think it's a fairly straightforward change. >> >> -Jason > &g

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-18 Thread Jason Tatton
On Fri, 18 Sep 2020 16:31:23 GMT, Andrew Dinn wrote: > Can you explain where this restricted effect is documented? Certainly! I’ve found that determining the capability of the CPU and whether to enable AVX2 support if the chip supports it is mostly controlled in: [vm_version_x86.cpp]( https://g

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v3]

2020-09-21 Thread Jason Tatton
1_mixed_char | avgt | 5 | **17,875.185** | ± 407.716 > | ns/op | > | IndexOfBenchmark.utf16_mixed_char | avgt | 5 | 18,292.802 | ± 167.306 | > ns/op | > > > The objective of the patch is to bring the performance of StringLatin1 > indexOf(char) in line with StringUTF1

Integrated: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-10-14 Thread Jason Tatton
On Tue, 8 Sep 2020 11:59:36 GMT, Jason Tatton wrote: > This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 > byte encoded Strings). It is provided for > x86 and ARM64. The implementation is greatly inspired by the indexOf(char) > intrinsic for Str

RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

2020-10-28 Thread Jason Tatton
Please review the improvements which I have made to the java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any further improvements are required. Thanks, Jason - Commit messages: - 8254782 Changes: https://git.openjdk.java.net/jdk/pull/918/files Webrev: https:

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-28 Thread Jason Tatton
On Wed, 28 Oct 2020 22:44:37 GMT, Claes Redestad wrote: >> Jason Tatton has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjusted benchmark to use BlackHole and improved String array syntax as >> advised &g

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-28 Thread Jason Tatton
> Please review the improvements which I have made to the > java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any > further improvements are required. > > Thanks, > Jason Jason Tatton has updated the pull request incrementally with one additional com

Integrated: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

2020-10-29 Thread Jason Tatton
On Wed, 28 Oct 2020 21:59:53 GMT, Jason Tatton wrote: > Please review the improvements which I have made to the > java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any > further improvements are required. > > Thanks, > Jason This pull request has n