readlink(2) instead of readlink() to disambiguate from readlink(1)
On Fri, May 24, 2013 at 8:04 AM, John Zavgren
wrote:
Greetings:
I fixed two memory leaks in the file: jdk/src/solaris/bin/java_md_**
solinux.c
and I posted a webrev image of the changes at:
http://cr.openjdk.java.net/~**jzavgre
!
John
--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA
*q = '\0';
| p = q + 1;
| }
I prefer to have loops where the sentinel is the actual condition instead
of something computed independently, but that's fine too.
christos
PS: Can we please add strsep(3) to solaris at some point? Everyone else
relevant se
");
if (fieldID == NULL) { return ckParam; }
- Original Message -
From: fwei...@redhat.com
To: john.zavg...@oracle.com
Cc: core-libs-dev@openjdk.java.net
Sent: Wednesday, March 27, 2013 11:48:57 AM GMT -05:00 US/Canada Eastern
Subject: Re: RFR JDK-8003245
On 03/20/2013 04:27
22, 2013 10:19:24 AM GMT -05:00 US/Canada Eastern
Subject: Re: RFR-8008118
On Thu, Mar 21, 2013 at 12:11 PM, Christos Zoulas < chris...@zoulas.com >
wrote:
On Mar 21, 11:36am, john.zavg...@oracle.com (John Zavgren) wrote:
-- Subject: Re: RFR-8008118
| All:
|
| How does this
All:
How does this look?
1.) I reverted the for statement formatting change.
2.) I removed the goto statement and "inlined" some code instead.
3.) I checked to make sure that we're not freeing memory that we didn't
actually allocate. (Path vector elements that are empty.)
http://cr.openjdk.jav
All:
I modified the splitPath() procedure so that when it encounters an OOM error it
frees allocated memory before exiting.
Thanks!
John
http://cr.openjdk.java.net/~jzavgren/8008118/webrev.03/
- Original Message -
From: marti...@google.com
To: chris.hega...@oracle.com
Cc: john.
Greetings:
Please consider the following changes that eliminate the use of uninitialized
memory.
http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/
Thanks!
John
Greetings:
Please consider the following fix for a minor memory issue that I found in the
file: src/solaris/native/java/lang/UNIXProcess_md.c.
http://cr.openjdk.java.net/~jzavgren/8008118/webrev.01/
Thanks!
John Zavgren
len = 0;
123 }
David
-
On 9/02/2013 3:03 AM, John Zavgren wrote:
Greetings:
I posted a new webrev image:
http://cr.openjdk.java.net/~jzavgren/8007609/webrev.03/
<http://cr.openjdk.java.net/%7Ejzavgren/8007609/webrev.03/>
The sole "functional" revision is contai
py(tmp, p);
153 }
154 free(result);
155 result = tmp;
156 }
157 }
158 }
159
160 /* unable to get final path */
161 if (len == 0 && result != NULL) {
We reach here because len==0 and result != NULL
162 free(result);
163 result = NULL;
164 }
165 }
Looks fine to me.
David
-Chris.
--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA
t to be freed twice.
- Original Message -
From: alan.bate...@oracle.com
To: john.zavg...@oracle.com
Cc: core-libs-dev@openjdk.java.net
Sent: Wednesday, February 6, 2013 5:18:28 AM GMT -05:00 US/Canada Eastern
Subject: Re: RFR JDK-8007609
On 05/02/2013 23:49, John Zavgren wrote:
Original Message -From: alan.bate...@oracle.comTo:
john.zavg...@oracle.comCc: core-libs-dev@openjdk.java.netSent:
Wednesday, February 6, 2013 5:18:28 AM GMT -05:00 US/Canada EasternSubject:
Re: RFR JDK-8007609
On 05/02/2013 23:49, John Zavgren wrote:
Greetings:
I modi
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when there is
an error.
The webrev image of this change is visible at:
http://cr.openjdk.java.net/~jzavgren/8007609/webrev.01/
Thanks!
John
14 matches
Mail list logo
