On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
OK. I started with serviceability but then went through everything as it's
hard to reco
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 84:
> 82:
> 83: /**
> 84:
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/cds/filemap.cpp line 1914:
> 1912:
> 1913: // the current value o
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/interpreter/bytecodeUtils.cpp line 186:
> 184: static const int _max
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/opto/graphKit.cpp line 3626:
> 3624: // The optional arguments are for
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348:
> 346:
> 347: /**
>
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.sctp/share/classes/com/sun/nio/sctp/ShutdownNotification.java line 28:
> 26:
>
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 21 Apr 2022 17:22:04 GMT, Magnus Ihse Bursie wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/invoker.h line 38:
>>
>>> 36: jboolean pending; /* Is an invoke requested? */
>>> 37: jboolean started; /* Is an invoke happening? */
>>> 38: jboolean available;/* Is
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd jdk.
On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote:
> I found [yet another
> typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948)
> ...
I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of
"slack space" meaning leftover space. W
On Tue, 5 Apr 2022 10:37:26 GMT, Kevin Walls wrote:
> A sanity check using "jcmd VM.info" to catch the signal handler modification
> warning: it should never trigger during this test.
(adding a note to trigger email notification, as that appears lost...)
On Thu, 13 Jan 2022 11:04:43 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/BatchUpdateException.java line 58:
>>
>>> 56: * A JDBC driver implementation should use
>>> 57: * the constructor {@code BatchUpdateException(String reason, String
>>> SQLState,
>>> 58: * int vendorCo
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
On Fri, 10 Dec 2021 07:00:10 GMT, Chris Plummer wrote:
> The test searches for "JShellToolProvider" in the main thread's stack trace,
> which is pulled from an SA heap dump. Typically the main thread is blocked in
> Object.wait(), so SA can determine its stack trace. However, the wait has a
>
On Thu, 1 Jul 2021 10:38:24 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
On Wed, 30 Jun 2021 11:49:51 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
stack frames, and thread locals should not
steal space from that.
The system property introduced in this change is an ugly workaround for that.
On Thu, Feb 18, 2016 at 2:24 AM, Kevin Walls wrote:
Hi Cheleswer,
Looks good to me.
Thanks
Kevin
(Also, as one of the comments was that there may be no
this issue will be safer at this point of time.
Regards,
Cheleswer
On 1/19/2016 5:40 PM, David Holmes wrote:
On 19/01/2016 9:53 PM, Kevin Walls wrote:
|
Hi Cheleswer, I think Martin is suggesting something like:
|
// Use a modest stack size, unless requested othe
|
Hi Cheleswer, I think Martin is suggesting something like:
|
// Use a modest stack size, unless requested otherwise:
long stackSize = Boolean.getBoolean("processReaperUseDefaultStackSize") ? 0 :
32768;
Thread t = new Thread(systemThreadGroup, grimReaper, "process reaper",
stackSize);
|||
If
Changeset: d36ad8686f6d
Author:kevinw
Date: 2010-12-21 11:32 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d36ad8686f6d
6968933: Clip loop() deadlock in DirectAudioDevice$DirectClip.run
Reviewed-by: amenkov
! src/share/classes/com/sun/media/sound/DirectAudioDevice.java
Hi Alan,
That sounds familiar and looks good. (There has been some testing with
such a change already 8-) )
Regards
Kevin
On 29/09/2010 13:25, Alan Bateman wrote:
I need a reviewer for a small change to remove a debug message that
someone left when fixing a bug in the java.io implementati
Changeset: b8004f6f4812
Author:kevinw
Date: 2009-09-22 17:01 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8004f6f4812
6882768: (launcher) test for 6842838 is broken
Summary: Testcase correction.
Reviewed-by: ksrini
! test/tools/launcher/6842838/Test6842838.sh
Changeset:
Changeset: eb19c5dc52bf
Author:kevinw
Date: 2009-09-14 20:55 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb19c5dc52bf
6842838: 64-bit failure in handling invalid manifest in launcher.
Summary: Don't compare with hard-coded 32-bit -1 when checking zip fields.
Reviewed-by: k
Changeset: f9c187839d72
Author:kevinw
Date: 2009-02-24 19:03 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9c187839d72
6809463: Missing license header in test LargeZipFile.java
Reviewed-by: alanb
! test/java/util/zip/ZipFile/LargeZipFile.java
Changeset: dde3fe2e8164
Autho
Changeset: dc237aecf7cf
Author:kevinw
Date: 2009-02-24 14:22 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc237aecf7cf
6599383: Unable to open zip files more than 2GB in size
Reviewed-by: alanb
! src/share/native/java/util/zip/zip_util.c
! src/share/native/java/util/zip/zi
29 matches
Mail list logo
