Re: RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

2020-04-27 Thread Kiran Ravikumar
#x27; (I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't) (I help keep Google's java programs up to date with tzdata) On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar <mailto:kiran.sidhartha.raviku...@oracle.com>> wrote:

RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

2020-04-27 Thread Kiran Ravikumar
Hello All, Please review the patch for tzdata2020a integration into jdk. Release details can be found here: http://mm.icann.org/pipermail/tz-announce/2020-April/58.html Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-824354

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

2020-02-05 Thread Kiran Ravikumar
would have added a plain iterator test, and might have refactored the code that tests the exception. On Wed, Jan 15, 2020 at 4:07 AM Kiran Ravikumar <mailto:kiran.sidhartha.raviku...@oracle.com>> wrote: Hi Guys, Could someone please review my fix to add missing standard

RFR [15] 8161558: ListIterator should not discard cause on exception

2020-01-15 Thread Kiran Ravikumar
Hi Guys, Could someone please review my fix to add missing standard constructor overloads to NoSuchElementException class and update the AbstractList class to use them. A CSR was filed and approved. Along with the code change a new test is added to verify the behavior. Please find the w

RFR 8233187: Return Empty List if 0 Copies Requested in Collections nCopies

2019-11-14 Thread Kiran Ravikumar
Hi Guys, Please review the following optimization to nCopies method to return empty list and to avoid instantiating an empty CopiesList object. JBS link : https://bugs.openjdk.java.net/browse/JDK-8233187 Patch: diff -r f279d8a9bb78 src/java.base/share/classes/java/util/Collections.java --

RFR 8233731: repeated typo "fro" for "for"

2019-11-13 Thread Kiran Ravikumar
Hey Guys, Please review the correction of a typo from 'fro' to 'for' in java.util.Arrays class. Thanks, Kiran *Patch :* @@ -2599,7 +2599,7 @@   *   first array to be tested   * @param aToIndex the index (exclusive) of the last element in the   *

RFR: 8232984: Upgrading Joni License version to 2.1.16

2019-11-04 Thread Kiran Ravikumar
Hi, Please review this patch to update the joni version to 2.1.16. JBS: https://bugs.openjdk.java.net/browse/JDK-8232984 License File: https://github.com/jruby/joni/blob/joni-2.1.16/LICENSE Patch File: diff -r ab4db38ed085 src/jdk.scripting.nashorn/share/legal/joni.md --- a/src/jdk.scripting

RFR: JDK-8231770 - Test java/util/zip/FlaterTest.java fails with -Xcheck:jni

2019-10-08 Thread Kiran Ravikumar
Hi Guys, I am a new hire with the Oracle Java Platform Group and will be working mainly on JDK Update releases. Below is my first contribution. Looking forward to contribute more to the community. Please review the fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8231770 Webrev :https://cr.