Kindly reminder.
Already approved by C. Thalinger and I. Ignatyev.
Thanks
-Konstantin
On 12/17/2015 11:26 AM, Konstantin Shefov wrote:
Hi Coleen
You have previously reviewed this enhancement and made a few comments
I have resolved them, so could you look at the webrevs again, please?
I have
/8141615/jdk/webrev.04
HOTSPOT: http://cr.openjdk.java.net/~kshefov/8141615/hotspot/webrev.02
Thanks
-Konstantin
On 12/16/2015 07:42 PM, Christian Thalinger wrote:
Looks good. Thanks.
On Dec 16, 2015, at 1:13 AM, Konstantin Shefov
wrote:
Christian
I have fixed the enum so it uses
Christian
I have fixed the enum so it uses "ENUMENTRY(int)" format now and does
linear search.
http://cr.openjdk.java.net/~kshefov/8141615/jdk/webrev.04/
-Konstantin
On 12/15/2015 08:36 PM, Christian Thalinger wrote:
On Dec 14, 2015, at 11:11 PM, Konstantin Shefov
mailto:kons
Hi Christian
Thanks for reviewing, I have changed indents as you asked:
http://cr.openjdk.java.net/~kshefov/8141615/jdk/webrev.03
-Konstantin
On 12/15/2015 06:23 AM, Christian Thalinger wrote:
On Dec 11, 2015, at 1:54 AM, Konstantin Shefov
mailto:konstantin.she...@oracle.com>>
are no tests for other s.r.CP methods,
could you please file an RFE against core-libs/j.l.reflect to cover them?
Thanks,
— Igor
On Dec 11, 2015, at 2:54 PM, Konstantin Shefov
wrote:
Hello
Please review the new version on the patch.
New webrev:
Webrev hotspot: http://cr.openjdk.java.net
codes 100 - 105 from being passed to java and left
only codes from the open JVM spec
(https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.4-140).
Thanks
-Konstantin
On 11/27/2015 07:48 PM, Konstantin Shefov wrote:
Coleen,
Thanks for review
On 11/24/2015 07:33 PM, Coleen
this constant
pool implementation but it seems very unsafe if the class is redefined
and relies on an implementation detail in the JVM that can change. I
will have more comments once I look more at the jvmti specification.
thanks,
Coleen
On 11/24/15 9:48 AM, Konstantin Shefov wrote:
Hello
Ple
x)
that returns the nameAndType index and to reuse
getNameAndTypeRefInfoAt(index) to get the corresponding array of
Strings.
cheers,
Rémi
- Mail original -
De: "Christian Thalinger"
À: "Konstantin Shefov"
Cc: "hotspot-dev developers" ,
core-libs-dev@openjd
hat returns the nameAndType index and to reuse getNameAndTypeRefInfoAt(index)
to get the corresponding array of Strings.
cheers,
Rémi
- Mail original -
De: "Christian Thalinger"
À: "Konstantin Shefov"
Cc: "hotspot-dev developers" ,
core-libs-dev@openjdk.java.net
Vladimir,
Please review the modified test.
Thanks
-Konstantin
On 08/06/2015 05:49 PM, Konstantin Shefov wrote:
Please, look at the modified test
http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/
-Konstantin
On 08/06/2015 02:06 PM, Konstantin Shefov wrote:
Hi Vladimir
Thanks for
Hello,
Please review a test bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8133543
Webrev: http://cr.openjdk.java.net/~kshefov/8133543/webrev.00/
-Konstantin
Kindly reminder.
06.08.2015 17:49, Konstantin Shefov пишет:
Please, look at the modified test
http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/
-Konstantin
On 08/06/2015 02:06 PM, Konstantin Shefov wrote:
Hi Vladimir
Thanks for reviewing
On 08/06/2015 01:02 PM, Vladimir Ivanov wrote
Please, look at the modified test
http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/
-Konstantin
On 08/06/2015 02:06 PM, Konstantin Shefov wrote:
Hi Vladimir
Thanks for reviewing
On 08/06/2015 01:02 PM, Vladimir Ivanov wrote:
Konstantin,
Overall, looks good.
Why do you create a new
SS.getSimpleName()
++ "$TestSubClass1");
I see BCP-to-BCP & non-BCP-to-non-BCP ref-to-ref cases covered. What
about BCP-to-non-BCP & non-BCP-to-BCP cases?
Best regards,
Vladimir Ivanov
On 8/3/15 6:06 PM, Konstantin Shefov wrote:
Michael, thanks for reviewing!
Kindly reminder
On 08/03/2015 06:06 PM, Konstantin Shefov wrote:
Michael, thanks for reviewing!
Vladimir, could you take a look, please?
-Konstantin
On 08/02/2015 05:31 PM, Michael Haupt wrote:
Hi Konstantin,
Am 31.07.2015 um 18:37 schrieb Konstantin Shefov
mailto:konstantin.she
Michael, thanks for reviewing!
Vladimir, could you take a look, please?
-Konstantin
On 08/02/2015 05:31 PM, Michael Haupt wrote:
Hi Konstantin,
Am 31.07.2015 um 18:37 schrieb Konstantin Shefov
mailto:konstantin.she...@oracle.com>>:
Please review a test improvement. Covered more cas
Hello,
Please review a test improvement. Covered more cases for
MethodHandles.explicitCastArguments().
Bug: https://bugs.openjdk.java.net/browse/JDK-8060717
Webrev: http://cr.openjdk.java.net/~kshefov/8060717/webrev.00/
-Konstantin
CC'ed more reviewers
On 07/20/2015 02:28 PM, Konstantin Shefov wrote:
Hello,
Please review a test bug fix.
An exception caused by code cache overflow should be re-thrown before
assertion check in the test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8130006
Webrev:
Hello,
Please review a test bug fix.
An exception caused by code cache overflow should be re-thrown before
assertion check in the test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8130006
Webrev: http://cr.openjdk.java.net/~kshefov/8130006/webrev.00/
-Konstantin
Hi Alan,
Please review updated patch. I made it using the tool Alexander
Kulyakhtin has given me.
http://cr.openjdk.java.net/~kshefov/8129595/webrev.01/
Thanks
-Konstantin
On 06/24/2015 01:52 PM, Alan Bateman wrote:
On 24/06/2015 11:29, Konstantin Shefov wrote:
Alan,
Do the tests form
in
On 06/24/2015 01:08 PM, Alan Bateman wrote:
On 24/06/2015 11:01, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8129595
Webrev is http://cr.openjdk.java.net/~kshefov/8129595/webrev.00/
security-dev would be a better place to review t
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8129595
Webrev is http://cr.openjdk.java.net/~kshefov/8129595/webrev.00/
Thanks
-Konstantin
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8129532
Webrev is http://cr.openjdk.java.net/~kshefov/8129532/webrev.00/
Thanks
-Konstantin
s?). They aren't
general enough to be useful for other tests.
Also, processVME name is confusing. I'd introduce something like a
runMHTest wrapper and process exceptions there.
Best regards,
Vladimir Ivanov
On 6/17/15 1:19 PM, Konstantin Shefov wrote:
Hello,
Please review the
.
Best regards,
Vladimir Ivanov
On 6/17/15 1:21 PM, Konstantin Shefov wrote:
Hello,
I have updated the fix once more
http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/
Please, review
Thanks
-Konstantin
On 06/16/2015 02:01 PM, Konstantin Shefov wrote:
Hello,
Please, review the new version of
/17/15 1:21 PM, Konstantin Shefov wrote:
Hello,
I have updated the fix once more
http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/
Please, review
Thanks
-Konstantin
On 06/16/2015 02:01 PM, Konstantin Shefov wrote:
Hello,
Please, review the new version of the fix to this issue
http
Hello,
I have updated the fix once more
http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/
Please, review
Thanks
-Konstantin
On 06/16/2015 02:01 PM, Konstantin Shefov wrote:
Hello,
Please, review the new version of the fix to this issue
http://cr.openjdk.java.net/~kshefov/8062904
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8067005
Webrev is http://cr.openjdk.java.net/~kshefov/8067005/webrev.00/
Thanks
-Konstantin
est bug, it looks very similar
to JDK-8046809. have you tried to run the tests on the build where
JDK-8046809 is fixed?
Igor
On 11/06/2014 06:20 PM, Konstantin Shefov wrote:
Igor,
Thanks for your comment!
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
-K
.
TLSUnSupportedCiphersTest.java:
replease "UnSupported" with "Unsupported".
typo: replace "UnSupported" with "Unsupported".
Thanks,
Xuelei
On 6/8/2015 11:04 PM, Konstantin Shefov wrote:
Hello,
Please review distribution of some DTLS feature tests to TLS pr
d and adjust other tests where hard coded limits are
set.
Best regards,
Vladimir Ivanov
On 6/8/15 7:22 PM, Konstantin Shefov wrote:
Vladimir,
You were right when you said that problem is not in JDK 8u.
I have examined the test code once more and found the following.
In JDK 9 because of the
Hello,
Please review distribution of some DTLS feature tests to TLS protocol.
Some DTLS tests may also be used to test the same functionality in TLS
protocol and its versions.
It is test only improvement.
bug: https://bugs.openjdk.java.net/browse/JDK-8085979
webrev: http://cr.openjdk.java.net/
her
manifestations of the problem?
Best regards,
Vladimir Ivanov
On 28.05.2015 21:22, Vladimir Ivanov wrote:
Got it, thanks.
Can we ignore errors caused by code cache overflow for now?
Best regards,
Vladimir Ivanov
On 5/28/15 12:03 PM, Konstantin Shefov wrote:
Vladimir,
This fix is not f
Please approve direct backport.
bug: https://bugs.openjdk.java.net/browse/JDK-8068416
jdk9 review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033998.html
jdk8u-dev webrev: http://cr.openjdk.java.net/~kshefov/8068416/webrev.02
Thanks,
-Konstantin
Otherwise, looks good.
Best regards,
Vladimir Ivanov
On 6/5/15 12:48 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8068416
Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.01/
Test failure is caused by JDK-8078602 [1
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8068416
Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.01/
Test failure is caused by JDK-8078602 [1]. Suggestion is to exclude the
test until [1] is fixed.
[1] https://bugs.openjdk.java.net/browse/JDK
exclude the test with "@ignore 8078602" tag.
[1] https://bugs.openjdk.java.net/browse/JDK-8078602
-Konstantin
On 06/04/2015 02:28 PM, Konstantin Shefov wrote:
Vladimir
On 06/04/2015 02:19 PM, Vladimir Ivanov wrote:
Konstantin,
In all cases when OOME happens the test ope
=DTLS -Dtest.mode=norm
DTLSBufferOverflowUnderflowTest
+ * @run main/othervm -Dtest.security.protocol=DTLS
+ * -Dtest.mode=norm DTLSBufferOverflowUnderflowTest
Thanks,
Xuelei
On 6/2/2015 8:15 PM, Konstantin Shefov wrote:
Hello,
Please review new tests fro DTLS feature for JDK 9:
bug:
that case I'd prefer the test to be excluded
until BMHs are converted to VM anonymous classes.
Best regards,
Vladimir Ivanov
[1] https://bugs.openjdk.java.net/browse/JDK-8078602
On 6/4/15 12:10 PM, Konstantin Shefov wrote:
Igor,
It seems I have given you wrong information. This test fail
product failure.
[1] https://bugs.openjdk.java.net/browse/JDK-8062904
-Konstantin
On 06/03/2015 12:44 PM, Konstantin Shefov wrote:
Hi Vladimir
On 02.06.2015 21:51, Vladimir Ivanov wrote:
Konstantin,
It seems we have only this bug that manifests the problem. As I
understand, this is a product
browse/JDK-8078602
On 6/4/15 12:10 PM, Konstantin Shefov wrote:
Igor,
It seems I have given you wrong information. This test fails with OOME
against JDK 9 also, I managed to reproduce the failure now.
It was hard to reproduce it because of randomness, I need to rerun the
test 50 times. Although the
to failures on JDK 8u?
and please update the bug w/ gotten information.
Thanks,
Igor
On 06/04/2015 12:10 PM, Konstantin Shefov wrote:
Igor,
It seems I have given you wrong information. This test fails with OOME
against JDK 9 also, I managed to reproduce the failure now.
It was hard to reproduce
which
should be fixed and your fix just hides it.
Igor
On 06/03/2015 10:14 PM, Seán Coffey wrote:
I bumped into this failure myself today. I think you've got a typo.
440 should be 40. Looks like a good approach otherwise.
Regards,
Sean.
On 03/06/2015 17:33, Konstantin Shefov wrote:
17:33, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8068416
Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.00/
Test fails only against JDK 8u and passes against JDK 9.
Fix is to reduce the number of iterations to 40. With
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8068416
Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.00/
Test fails only against JDK 8u and passes against JDK 9.
Fix is to reduce the number of iterations to 40. With that number of
iterations the
,
Vladimir Ivanov
On 5/28/15 12:03 PM, Konstantin Shefov wrote:
Vladimir,
This fix is not for timeout issue, this fix is for
"java.lang.VirtualMachineError: out of space in CodeCache for
adapters".
Timeout issue is other bug and should be filed separately.
I do not know why SQE added RU
Hello,
Please review new tests fro DTLS feature for JDK 9:
bug: https://bugs.openjdk.java.net/browse/JDK-8072515
webrev: http://cr.openjdk.java.net/~kshefov/8072515/webrev.00/
Thanks
-Konstantin
t it, thanks.
Can we ignore errors caused by code cache overflow for now?
Best regards,
Vladimir Ivanov
On 5/28/15 12:03 PM, Konstantin Shefov wrote:
Vladimir,
This fix is not for timeout issue, this fix is for
"java.lang.VirtualMachineError: out of space in CodeCache for
adapters".
by code cache overflow for now?
Best regards,
Vladimir Ivanov
On 5/28/15 12:03 PM, Konstantin Shefov wrote:
Vladimir,
This fix is not for timeout issue, this fix is for
"java.lang.VirtualMachineError: out of space in CodeCache for adapters".
Timeout issue is other bug and shoul
ore robust.
Best regards,
Vladimir Ivanov
On 5/27/15 5:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8062904
Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
Test fails only against JDK 8u and passes against JDK
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8062904
Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
Test fails only against JDK 8u and passes against JDK 9.
Thanks
-Konstantin
mand).
On 23.01.2015 16:47, Seán Coffey wrote:
Konstantin,
can you hold off pushing this fix to jdk8u for the moment ? It's a P4
and could have behavioural consequences (something we try and avoid in
update releases). I see JDK-8071458 was logged to track IPv6 scope
specifications. Let
Kindly reminder
On 21.01.2015 18:29, Konstantin Shefov wrote:
Hello,
Please approve the direct backport of the test bug fix to 8u60
The webrev is slightly different from that for JDK 9, but only in line
numbers, all the rest is just the same.
The bug: https://bugs.openjdk.java.net/browse
Hello,
Please approve the direct backport of the bug fix to 8u-dev
Patch applies cleanly to JDK 8u.
The bug:https://bugs.openjdk.java.net/browse/JDK-6933879
The webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.01/
JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/801eb37fc
Kindly reminder
On 21.01.2015 16:06, Konstantin Shefov wrote:
Hi, Chris
I have done a pre-integration testing for this fix on Linux, Windows,
Mac and Solaris x64 and sparc. I have run all regression tests for
core libraries, and no new failures appeared.
Can I push this change now or
Hello,
Please approve the direct backport of the test bug fix to 8u60
The webrev is slightly different from that for JDK 9, but only in line
numbers, all the rest is just the same.
The bug: https://bugs.openjdk.java.net/browse/JDK-8067344
The 8u60 webrev: http://cr.openjdk.java.net/~kshefov/8
-Konstantin
On 16.01.2015 17:02, Chris Hegarty wrote:
On 16/01/15 12:50, Konstantin Shefov wrote:
Hi Chris, Alan, thank you for reviewing.
I have made a new webrev
http://cr.openjdk.java.net/~kshefov/6933879/webrev.01
I have removed ":" and added a test case.
This looks ok to me.
-Chris.
-
Hi Chris, Alan, thank you for reviewing.
I have made a new webrev
http://cr.openjdk.java.net/~kshefov/6933879/webrev.01
I have removed ":" and added a test case.
-Konstantin
16.01.2015 14:42, Chris Hegarty пишет:
On 16/01/15 11:29, Alan Bateman wrote:
On 16/01/2015 10:49, Chris Hegarty wrot
On 14.01.2015 15:56, Alan Bateman wrote:
Did we establish if this requires a specification change to clarify
the characters allowed in the host component?
Here
http://docs.oracle.com/javase/7/docs/api/java/net/Inet6Address.html#scoped
we can see that
"The scope_id refers to an interface on th
Kindly reminder
On 12.01.2015 17:37, Konstantin Shefov wrote:
Hello, Chris
You have asked "Have you seen NetworkInterface.getName() return names
with ‘_’, ’.’, or ‘:’ ,or is this theoretical?"
I can answer your question. I have named one of network interfaces on
my Linux de
));
returns exactly "eth0.1_55".
This means we can include dot "." and underscore "_" symbols to URI
scope id.
-Konstantin
On 11.12.2014 18:29, Chris Hegarty wrote:
On 11 Dec 2014, at 11:09, Konstantin Shefov
wrote:
CC'ed core-libs-dev@openjdk.java.ne
I for that.
-Konstantin
On 15.12.2014 14:25, Chris Hegarty wrote:
Konstantin,
I did reply to this RFR [1], with a question, that is still unanswered.
-Chris.
[1]
http://mail.openjdk.java.net/pipermail/net-dev/2014-December/008782.html
On 15/12/14 11:15, Konstantin Shefov wrote:
Gently remind
Gently reminder. Please review.
-Konstantin
On 11.12.2014 14:09, Konstantin Shefov wrote:
CC'ed core-libs-dev@openjdk.java.net
On 10.12.2014 18:21, Konstantin Shefov wrote:
Hello,
Please, review the bug fix:
https://bugs.openjdk.java.net/browse/JDK-6933879
Webrev:
CC'ed core-libs-dev@openjdk.java.net
On 10.12.2014 18:21, Konstantin Shefov wrote:
Hello,
Please, review the bug fix:
https://bugs.openjdk.java.net/browse/JDK-6933879
Webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.00
It is suggested to add some more symbols allowed for sco
Vladimir, Paul,
Please, look at this fix
http://cr.openjdk.java.net/~kshefov/8066798/webrev.04
Thanks
-Konstantin
On 10.12.2014 18:05, Igor Ignatyev wrote:
cool. reviewed.
--
Igor
On 12/10/2014 06:01 PM, Konstantin Shefov wrote:
Igor, I changed to printf and indent:
http
am::printf
otherwise LGTM
Thanks,
Igor
On 12/10/2014 03:25 PM, Konstantin Shefov wrote:
On 09.12.2014 16:50, Igor Ignatyev wrote:
on last thing to think about:
does it make sense to move 'if (!run.passed) { ... } else { ... }'
code into TestRun class?
Yes, here is a webrev:
htt
On 09.12.2014 16:50, Igor Ignatyev wrote:
on last thing to think about:
does it make sense to move 'if (!run.passed) { ... } else { ... }'
code into TestRun class?
Yes, here is a webrev: http://cr.openjdk.java.net/~kshefov/8066798/webrev.03
On 12/09/2014 04:03 PM, Konstantin Sh
174 t.printStackTrace();
175 System.err.println("FAILED");
you don't print exception message.
--
Igor
On 12/09/2014 02:19 PM, Konstantin Shefov wrote:
Hi Igor
Thanks for reviewing.
I have made some changes, added a separate class to store the variab
, you lose exception information, it's better not
to print exception's stack trace, but pass the exception to ctor of
Error.
Thanks,
Igor
On 12/09/2014 11:51 AM, Konstantin Shefov wrote:
Hello,
Please review the test enhancement
https://bugs.openjdk.java.net/browse/JDK-8066798
Webrev
Hello,
Please review the test enhancement
https://bugs.openjdk.java.net/browse/JDK-8066798
Webrev is http://cr.openjdk.java.net/~kshefov/8066798/webrev.00
Test has been modified to use
lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java class to define
its number of iterations depending o
Hello, Vladimir
I have updated the Webrev
http://cr.openjdk.java.net/~kshefov/8059070/webrev.02
I have added DEFAULT_TEST_TIMEOUT constant to Utils class.
-Konstantin
On 13.11.2014 15:48, Konstantin Shefov wrote:
Kindly reminder.
On 10.11.2014 17:45, Konstantin Shefov wrote:
Vladimir
Kindly reminder.
On 10.11.2014 17:45, Konstantin Shefov wrote:
Vladimir, thanks for reviewing
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8059070/webrev.02
I have added DEFAULT_TEST_TIMEOUT constant to Utils class.
-Konstantin
On 10.11.2014 14:33, Vladimir Ivanov wrote
4, 2:22 PM, Konstantin Shefov wrote:
Gently reminder
29.10.2014 17:25, Konstantin Shefov пишет:
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
Kindly reminder
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
06.11.2014 18:20, Konstantin Shefov пишет:
Igor,
Thanks for your comment!
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
-Konstantin
On 06.11.2014 17:36, Igor Ignatyev wrote
Gently reminder
29.10.2014 17:25, Konstantin Shefov пишет:
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
On Oct 23, 2014, at 1:25 PM
Igor,
Thanks for your comment!
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
-Konstantin
On 06.11.2014 17:36, Igor Ignatyev wrote:
Konstantin,
please use 'java.vm.info' instead of iteration over flags.
Igor
On 11/06/2014 01:44 PM, Konstan
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8062904
Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/
Thanks
-Konstantin
Gently reminder
29.10.2014 17:25, Konstantin Shefov пишет:
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
On Oct 23, 2014, at 1:25 PM
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
> Kindly reminder
>
> On 23.10.2014 19:04, Paul Sandoz wrote:
>> On Oct 23, 2014, at 1:25 PM, Konstantin Shefov
>> wrote
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
On Oct 23, 2014, at 1:25 PM, Konstantin Shefov
wrote:
Gently reminder
On 17.10.2014 13:38
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
On Oct 23, 2014, at 1:25 PM, Konstantin Shefov
wrote:
Gently reminder
On 17.10.2014 13:38, Konstantin Shefov wrote:
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
+1
Sorry for the delay,
Paul.
Gently reminder
On 17.10.2014 13:38, Konstantin Shefov wrote:
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
16.10.2014 17:24, Igor Ignatyev пишет:
Konstantin,
I haven't looked at code religiously, so I wouldn't say that I have
r
Gently reminder
On 17.10.2014 13:38, Konstantin Shefov wrote:
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
16.10.2014 17:24, Igor Ignatyev пишет:
Konstantin,
I haven't looked at code religiously, so I wouldn't say that I have
line.
On 10/16/2014 02:03 PM, Konstantin Shefov wrote:
Paul,
Thanks for reviewing
In the jtreg scripts of the three existing LFCaching tests timeout is
set explicitly to 300 seconds. The file currently being changed is not a
test itself, it is parent class of tests.
In fact we can unset thi
Sandoz wrote:
On Oct 16, 2014, at 10:43 AM, Konstantin Shefov
wrote:
Gently reminder
On 14.10.2014 16:58, Konstantin Shefov wrote:
Hello,
Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8059070
Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/
4
Sean, Rob
I have to reviews of this backport request (Vladimir is jdk 9 reviewer,
but not 8u40).
Can I get an approval for 8u40 in this case?
Thanks
-Konstantin
On 14.10.2014 14:50, Paul Sandoz wrote:
On Oct 14, 2014, at 10:26 AM, Konstantin Shefov
wrote:
Gently reminder
Please, review
Gently reminder
On 14.10.2014 16:58, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8059070
Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/
Thanks
-Konstantin
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8059070
Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/
Thanks
-Konstantin
Gently reminder
Please, review this test bug fix backport
-Konstantin
On 13.10.2014 18:24, Konstantin Shefov wrote:
On 10.10.2014 13:06, Konstantin Shefov wrote:
Hello,
Please review and approve the backport of the test bug fix to 8u40
The bug: https://bugs.openjdk.java.net/browse/JDK
Gently reminder
Please, review
-Konstantin
On 13.10.2014 19:04, Vladimir Ivanov wrote:
Looks good (not a Reviewer).
Best regards,
Vladimir Ivanov
On 10/13/14, 6:22 PM, Konstantin Shefov wrote:
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly
On 10.10.2014 13:06, Konstantin Shefov wrote:
Hello,
Please review and approve the backport of the test bug fix to 8u40
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The webrev: http://cr.openjdk.java.net/~kshefov/8058695/8u-dev/webrev.00
Thanks
-Konstantin
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshe
Thanks for reviewing! Pushed.
-Konstantin
10.10.2014 19:06, Vladimir Ivanov пишет:
Looks good.
Best regards,
Vladimir Ivanov
On 10/9/14, 12:44 PM, Konstantin Shefov wrote:
Hi,
I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http
Hello,
Please review and approve the backport of the test bug fix to 8u40
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The webrev: http://cr.openjdk.java.net/~kshefov/8058695/8u-dev/webrev.00
Thanks
-Konstantin
Gently reminder
On 09.10.2014 19:56, Joe Darcy wrote:
Looks fine Konstantin.
(These tests have been failing very often since they were pushed. If
your fix isn't pushed today, I'd argue for the tests being excluded.)
Please, review
Thanks,
-Joe
On 10/9/2014 1:44 AM, Konstan
failing
tests passing as modified.
Thanks,
-Joe
On 10/8/2014 7:38 AM, Konstantin Shefov wrote:
Daniel,
Thanks for your comment
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
On 08.10.2014 17:25, Daniel Fuchs wrote:
Hi Konstantin,
I'
an do:
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
On 08/10/14 15:15, Konstantin Shefov wrote:
Hello,
Please review th
14 17:24, Vladimir Ivanov wrote:
Konstantin,
What kind of testing have you done to verify the fix?
Best regards,
Vladimir Ivanov
On 10/8/14, 5:15 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.jav
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
TestMethods(String name) {
this.name = name;
+this.maxArity = Helper.MAX_ARITY;
}
please call TestMethods(String, int) from TestMethods(String) instead
of copy&paste.
Thanks,
Igor
On 10/01/2014 05:46 PM, Konstantin Shefov wrote:
Thanks for reviewing
1 - 100 of 112 matches
Mail list logo
