RFR: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103

Need to use proper synchronization. The CyclicBarriers might move the thread to WAITING state but not BLOCKED. So it should not confuse existing checks. - Commit messages: - 8287200 Changes: https://git.openjdk.java.net/jdk/pull/8874/files Webrev: https://webrevs.openjdk.java.net

RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

Sync improved in test - Commit messages: - 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp Changes: https://git.openjdk.java.net/jdk/pull/8821/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8821&range=00 Issue: https://bugs.op

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the failure >> handler command `dmesg` on macOS? >> >> As noted in the JBS issue, the command currently fails with permission >> error. The commit in this PR uses `sudo` as s

Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]

On Mon, 16 May 2022 01:23:09 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge >> - 8286368: Cleanup problem lists after loom inte

Integrated: 8286368: Cleanup problem lists after loom integration

On Mon, 9 May 2022 18:17:13 GMT, Leonid Mesnik wrote: > 8286368: Cleanup problem lists after loom integration This pull request has now been integrated. Changeset: dcec1d2a Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/dcec1d2a68e2c82e27174c3dc52bb17316530

Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]

> 8286368: Cleanup problem lists after loom integration Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge - 8286368: Cleanup problem lists after loom integration - Changes: ht

Re: RFR: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot [v2]

> Test executes method recursively and works too long. > > It the same issue as > [JDK-8139875](https://bugs.openjdk.java.net/browse/JDK-8139875) > > The test shouldn't be run with DeoptimizeALot Leonid Mesnik has updated the pull request incrementally with one addit

RFR: 8286438: Add jhsdb jstack processing without --mixed in efh

The default is required only to set the same depth level in the tree on HTML page for default and mixed mode. - Commit messages: - 8286438: Add jhsdb jstack processing without --mixed in efh Changes: https://git.openjdk.java.net/jdk/pull/8610/files Webrev: https://webrevs.openjdk.

RFR: 8286368: Cleanup problem lists after loom integration

8286368: Cleanup problem lists after loom integration - Commit messages: - 8286368: Cleanup problem lists after loom integration Changes: https://git.openjdk.java.net/jdk/pull/8604/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8604&range=00 Issue: https://bugs.openj

Integrated: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out This pull request has now been integrated. Changeset: 40470d83 Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/com

RFR: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot

Test executes method recursively and works too long. It the same issue as [JDK-8139875](https://bugs.openjdk.java.net/browse/JDK-8139875) The test shouldn't be run with DeoptimizeALot - Commit messages: - copyrights fixed - 8284980: Test vmTestbase/nsk/stress/except/except010.jav

Withdrawn: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8588

RFR: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

…resulting in failure to produce a stack when a test times out - Commit messages: - 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out Changes: https://git.openjdk.java.net/jdk/pull/8588/files Webrev:

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Fri, 29 Apr 2022 06:33:42 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/hotspot/jtreg/serviceability/jvmti/events/ClassPrepare/cla

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Fri, 29 Apr 2022 06:43:02 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/hotspot/jtreg/serviceability/jvmti/events/Exception/except

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Fri, 29 Apr 2022 06:09:35 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/break

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Fri, 29 Apr 2022 05:48:19 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/break

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8283800: Simplify String.indexOf/lastIndexOf calls

On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote: > In a few places String.indexOf/lastIndexOf methods are called with default > parameter for index: `0` for `indexOf`, length() for `lastIndexOf`. > I propose to cleanup such calls. It makes code a bit easier to read. In case > of `indexO

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v2]

On Fri, 21 Jan 2022 11:04:26 GMT, Aleksey Shipilev wrote: >> While working on JDK-8280003, I noticed that >> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays >> with more than 1-byte size elements, and no large arrays (past 4G limit) are >> tested either. It would be

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library [v3]

On Tue, 14 Dec 2021 15:20:31 GMT, Roger Riggs wrote: >> Compilation warnings of the test library introduce noise in test output and >> should be addressed or suppressed. >> Changes include: >> - SuppressWarnings("deprecation") and SuppressWarnings("removal") >> - Adding type parameters to Raw

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library [v2]

On Mon, 13 Dec 2021 20:58:50 GMT, Roger Riggs wrote: >> Compilation warnings of the test library introduce noise in test output and >> should be addressed or suppressed. >> Changes include: >> - SuppressWarnings("deprecation") and SuppressWarnings("removal") >> - Adding type parameters to Raw

Integrated: 8268626: Remove native pre-jdk9 support for jtreg failure handler

On Fri, 11 Jun 2021 18:44:38 GMT, Leonid Mesnik wrote: > jtreg failure handler uses native lib to implement getPid for preJDK9. > Currently. it is not needed and might be removed. This pull request has now been integrated. Changeset: 2e70bc35 Author:Leonid Mesnik URL:

RFR: 8268626: Remove native pre-jdk9 support for jtreg failure handler

jtreg failure handler uses native lib to implement getPid for preJDK9. Currently. it is not needed and might be removed. - Commit messages: - native lib support removed. Changes: https://git.openjdk.java.net/jdk/pull/4476/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr

Integrated: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes

On Thu, 27 May 2021 22:05:55 GMT, Leonid Mesnik wrote: > EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generat

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v6]

> EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generated. Leonid Mesnik has updated the pull request incremen

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

On Wed, 2 Jun 2021 01:00:53 GMT, Leonid Mesnik wrote: >> EFH is improved to process cores and get mixed stack traces with jhsdb and >> native stack traces with gdb/lldb. It might be useful because hs_err doesn't >> contain info about all threads, sometimes it is even no

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

On Wed, 9 Jun 2021 08:42:13 GMT, Igor Ignatyev wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spaces updated. > > test/failure_handler/src/share/classes/jdk/test/failurehandler/G

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

On Fri, 28 May 2021 02:14:45 GMT, Igor Ignatyev wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spaces updated. > > test/failure_handler/src/share/classes/jdk/test/failurehandler/act

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes

On Fri, 28 May 2021 00:54:21 GMT, Leonid Mesnik wrote: >> Hi Leonid, >> >> What is EFH? Please update the bug and PR to explain. >> >> Thanks, >> David > >> Hi Leonid, >> >> What is EFH? Please update the bug and PR to explain. >&

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

On Fri, 28 May 2021 02:25:59 GMT, Igor Ignatyev wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spaces updated. > > @lmesnik , how has this been tested? @iignatev, thank you for y

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

On Fri, 28 May 2021 02:20:04 GMT, Igor Ignatyev wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spaces updated. > > test/failure_handler/Makefile line 41: > >> 39:

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

> EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generated. Leonid Mesnik has updated the pull request incremen

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v4]

> EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generated. Leonid Mesnik has updated the pull request incremen

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v3]

> EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generated. Leonid Mesnik has updated the pull request incremen

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v2]

> EFH is improved to process cores and get mixed stack traces with jhsdb and > native stack traces with gdb/lldb. It might be useful because hs_err doesn't > contain info about all threads, sometimes it is even not generated. Leonid Mesnik has updated the pull request incremen

Re: RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes

On Thu, 27 May 2021 23:38:48 GMT, David Holmes wrote: > Hi Leonid, > > What is EFH? Please update the bug and PR to explain. > > Thanks, > David Updated summary to "Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes". - PR: https://g

RFR: 8267893: Improve EFH do get native/mixed stack traces for cores and live processes

EFH is improved to process cores and get mixed stack traces with jhsdb and native stack traces with gdb/lldb. It might be useful because hs_err doesn't contain info about all threads, sometimes it is even not generated. - Commit messages: - Merge branch 'master' of https://github.c

Re: RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

Looks good. Leonid On 6/4/20 10:21 AM, Igor Ignatyev wrote: piny? -- Igor On Jun 1, 2020, at 7:54 AM, Igor Ignatyev wrote: ping? -- Igor On May 27, 2020, at 10:25 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00 8 lines changed: 2 ins; 0 del; 6 mod; Hi

Re: RFR: 8236939: [TESTBUG] Incorrect initialization in java/foreign/TestArrays.java

Thanks for letting me know. I'll just close bug. Leonid > On Jan 12, 2020, at 11:39 PM, Nick Gasson wrote: > > Hi Leonid, > > On 11/01/2020 02:06, Leonid Mesnik wrote: >> --- a/test/jdk/java/foreign/TestArrays.java Wed Jan 01 03:08:45 2020 >> +010

Re: RFR: 8236939: [TESTBUG] Incorrect initialization in java/foreign/TestArrays.java

On 1/10/20 10:16 AM, Aleksey Shipilev wrote: On 1/10/20 7:06 PM, Leonid Mesnik wrote: I am going to push it in jdk/jdk only and not in jdk14. I suspect there would be some work around x86_32 before RDP2 hits, so maybe this can go into jdk/jdk14 as well? This would minimize the jdk/jdk14

RFR: 8236939: [TESTBUG] Incorrect initialization in java/foreign/TestArrays.java

Hi Could you please review following trivial fix which corrects type of used SequenceLayout in the java/foreign/TestArrays.java test. Really both long and double layouts are actually "MemoryLayout.ofValueBits(64L, ByteOrder.nativeOrder());" so this issue didn't cause test failure. I am going

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

Looks good. Leonid On 5/29/19 10:24 AM, Kim Barrett wrote: [I’m not completely sure where this RFR should be sent, but core-libs-dev and hotspot-dev seems likely to get reasonable coverage of those who might care.] Please review this change to the test library to add some "logging" output to t

Re: RFR: 8197901: Crash during GC when logging level is debug

id > > On 23/02/2018 12:41 PM, Leonid Mesnik wrote: >> Hi >> Could you please review following fix which update implementation of >> Klass::external_name for anonymous classes. >> Previously external_name tried to add hashcode of corresponding java_mirror >>

RFR: 8197901: Crash during GC when logging level is debug

Hi Could you please review following fix which update implementation of Klass::external_name for anonymous classes. Previously external_name tried to add hashcode of corresponding java_mirror for InstanceKlass if it exists. However the java_mirror could be incorrect during GC. Also external_nam

RFR(XXS): Exclude tools/jlink/CheckExecutable.java until 8182878 is fixed.

Hi Could you please review very small fix which quarantines test tools/jlink/CheckExecutable.java until corresponding infra issue is fixed. bug: https://bugs.openjdk.java.net/browse/JDK-8186581 diff: diff -r daed9a0332d3 test/ProblemList.txt -

Re: RFR(XS) 8184775: tools/launcher/modules/illegalaccess/IllegalAccessTest.java times out on some platforms…

test fail with any "slow" VM, e.g. fastdebug, -Xint, etc ? > > > On Fri, Jul 28, 2017 at 2:05 PM, Leonid Mesnik <mailto:leonid.mes...@oracle.com>> wrote: > Hi > > Please review following small fix which excludes test > tools/launcher/modules/illegalac

RFR(XS) 8184775: tools/launcher/modules/illegalaccess/IllegalAccessTest.java times out on some platforms…

Hi Please review following small fix which excludes test tools/launcher/modules/illegalaccess/IllegalAccessTest.java from execution in Xcomp mode. Test launches about 100 VMs and fails when -Xcomp is used. Tested locally with and without adding -Xcomp option. Webrev: http://cr.openjdk.java.net

Re: RFR : 8132961 : JEP 279 Improve Test-Failure Troubleshooting

Hi These changes were already reviewed internally. Looks good for me. Please get official review from Reviewers. Leonid On 24.11.2015 22:13, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8132961/webrev.00/ 3579 lines changed: 3579 ins; 0 del; 0 mod; 0 unchg Hi, Could you please