Integrated: JDK-8264454 : Jaxp unit test from open jdk needs to be improved

2021-04-08 Thread Mahendra Chhipa
On Tue, 30 Mar 2021 16:56:57 GMT, Mahendra Chhipa wrote: > JDK-8264454 : Jaxp unit test from open jdk needs to be improved This pull request has now been integrated. Changeset: 308f6796 Author: Mahendra Chhipa Committer: Joe Wang URL: https://git.openjdk.java.net/jdk/com

Re: RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved [v3]

2021-04-06 Thread Mahendra Chhipa
> JDK-8264454 : Jaxp unit test from open jdk needs to be improved Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Updated copyright year. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3274/files -

Re: RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved [v2]

2021-04-06 Thread Mahendra Chhipa
> JDK-8264454 : Jaxp unit test from open jdk needs to be improved Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3274/fi

Re: RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved

2021-04-06 Thread Mahendra Chhipa
On Wed, 31 Mar 2021 05:04:31 GMT, Joe Wang wrote: >> JDK-8264454 : Jaxp unit test from open jdk needs to be improved > > test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java line 200: > >> 198: } catch (IllegalStateException illegalStateException) { >> 199:

Re: RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved

2021-04-06 Thread Mahendra Chhipa
On Wed, 31 Mar 2021 04:19:46 GMT, Joe Wang wrote: >> JDK-8264454 : Jaxp unit test from open jdk needs to be improved > > test/jaxp/javax/xml/jaxp/unittest/common/Bug6350682.java line 47: > >> 45: @Test >> 46: public void testSAXParserFactory() { >> 47: runWithAllPerm(() -> >> Th

RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved

2021-03-30 Thread Mahendra Chhipa
JDK-8264454 : Jaxp unit test from open jdk needs to be improved - Commit messages: - JDK-8264454 : Jaxp unit test from open jdk needs to be improved - JDK-8064681 : Jaxp unit test need to be improved Changes: https://git.openjdk.java.net/jdk/pull/3274/files Webrev: https://webrevs

Withdrawn: JDK-8064681 : Jaxp unit test need to be improved

2021-03-30 Thread Mahendra Chhipa
On Mon, 22 Mar 2021 10:35:03 GMT, Mahendra Chhipa wrote: > https://bugs.openjdk.java.net/browse/JDK-8064681 This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/3115

Re: RFR: JDK-8064681 : Jaxp unit test need to be improved

2021-03-30 Thread Mahendra Chhipa
On Wed, 24 Mar 2021 14:47:56 GMT, Mark Sheppard wrote: >> https://bugs.openjdk.java.net/browse/JDK-8064681 > > the tests set a system property and then clear that system property at the > end of the test. Is it always the case that the property being set in the > test does not have a value pri

RFR: JDK-8064681 : Jaxp unit test need to be improved

2021-03-22 Thread Mahendra Chhipa
https://bugs.openjdk.java.net/browse/JDK-8064681 - Commit messages: - JDK-8064681 : Jaxp unit test need to be improved Changes: https://git.openjdk.java.net/jdk/pull/3115/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3115&range=00 Issue: https://bugs.openjdk.java.ne

Integrated: JDK-8261003 : Bad Copyright header format after JDK-8183372

2021-02-02 Thread Mahendra Chhipa
JDK-8261003 : Bad Copyright header format after JDK-8183372 - Commit messages: - JDK-8261003 : Bad Copyright header format after JDK-8183372 Changes: https://git.openjdk.java.net/jdk/pull/2365/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2365&range=00 Issue: https:

Integrated: JDK-8261003 : Bad Copyright header format after JDK-8183372

2021-02-02 Thread Mahendra Chhipa
On Tue, 2 Feb 2021 22:08:33 GMT, Mahendra Chhipa wrote: > JDK-8261003 : Bad Copyright header format after JDK-8183372 This pull request has now been integrated. Changeset: 9af33392 Author: Mahendra Chhipa Committer: Brent Christian URL: https://git.openjdk.java.net/jdk/com

Integrated: JDK-8183372 : Refactor java/lang/Class shell tests to java

2021-02-02 Thread Mahendra Chhipa
On Wed, 20 Jan 2021 17:27:43 GMT, Mahendra Chhipa wrote: > https://bugs.openjdk.java.net/browse/JDK-8183372 This pull request has now been integrated. Changeset: 6dc3c6dc Author: Mahendra Chhipa Committer: Brent Christian URL: https://git.openjdk.java.net/jdk/commit/6dc3c6dc St

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v12]

2021-02-02 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Generate the source files in JTWork directory. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/fi

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v11]

2021-02-02 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Using testNg Assert instead of assert. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files -

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v10]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: throwing the specific exceptions. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v9]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v8]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v7]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v6]

2021-01-29 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Reset the formatting. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v5]

2021-01-27 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented review comment. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:55:32 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/En

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v4]

2021-01-27 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:52:15 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/E

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 23:25:03 GMT, Florent Guillaume wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/forName/NonJa

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:56:25 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/En

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-25 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: ht

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

2021-01-25 Thread Mahendra Chhipa
On Fri, 22 Jan 2021 18:17:33 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different E

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

2021-01-25 Thread Mahendra Chhipa
On Fri, 22 Jan 2021 18:09:43 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different E

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

2021-01-25 Thread Mahendra Chhipa
On Fri, 22 Jan 2021 18:16:54 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different E

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

2021-01-25 Thread Mahendra Chhipa
On Fri, 22 Jan 2021 17:59:33 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different E

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java

2021-01-22 Thread Mahendra Chhipa
On Thu, 21 Jan 2021 05:19:00 GMT, Brent Christian wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Can this be done all in `EnclosingClassTest.java`, without a new > `RunEnclosingClassTest.java`? > > Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may > j

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

2021-01-22 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: NonJavaName Tests updated Used newInstance() method to create the different EnclosingClasses at runtime - Chan

RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java

2021-01-20 Thread Mahendra Chhipa
https://bugs.openjdk.java.net/browse/JDK-8183372 - Commit messages: - JDK-8183372 : Refactor java/lang/Class shell tests to java Changes: https://git.openjdk.java.net/jdk/pull/2170/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2170&range=00 Issue: https://bugs.openj

Integrated: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer

2021-01-13 Thread Mahendra Chhipa
On Fri, 4 Dec 2020 19:44:33 GMT, Mahendra Chhipa wrote: > jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 This pull request has now been integrated. Changeset: 5df2a949 Author:Mahendra Chhipa Committer: Daniel Fuchs URL:

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v6]

2021-01-12 Thread Mahendra Chhipa
On Tue, 12 Jan 2021 16:52:20 GMT, Daniel Fuchs wrote: > Approved provided that tier2 tests are passing. All tier2 tests related to changes are passing. Here is the Mach5 result link: https://mach5.us.oracle.com/mdash/jobs/mahendrachhipa-jdk-20210112-1759-17354032?search=result.status%3APASSED -

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v6]

2021-01-06 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Implemented the review comments - Merge branch 'maste

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v5]

2020-12-17 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Implemented the Review comments. - Implemented the review co

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v4]

2020-12-17 Thread Mahendra Chhipa
On Mon, 14 Dec 2020 19:44:59 GMT, Daniel Fuchs wrote: >> Mahendra Chhipa has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch 'JDK-8212035' of https://github.com/mahendrachhipa/jdk into &

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v4]

2020-12-11 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - Merge branch 'JDK-8212035' of https://github.com/mahendrachhipa/jdk i

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-11 Thread Mahendra Chhipa
On Tue, 8 Dec 2020 18:01:20 GMT, Daniel Fuchs wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/lib/jdk/test/lib/net/SimpleHtt

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v3]

2020-12-11 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemnted the review comments. - Changes: - all: https://git.openjdk.java.n

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-08 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.n

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-08 Thread Mahendra Chhipa
On Fri, 4 Dec 2020 20:45:24 GMT, Daniel Fuchs wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/lib/jdk/test/lib/net/SimpleHtt

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-08 Thread Mahendra Chhipa
On Fri, 4 Dec 2020 20:48:01 GMT, Daniel Fuchs wrote: >> test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80: >> >>> 78: creator.buildSignedMultiReleaseJar(); >>> 79: >>> 80: server = new >>> SimpleHttpServer(TESTCONTEXT,System.getProperty("user.dir", "."

RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer

2020-12-04 Thread Mahendra Chhipa
jaxp.library.SimpleHttpServer https://bugs.openjdk.java.net/browse/JDK-8212035 - Commit messages: - JDK-8212035 merge jdk.test.lib.util.SimpleHttpServer with Changes: https://git.openjdk.java.net/jdk/pull/1632/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1632&range=0

Integrated: JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

2020-12-01 Thread Mahendra Chhipa
On Fri, 27 Nov 2020 16:11:54 GMT, Mahendra Chhipa wrote: > …id as 1st word in @ignore > > https://bugs.openjdk.java.net/browse/JDK-8249836 This pull request has now been integrated. Changeset: c859fb02 Author: Mahendra Chhipa Committer: Igor Ignatyev URL:

Re: RFR: JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore [v2]

2020-12-01 Thread Mahendra Chhipa
> …id as 1st word in @ignore > > https://bugs.openjdk.java.net/browse/JDK-8249836 Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - /integrate Merge branch 'JDK-8249836' of https://github.com/mahendrac

RFR: JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

2020-11-27 Thread Mahendra Chhipa
…id as 1st word in @ignore https://bugs.openjdk.java.net/browse/JDK-8249836 - Commit messages: - JDK-8249836 ava/io/IOException/LastErrorString.java should have - JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore - JDK-8249836 java/io/