On Thu, 16 Dec 2021 22:16:26 GMT, Mark Reinhold wrote:
> Please review this tiny specification clarification.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/39
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/34
On Wed, 15 Dec 2021 17:56:23 GMT, Vladimir Kozlov wrote:
>> A proper fix for this is to use the catchException combination. However,
>> that introduces significant cold startup performance regression. JDK-8278447
>> tracks the work to address the performance regression using catchException
>>
On Wed, 15 Dec 2021 17:15:46 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/oops/method.cpp line 827:
>>
>>> 825: */
>>> 826: bool Method::can_omit_stack_trace() {
>>> 827: if
>>> (method_holder()->class_loader_data()->is_boot_class_loader_data()) {
>>
>> Do you actually need to check
On Wed, 15 Dec 2021 05:59:45 GMT, Vladimir Kozlov wrote:
> A proper fix for this is to use the catchException combination. However, that
> introduces significant cold startup performance regression. JDK-8278447
> tracks the work to address the performance regression using catchException
> and
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
> - Adding type parameters to Raw
On Mon, 6 Dec 2021 18:19:39 GMT, Alan Bateman wrote:
>> Deprecate the sun.misc.Unsafe methods that return field offsets. These
>> method are an impediment to possible future changes. Layout may not be fixed
>> in the future, the VM should be allowed to re-layout dynamically based on
>>
On Wed, 10 Nov 2021 11:59:16 GMT, Hendrik Schreiber
wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference
On Tue, 30 Nov 2021 14:52:37 GMT, Alan Bateman wrote:
> Thread.stop is inherently unsafe and has been deprecated since Java 1.2
> (1998). It's time to terminally deprecate this method so it can be degraded
> and removed in the future.
>
> This PR does not propose any changes to the JVM TI
On Wed, 24 Nov 2021 12:32:32 GMT, Michael Hall wrote:
> Would there be any need to scan class path at all? That would mean a module
> would have a class path dependency wouldn't it?
One reason of scanning the class path is to detect any split packages and emit
warnings.
> Yes, I shouldn't
On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor fix to avoid casting
>
> Hello Mandy, one small issue - `Class
On Tue, 23 Nov 2021 20:54:55 GMT, Mandy Chung wrote:
> jdeps intends to report an error if there are multiple versions of the same
> class being parsed. module-info.class should be excluded from such
> detection.
>
> This patch also fixes a data race in `VersionHelper::set` a
ureTask of parsing the classes throws an
> exception to report `MultiReleaseException` properly.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
minor fix to avoid casting
-
Changes:
- all: https://git.openjdk.j
On Wed, 24 Nov 2021 10:05:11 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor fix to avoid casting
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Dep
This changes jdeps -cp to ignore files/directories with no permission to
access. This is consistent with the runtime behavior.
-
Commit messages:
- JDK-8277375: jdeps errors on a class path with a file path with no permission
Changes:
jdeps intends to report an error if there are multiple versions of the same
class being parsed. module-info.class should be excluded from such detection.
This patch also fixes a data race in `VersionHelper::set` and also unwraps the
`ExecutionException` when FutureTask of parsing the classes
On Tue, 23 Nov 2021 10:04:51 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort
On Sat, 20 Nov 2021 19:13:43 GMT, Mandy Chung wrote:
> java.lang.reflect.Field::set on static field with invalid argument type
> should throw IAE. But this regression is introduced by JEP 416 throwing NPE
> instead.
>
> `ensureObj` is called as the first check of the `Fie
umentException is thrown first before IllegalAccessException to
> keep the existing behavior to avoid duplicated receiver check.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
Improve the exception message when the type is not
On Sun, 21 Nov 2021 21:05:19 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/reflect/MethodHandleFieldAccessorImpl.java
>> line 72:
>>
>>> 70: */
>>> 71: protected IllegalArgumentException
>>> newGetIllegalArgumentException(Object o) {
>>> 72: return new
java.lang.reflect.Field::set on static field with invalid argument type should
throw IAE. But this regression is introduced by JEP 416 throwing NPE instead.
`ensureObj` is called as the first check of the `Field::set` method to ensure
the receiver object is checked first before the argument.
On Fri, 19 Nov 2021 21:22:28 GMT, Andrew Leonard wrote:
> I've added updates to the jar and jmod man pages, as "Notes" about ordering,
> does that sound reasonable?
The true source of the man pages are still kept in our closed repository. The
copy in the jdk repo is generated from our
On Fri, 19 Nov 2021 18:15:46 GMT, Brent Christian wrote:
>> src/java.base/share/classes/java/lang/Object.java line 481:
>>
>>> 479: * system resources or to perform other cleanup.
>>> 480: *
>>> 481: * When running in a Java virtual machine in which finalization
>>> has been
>>
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API
On Fri, 19 Nov 2021 18:33:31 GMT, Lance Andersen wrote:
>> My thought is to remove it from this PR, since we've already determined the
>> change has little impact.
>> We can raise a new issue if we feel it's needed.
>
> The benchmark should use JMH. @cl4es, what are your thoughts here?
> My
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote:
> The `jdk.internal.ValueBased` annotation was incorrectly applied to
> subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
> requires that
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort
On Thu, 18 Nov 2021 11:40:24 GMT, Magnus Ihse Bursie wrote:
>> @magicus
>> ah right, got you. So the order of each version's String[] is as ordered on
>> the jar cmd line args:
>>
On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard wrote:
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing
On Thu, 18 Nov 2021 22:04:52 GMT, Stuart Marks wrote:
>> I renamed the function to `is_finalization_enabled` per previous comment,
>> and I also made these cleanups.
>
> Regarding using system properties, my initial prototype did this in the
> launcher, and it did run into the problem that the
On Thu, 18 Nov 2021 20:05:15 GMT, Stuart Marks wrote:
>> Pretty much what it says. The new option controls a static member in
>> InstanceKlass that's consulted to determine whether the finalization
>> machinery is activated for instances when a class is loaded. A new native
>> method is added
On Thu, 18 Nov 2021 06:49:03 GMT, Kim Barrett wrote:
>> src/hotspot/share/prims/jvm.cpp line 694:
>>
>>> 692:
>>> 693: JVM_ENTRY(jboolean, JVM_IsFinalizationEnabled(JNIEnv * env))
>>> 694: return InstanceKlass::finalization_enabled() ? JNI_TRUE : JNI_FALSE;
>>
>> missing indentation
>
> I
On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard wrote:
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementa
On Mon, 15 Nov 2021 07:33:00 GMT, Martin Grigorov wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 43 commits:
>>
>> - fix copyright header and typo
>> - improve documentatio
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Mon, 8 Nov 2021 16:05:12 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which seeks to implement the
>> enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8153133?
>>
>> The commit in this PR uses the `StackWalker` API to dump the stacktrace of
>> the
On Mon, 8 Nov 2021 13:27:17 GMT, Hendrik Schreiber
wrote:
>> src/java.base/share/classes/java/lang/ref/Cleaner.java line 93:
>>
>>> 91: *
>>> 92: *// Static state class, capturing information necessary for
>>> 93: *// cleanup, but no reference to the instance being cleaned
On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber
wrote:
> Trivial improvement.
>
> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
> Repeat (again) in the code example that the `State` `Runnable `should be
> implemented as static class and not reference the
On Fri, 5 Nov 2021 09:03:59 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes the
> `JLinkReproducibleTest` and `JLinkReproducible3Test` tests from the
> `ProblemList.txt`?
>
> With the fix for https://bugs.openjdk.java.net/browse/JDK-8275509 now merged,
> I
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung wrote:
> The dot graph should print the edges in alphatical order. A simple fix to
> sort the edges before printing them.
This pull request has now been integrated.
Changeset: e21b5c7b
Author: Mandy Chung
URL:
On Thu, 4 Nov 2021 21:46:21 GMT, Anthony Vanelverdinghe
wrote:
>> The dot graph should print the edges in alphatical order. A simple fix to
>> sort the edges before printing them.
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java line 336:
>
>> 334: private
The dot graph should print the edges in alphatical order. A simple fix to
sort the edges before printing them.
-
Commit messages:
- JDK-8276650: GenGraphs does not produce deterministic output
Changes: https://git.openjdk.java.net/jdk/pull/6266/files
Webrev:
On Thu, 4 Nov 2021 16:41:11 GMT, Ludvig Janiuk wrote:
> Added row headers missing in the table captioned "Access mode summary". This
> carries no visual change, but might be useful for screen readers.
Looks okay. Thanks for improving the documentation accessibility.
-
Marked as
On Thu, 4 Nov 2021 16:18:45 GMT, Ludvig Janiuk wrote:
> Inferring from the flow of the text, the table should have been a list all
> along, so I've made it that way. Before and after for comparison:
>
On Thu, 4 Nov 2021 16:18:45 GMT, Ludvig Janiuk wrote:
> Inferring from the flow of the text, the table should have been a list all
> along, so I've made it that way. Before and after for comparison:
>
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by core-libs. This
> scripts verifies that modifiers are in the "blessed" order, and fixes it
> otherwise. I have manually checked the changes made by the script to make
> sure
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote:
> At the time Java supported applets and webstart, a special mechanism for
> launching various applications in one JVM was used to reduce memory usage and
> each application was isolated from each other.
>
> This isolation was
On Mon, 11 Oct 2021 20:55:23 GMT, Mandy Chung wrote:
> Classes compiled prior to the nestmate support will generate
> `REF_invokeSpecial` if the implementation method is a private instance
> method. Since a lambda proxy class is a hidden class, a nestmate of the
> host class, i
ly to ensure the adjustment is only made if the
> implementation method is private method in the host class.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
convert to TestNG test
-
Changes:
- all: https://git.openjd
On Thu, 5 Aug 2021 23:51:13 GMT, Mandy Chung wrote:
> This reimplements core reflection with method handles.
>
> For `Constructor::newInstance` and `Method::invoke`, the new implementation
> uses `MethodHandle`. For `Field` accessor, the new implementation uses
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementa
On Thu, 28 Oct 2021 13:03:56 GMT, Severin Gehwolf wrote:
> Please review this change to remove some API which no longer works as
> expected as recent OCI runtimes start to drop support for `--kernel-memory`
> switch. See the bug for references. This part of the API is not present in
> hotspot
On Tue, 26 Oct 2021 22:51:29 GMT, Mandy Chung wrote:
> On, macOS 11.x, system libraries are loaded from dynamic linker cache. The
> libraries are no longer present on the filesystem.
> `NativeLibraries::loadLibrary` checks for the file existence before calling
> `JVM
On Mon, 25 Oct 2021 21:39:34 GMT, Dan Smith wrote:
> I'd suggest invoking the LMF API directly instead, testing both private and
> non-private invokespecial MethodHandles, just making sure the rules can be
> used without error.
That's a good idea. I updated the test and see what you think.
ly to ensure the adjustment is only made if the
> implementation method is private method in the host class.
Mandy Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request with a new target base due to a
On Wed, 27 Oct 2021 18:25:40 GMT, Alan Snyder wrote:
> I never load system libraries directly. I load my own libraries (that support
> JNI entry points) and the system loader loads the necessary system frameworks
> that they were linked against.
>
> What's different in this case that
his proposes
> that on macOS >= 11, it will skip the file existence check and attempt to
> load a library for each path from java.library.path and system library path.
Mandy Chung has updated the pull request incrementally with two additional
commits since the last revision:
- Adju
On Wed, 27 Oct 2021 02:51:24 GMT, Jaikiran Pai wrote:
>> On, macOS 11.x, system libraries are loaded from dynamic linker cache. The
>> libraries are no longer present on the filesystem.
>> `NativeLibraries::loadLibrary` checks for the file existence before calling
>> `JVM_LoadLibrary`.
On Wed, 27 Oct 2021 03:39:39 GMT, Jaikiran Pai wrote:
> So, I think, the whole point of this change in this block is to skip the file
> existence check and return back a file path.
exactly.
-
PR: https://git.openjdk.java.net/jdk/pull/6127
On Wed, 27 Oct 2021 14:08:05 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 40 commits:
>>
>> - Fall back to the VM native reflection support if method hand
On, macOS 11.x, system libraries are loaded from dynamic linker cache. The
libraries are no longer present on the filesystem.
`NativeLibraries::loadLibrary` checks for the file existence before calling
`JVM_LoadLibrary`. Such check no longer applies on Big Sur. This proposes
that on
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request with a new target base due to
On Mon, 25 Oct 2021 22:39:47 GMT, intrigus wrote:
> Question: Can someone confirm that `Method.invoke` will still work with 255
> parameters after this PR gets merged?
Thanks for the test case. For the case when method handles cannot be created
due to the arity limit, it can fall back to the
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request incrementally with one addit
On Fri, 15 Oct 2021 15:09:23 GMT, Peter Levart wrote:
>> It's not driven by performance data. It's part of Peter's contribution.
>> I also prefer it without the packing. I propose to keep the parameter
>> count as a separate field and examine it when there is footprint issue.
>
> The
On Wed, 13 Oct 2021 18:53:22 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementa
On Thu, 14 Oct 2021 00:23:29 GMT, Maurizio Cimadamore
wrote:
> I noted that in the static case, Poly does regress for fields - do we know
> why instance Poly is better than static Poly? That seems surprising.
I think you're asking why the regression of instance Poly is smaller than that
of
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by mchung (Reviewer).
On Wed, 13 Oct 2021 23:53:17 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
> src/java.base/shar
On Wed, 13 Oct 2021 23:49:19 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
> src/java.base/shar
On Thu, 14 Oct 2021 00:10:50 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
> src/java.base/shar
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request incrementally
On Fri, 8 Oct 2021 23:31:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementa
On Tue, 12 Oct 2021 17:44:08 GMT, Peter Levart wrote:
>> src/java.base/share/classes/jdk/internal/reflect/MethodHandleCharacterFieldAccessorImpl.java
>> line 137:
>>
>>> 135: {
>>> 136: if (isReadOnly()) {
>>> 137: ensureObj(obj); // throw NPE if obj is null on
>>>
Hi Ichiroh,
This behavioral change is not intentional. It's a bug introduced in
JDK-4947890. I create https://bugs.openjdk.java.net/browse/JDK-8275145
for this issue.
Thanks for the investigation.
Mandy
On 10/12/21 2:44 AM, Ichiroh Takiguchi wrote:
I have some questions for JDK-4947890。
On Tue, 12 Oct 2021 10:22:07 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove filelist which was added accidentally
>
> filelist line 1:
>
>>
ly to ensure the adjustment is only made if the
> implementation method is private method in the host class.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove filelist which was added accidentally
-
Changes:
- all
Classes compiled prior to the nestmate support will generate
`REF_invokeSpecial` if the implementation method is a private instance method.
Since a lambda proxy class is a hidden class, a nestmate of the host class, it
can invoke the private implementation method but it has to use
On Fri, 8 Oct 2021 23:31:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementa
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request incrementally with one addition
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request incrementally with two addi
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8013527
> [2]
> https://bugs.openjdk.java.net/browse/JDK-8271820?focusedCommentId=14439430=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14439430
Mandy Chung has updated the pull request with a new target base due to a
On Mon, 4 Oct 2021 22:24:39 GMT, Peter Levart wrote:
>> This patch improves reflective access speed as shown by the included
>> benchmarks:
>>
>> https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a
>>
>> ... and is also a prerequisite to make JEP
On Mon, 4 Oct 2021 15:49:43 GMT, Peter Levart wrote:
>> This patch improves reflective access speed as shown by the included
>> benchmarks:
>>
>> https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a
>>
>> ... and is also a prerequisite to make JEP
On Mon, 4 Oct 2021 15:51:18 GMT, Peter Levart wrote:
> One way this could be improved is to "stamp" the modifiers field with an
> additional bit (say 0x8000_) to always hold a non-zero value.
> Method::getModifiers() would then clear that bit in a returned value to stay
> compatible.
On Wed, 29 Sep 2021 17:56:00 GMT, Aleksey Shipilev wrote:
> Currently it fails with:
>
>
> $ CONF=linux-x86_64-server-fastdebug make run-test
> TEST=java/lang/management/MemoryMXBean/MemoryTest.java
>
> STDERR:
> java.lang.RuntimeException: TEST FAILED: Number of heap pools = 1 but
>
On Tue, 28 Sep 2021 08:25:17 GMT, Peter Levart wrote:
>> This patch improves reflective access speed as shown by the included
>> benchmarks:
>>
>> https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a
>>
>> ... and is also a prerequisite to make JEP
On Sun, 26 Sep 2021 13:58:35 GMT, Andrey Turbanov
wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
LGTM
-
Marked as reviewed by
On Mon, 27 Sep 2021 11:23:43 GMT, Claes Redestad wrote:
> A stray thought is why not most fields in `Field`/`Method`/`Constructor` are
> `final`, as my IDE suggests. I can't find any hotspot code that injects
> values to these fields. Experimentally changing most fields in `Field` to
> final
On Sat, 25 Sep 2021 14:22:28 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more
On Mon, 27 Sep 2021 12:04:48 GMT, Pavel Rappo wrote:
> This PR fixes indentation in the examples in the doc comment for
> java.lang.Throwable#printStackTrace().
>
> 1. Indentation in stack-trace output is significant. The cause of an
> exception is output on the same level of indentation as
On Sat, 25 Sep 2021 10:15:11 GMT, Peter Levart wrote:
> This patch improves reflective access speed as shown by the included
> benchmarks:
>
> https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a
>
> ... and is also a prerequisite to make JEP 416
On Mon, 27 Sep 2021 11:23:43 GMT, Claes Redestad wrote:
> This looks good, assuming Mandy is OK with extracting and adding to the
> microbenchmarks from JEP 416
I'm okay to include these microbenchmarks in this patch. I will merge the
change with JEP 416.
> A stray thought is why not most
On Sat, 25 Sep 2021 10:15:11 GMT, Peter Levart wrote:
> This patch improves reflective access speed as shown by the included
> benchmarks:
>
> https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a
>
> ... and is also a prerequisite to make JEP 416
201 - 300 of 3165 matches
Mail list logo
