Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v14]

2022-03-05 Thread Marcono1234
On Sat, 5 Mar 2022 19:48:47 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v10]

2022-02-28 Thread Marcono1234
On Fri, 25 Feb 2022 23:30:35 GMT, Yasser Bazzi wrote: >> src/java.base/share/classes/java/util/Random.java line 107: >> >>> 105: return rand; >>> 106: >>> 107: return (Random) new Random.RandomWrapper(random); >> >> Isn't the `(Random)` cast redundant? > > Eclipse

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v10]

2022-02-25 Thread Marcono1234
On Fri, 25 Feb 2022 22:56:36 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-25 Thread Marcono1234
On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default

Re: RFR: 8251989: Hex formatting and parsing utility [v9]

2020-10-27 Thread Marcono1234
On Tue, 27 Oct 2020 03:09:32 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly [v5]

2020-10-24 Thread Marcono1234
On Thu, 15 Oct 2020 19:20:28 GMT, Ian Graves wrote: >> The `java.util.Formatter` format specifies support for field widths, >> argument indexes, or precision lengths of a field that relate to the >> variadic arguments supplied to the formatter. These numbers are specified by >> integers,

Re: RFR: 8251989: Hex formatting and parsing utility [v8]

2020-10-23 Thread Marcono1234
On Thu, 22 Oct 2020 15:55:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8251989: Hex formatting and parsing utility [v7]

2020-10-21 Thread Marcono1234
On Wed, 21 Oct 2020 17:33:26 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-21 Thread Marcono1234
On Tue, 20 Oct 2020 14:37:01 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/util/HexFormat.java line 127: >> >>> 125: * >>> 126: * @implSpec >>> 127: * This class is immutable and thread-safe. >> >> I'm curious why this is an implSpec, and not just a normative statement? >>

Re: RFR: 8251989: Hex formatting and parsing utility [v2]

2020-10-13 Thread Marcono1234
On Tue, 13 Oct 2020 16:24:32 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/util/HexFormat.java line 1015: >> >>> 1013: */ >>> 1014: @Override >>> 1015: public String toString() { >> >> Might be useful to also include the class name? > > The caller may need to provide

Re: RFR: 8251989: Hex formatting and parsing utility [v2]

2020-10-13 Thread Marcono1234
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8251989: Hex formatting and parsing utility [v2]

2020-10-13 Thread Marcono1234
On Tue, 13 Oct 2020 16:15:51 GMT, Roger Riggs wrote: >> test/jdk/java/util/HexFormat/HexFormatTest.java line 406: >> >>> 404: >>> 405: int byteVal = hex.fromHexDigits(byteStr); >>> 406: assert(byteStr.equals("7f")); >> >> Why use regular `assert` statements in this test