Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]

2022-06-13 Thread Martin Doerr
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote: >> We still handle at a number of places ancient historic _MSC_VER versions of >> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). >> This should be cleaned up, as long as it is not 3rd party code that we don't >> want

Re: RFR: JDK-8288094: cleanup old _MSC_VER handling

2022-06-10 Thread Martin Doerr
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote: > We still handle at a number of places ancient historic _MSC_VER versions of > Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). > This should be cleaned up, as long as it is not 3rd party code that we don't > want to

Re: RFR: 8286182: C2: crash with SIGFPE when executing compiled code

2022-05-18 Thread Martin Doerr
On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote: > This patch backs out the changes made by > [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and > [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there > are failures due to div nodes floating above

Re: RFR: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause

2022-05-10 Thread Martin Doerr
On Mon, 9 May 2022 22:10:54 GMT, Christoph Langer wrote: > After https://bugs.openjdk.java.net/browse/JDK-8251329, javac throws errors > when the classpath > contains jar files with . or .. in its name. The error message, however, does > not help to find > the culprit. This could be improved.

Re: RFR: JDK-8285987: executing shell scripts without #! fails on Alpine linux

2022-05-05 Thread Martin Doerr
On Wed, 4 May 2022 12:04:47 GMT, Matthias Baesken wrote: > A couple a tests like java/lang/ProcessBuilder/Basic.java#id0.Basic_id0 and > jdk/jshell/ExternalEditorTest.java.ExternalEditorTest try to start small > shell scripts without #! at the first line of the script. This fails with >

Re: RFR: JDK-8285987: executing shell scripts without #! fails on Alpine linux

2022-05-05 Thread Martin Doerr
On Wed, 4 May 2022 12:04:47 GMT, Matthias Baesken wrote: > A couple a tests like java/lang/ProcessBuilder/Basic.java#id0.Basic_id0 and > jdk/jshell/ExternalEditorTest.java.ExternalEditorTest try to start small > shell scripts without #! at the first line of the script. This fails with >

Re: RFR: JDK-8286114: [test] show real exception in bomb call in sun/rmi/runtime/Log/checkLogging/CheckLogging.java

2022-05-04 Thread Martin Doerr
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote: > There is one TestLibrary.bomb call in > sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the > exception to bomb, that should be improved. Marked as reviewed by mdoerr (Reviewer). - PR:

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v2]

2022-02-11 Thread Martin Doerr
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote: >> I'm requesting comments and, hopefully, some help with this patch to replace >> `StringCoding.hasNegatives` with `countPositives`. The new method does a >> very similar pass, but alters the intrinsic to return the number of leading >>

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives

2022-02-10 Thread Martin Doerr
On Wed, 26 Jan 2022 12:51:31 GMT, Claes Redestad wrote: > I'm requesting comments and, hopefully, some help with this patch to replace > `StringCoding.hasNegatives` with `countPositives`. The new method does a very > similar pass, but alters the intrinsic to return the number of leading bytes

Re: RFR: 8262018: Wrong format in SAP copyright header of OsVersionTest

2021-02-19 Thread Martin Doerr
On Fri, 19 Feb 2021 10:35:21 GMT, Christoph Langer wrote: > The fix for JDK-8261753 introduced a ',' after the copyright years which is > not the expected format for SAP copyrights. Seems like this is the only place where we have the wrong comma. Looks good and trivial. Thanks for fixing!

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v12]

2020-11-05 Thread Martin Doerr
On Thu, 5 Nov 2020 01:20:08 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v10]

2020-11-04 Thread Martin Doerr
On Tue, 3 Nov 2020 03:01:09 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v8]

2020-10-22 Thread Martin Doerr
On Thu, 22 Oct 2020 14:01:05 GMT, Paul Murphy wrote: >> CoreyAshford has updated the pull request incrementally with one additional >> commit since the last revision: >> >> TestBase64.java: remove jdk.test.lib.Utils from @build which was causing >> Tier3 failures. > >

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v7]

2020-10-21 Thread Martin Doerr
On Wed, 21 Oct 2020 01:51:26 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v4]

2020-10-14 Thread Martin Doerr
On Wed, 14 Oct 2020 02:04:42 GMT, CoreyAshford wrote: >>> Hi Corey, thanks for taking some stuff out of the “too short” path. There >>> may be a performance regression when decoding >>> many short arrays because of the stub call overhead and the usage of the >>> slower part of the Java

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v4]

2020-10-13 Thread Martin Doerr
On Mon, 12 Oct 2020 22:00:24 GMT, CoreyAshford wrote: >> This latest push passes the intrinsic regression test. I had run the >> intrinsic TestBase64 regression test on the >> previous push, but not the one in utils. Interesting. Somehow it didn't >> occur to me that there could be a

Re: RFR: 8248188: Add HotSpotIntrinsicCandidate and API for Base64 decoding

2020-09-26 Thread Martin Doerr
On Tue, 22 Sep 2020 02:45:36 GMT, CoreyAshford wrote: > This patch set encompasses the following commits: > > - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - > decodeBlock(), and provides a flexible API for > the intrinsic. The API is similar to the existing

Re: RFR: 8248188: Add HotSpotIntrinsicCandidate and API for Base64 decoding

2020-09-25 Thread Martin Doerr
On Wed, 23 Sep 2020 22:28:38 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for >> the intrinsic. The API is similar to the existing