Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)

2021-09-13 Thread Nils Eliasson
On Thu, 20 May 2021 08:03:03 GMT, Nils Eliasson wrote: >> I agree with Laurent (bourgesl), see his comment on May 15 regarding to xor: >> using Unsafe is only 2% faster, not worth the extra complexity for few >> percent. > > A small update of the XorINodes type calculati

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)

2021-09-13 Thread Nils Eliasson
On Tue, 18 May 2021 19:58:35 GMT, iaroslavski wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267332 > > I agree with Laurent (bourgesl), see his comment on May 15 regarding to xor: > using Unsafe is only 2% faster, not worth the extra complexity for few > percent. A small update of the Xo

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)

2021-09-13 Thread Nils Eliasson
On Thu, 13 May 2021 20:47:48 GMT, Richard Startin wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor

Re: RFR: 8267969: Add vectorized implementation for VectorMask.eq() [v2]

2021-06-02 Thread Nils Eliasson
On Wed, 2 Jun 2021 01:56:00 GMT, Xiaohong Gong wrote: >> Currently `"VectorMask.eq()" `is not vectorized: >> >> public VectorMask eq(VectorMask m) { >> // FIXME: Generate good code here. >> return bOp(m, (i, a, b) -> a == b); >> } >> >> This can be implemented by calling

Re: RFR: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973

2021-05-19 Thread Nils Eliasson
On Wed, 19 May 2021 08:20:13 GMT, Jatin Bhateja wrote: > Relevant declarations modified and tested with -Werror, no longer see > unchecked conversion warnings. > > Kindly review and approve. Looks good. - Marked as reviewed by neliasso (Reviewer). PR: https://git.openjdk.java.ne

Integrated: 8255964: Add all details to jstack log in jtreg timeout handler

2020-11-13 Thread Nils Eliasson
On Thu, 5 Nov 2020 17:09:58 GMT, Nils Eliasson wrote: > This patch adds jcmd Thread.print to the jtreg timeout handler. > > Please review. This pull request has now been integrated. Changeset: 41139e31 Author:Nils Eliasson URL: https://git.openjdk.java.net/jdk/commit/41139

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler [v2]

2020-11-06 Thread Nils Eliasson
> This patch adds jcmd Thread.print to the jtreg timeout handler. > > Please review. Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision: add extended printing to jstack - Changes: - all: https://git.openjdk.jav

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

2020-11-06 Thread Nils Eliasson
On Fri, 6 Nov 2020 15:53:35 GMT, Igor Ignatyev wrote: >> This patch adds jcmd Thread.print to the jtreg timeout handler. >> >> Please review. > > Hi Nils, > > It looks alright, but could you please elaborate on why we need it when there > is already `jstack` action? > > — Igor They have the

RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

2020-11-05 Thread Nils Eliasson
This patch adds jcmd Thread.print to the jtreg timeout handler. Please review. - Commit messages: - Add jcmd thread.print to timeout handler Changes: https://git.openjdk.java.net/jdk/pull/1080/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1080&range=00 Issue: https

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v6]

2020-10-14 Thread Nils Eliasson
On Mon, 12 Oct 2020 11:17:25 GMT, Jason Tatton wrote: >> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 >> byte encoded Strings). It is provided for >> x86 and ARM64. The implementation is greatly inspired by the indexOf(char) >> intrinsic for StringUTF16. To inco

Re: RFR: 8252847: Optimize primitive arrayCopy stubs using AVX-512 masked instructions [v5]

2020-09-25 Thread Nils Eliasson
On Tue, 22 Sep 2020 15:55:11 GMT, Jatin Bhateja wrote: >> Summary: >> >> 1) New AVX3 optimized stubs for both conjoint and disjoint arraycopy. >> 2) Special instruction sequence blocks for copy sizes b/w 32-192 bytes. >> 3) Block copy operation above 192 bytes is performed using destination