ted webrev is at,
> http://cr.openjdk.java.net/~henryjen/jdk9/8044862/1/webrev/
>
> Cheers,
> Henry
>
>
> On 07/09/2014 01:07 AM, Petr Pchelko wrote:
>> Hello, Henry.
>>
>> AquaComboBoxRendererInternal : why and not just ?
>>
>> AquaComboBox
Hello, Henry.
AquaComboBoxRendererInternal : why and not just ?
AquaComboBoxUI:427, 510, 530 - you can replace JComboBox with
JComboBox and avoid a @SupressWarning annotation.
AquaFileChooserUI.createDirectoryComboBoxRenderer actually returns a
ListCellRenderer,
DirectoryComboBoxModel is a
Hello, Joe.
The fix looks good.
> assuming of course they don't leak into the serialized stream of a supported
> type.
These classes are related to the AppletViewer, so they should not.
With best regards. Petr.
On 12.03.2014, at 11:29, Alan Bateman wrote:
>
> cc'ing awt-dev as this where th
gt; On 25/02/2014 10:31, Petr Pchelko wrote:
>> Hello, Core and AWT teams.
>>
>> In AWT we have a lot of pending exception warnings which are now being
>> fixed. A big fraction of this warnings is about a pending JNI exception at a
>> call to JNU_Throw*.
>&g
Hello, Core and AWT teams.
In AWT we have a lot of pending exception warnings which are now being fixed. A
big fraction of this warnings is about a pending JNI exception at a call to
JNU_Throw*.
Why don’t we add an env->ExceptionClear() call in the beginning of each
JNU_Throw function? It is ab
t until the next integration while
dependent fixes are being reviewed. I'll push this into dev forest.
With best regards. Petr.
On 24.02.2014, at 16:10, Alan Bateman wrote:
> On 24/02/2014 09:02, Petr Pchelko wrote:
>> Hello,
>>
>> Please review the fix for the i
Hello,
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8035640
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8035640/webrev.00/
In AWT code we have quite a lot of C++ sources, but JNU_CHECK_EXCEPTION macros
could not be used there, because the JNI
the hg history for this file.
>>>
>>> We wouldn't. Mercurial handles renaming of files very well. See `hg help
>>> rename` for more details. (I'm not suggesting to rename this file though.)
>>>
>>> --
>>> best regards,
&g
Added macosx-port-dev
On May 21, 2013, at 10:57 AM, David Holmes wrote:
> Adding core-libs as this is actually a launcher change.
>
> David
>
> On 21/05/2013 4:36 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>>
>> Please review the fix for the issue:
>>
